From: Aaron Schulz <aschulz@wikimedia.org>
Date: Wed, 11 Jul 2018 13:04:36 +0000 (+0100)
Subject: Convert ChangesList to using MapCacheLRU
X-Git-Tag: 1.34.0-rc.0~4754^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/modifier.php?a=commitdiff_plain;h=6986130f33ec9b08316ad9e506c18f4ab817e04a;p=lhc%2Fweb%2Fwiklou.git

Convert ChangesList to using MapCacheLRU

Change-Id: I1cafb601dc644ca6d58ec0430e9608cfb497bcd8
---

diff --git a/includes/changes/ChangesList.php b/includes/changes/ChangesList.php
index c0822c3438..eb9febea08 100644
--- a/includes/changes/ChangesList.php
+++ b/includes/changes/ChangesList.php
@@ -44,7 +44,7 @@ class ChangesList extends ContextSource {
 	/** @var callable */
 	protected $changeLinePrefixer;
 
-	/** @var BagOStuff */
+	/** @var MapCacheLRU */
 	protected $watchMsgCache;
 
 	/**
@@ -72,7 +72,7 @@ class ChangesList extends ContextSource {
 			$this->skin = $obj;
 		}
 		$this->preCacheMessages();
-		$this->watchMsgCache = new HashBagOStuff( [ 'maxKeys' => 50 ] );
+		$this->watchMsgCache = new MapCacheLRU( 50 );
 		$this->linkRenderer = MediaWikiServices::getInstance()->getLinkRenderer();
 		$this->filterGroups = $filterGroups;
 	}
@@ -602,10 +602,9 @@ class ChangesList extends ContextSource {
 		if ( $count <= 0 ) {
 			return '';
 		}
-		$cache = $this->watchMsgCache;
-		return $cache->getWithSetCallback(
-			$cache->makeKey( 'watching-users-msg', $count ),
-			$cache::TTL_INDEFINITE,
+
+		return $this->watchMsgCache->getWithSetCallback(
+			"watching-users-msg:$count",
 			function () use ( $count ) {
 				return $this->msg( 'number_of_watching_users_RCview' )
 					->numParams( $count )->escaped();