From f0c82844d2702d3e0b908e36b424499b70091c3b Mon Sep 17 00:00:00 2001 From: Alexandre Emsenhuber Date: Fri, 8 Feb 2013 14:07:40 +0100 Subject: [PATCH] Correct check whether the e-mail field was filled in Special:Userlogin/signup Use a strict comparison with '' instead of empty(), otherwise this allows user to give "0" as an e-mail address. Also use strval() if in any case null or something like that would be passed. Change-Id: Ide7d35c52a04d05b43ae9fd37f7586bb4a67d4ed --- includes/specials/SpecialUserlogin.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/specials/SpecialUserlogin.php b/includes/specials/SpecialUserlogin.php index 63d101b8ee..6e4f5d47aa 100644 --- a/includes/specials/SpecialUserlogin.php +++ b/includes/specials/SpecialUserlogin.php @@ -392,11 +392,11 @@ class LoginForm extends SpecialPage { # if you need a confirmed email address to edit, then obviously you # need an email address. - if ( $wgEmailConfirmToEdit && empty( $this->mEmail ) ) { + if ( $wgEmailConfirmToEdit && strval( $this->mEmail ) === '' ) { return Status::newFatal( 'noemailtitle' ); } - if( !empty( $this->mEmail ) && !Sanitizer::validateEmail( $this->mEmail ) ) { + if ( strval( $this->mEmail ) !== '' && !Sanitizer::validateEmail( $this->mEmail ) ) { return Status::newFatal( 'invalidemailaddress' ); } -- 2.20.1