From bfbabaab02ae0273229e0bc3745d0f84c6e81014 Mon Sep 17 00:00:00 2001 From: Reedy Date: Mon, 17 Dec 2012 21:18:50 +0000 Subject: [PATCH] Suppress warnings around copy call Attempt to shut some noise in production logs Change-Id: I4bac4027d82e4194b6ec46658d52f49038db573c Warning: copy(/mnt/thumbs2/wikipedia/commons/thumb/8/8c/Map_of_USA_AK_full.png/120px-Map_of_USA_AK_full.png) [function.copy]: failed to open stream: No such file or directory in /usr/local/apache/common-local/php-1.21wmf6/includes/filebackend/FSFileBackend.php on line 254 --- includes/filebackend/FSFileBackend.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/includes/filebackend/FSFileBackend.php b/includes/filebackend/FSFileBackend.php index c60abb1d25..94502571a8 100644 --- a/includes/filebackend/FSFileBackend.php +++ b/includes/filebackend/FSFileBackend.php @@ -251,7 +251,9 @@ class FSFileBackend extends FileBackendStore { ) ); $status->value = new FSFileOpHandle( $this, $params, 'Store', $cmd, $dest ); } else { // immediate write + wfSuppressWarnings(); $ok = copy( $params['src'], $dest ); + wfRestoreWarnings(); // In some cases (at least over NFS), copy() returns true when it fails if ( !$ok || ( filesize( $params['src'] ) !== filesize( $dest ) ) ) { if ( $ok ) { // PHP bug -- 2.20.1