* Added global $wgStyleVersion to centralize bumping CSS and JS file versions
[lhc/web/wiklou.git] / includes / SkinTemplate.php
index 5a02b77..4ae54d9 100644 (file)
@@ -138,7 +138,6 @@ class SkinTemplate extends Skin {
                global $wgMaxCredits, $wgShowCreditsIfMax;
                global $wgPageShowWatchingUsers;
                global $wgUseTrackbacks;
-               global $wgDBname;
                global $wgArticlePath, $wgScriptPath, $wgServer, $wgLang, $wgCanonicalNamespaceNames;
 
                $fname = 'SkinTemplate::outputPage';
@@ -174,11 +173,11 @@ class SkinTemplate extends Skin {
                $this->userpage = $userPage->getPrefixedText();
 
                if ( $wgUser->isLoggedIn() || $this->showIPinHeader() ) {
-                       $this->userpageUrlDetails = $this->makeUrlDetails($this->userpage);
+                       $this->userpageUrlDetails = self::makeUrlDetails( $this->userpage );
                } else {
                        # This won't be used in the standard skins, but we define it to preserve the interface
                        # To save time, we check for existence
-                       $this->userpageUrlDetails = $this->makeKnownUrlDetails($this->userpage);
+                       $this->userpageUrlDetails = self::makeKnownUrlDetails( $this->userpage );
                }
 
                $this->usercss =  $this->userjs = $this->userjsprev = false;
@@ -275,16 +274,16 @@ class SkinTemplate extends Skin {
                global $wgUseSiteJs;
                if ($wgUseSiteJs) {
                        if($this->loggedin) {
-                               $tpl->set( 'jsvarurl', $this->makeUrl('-','action=raw&smaxage=0&gen=js') );
+                               $tpl->set( 'jsvarurl', self::makeUrl('-','action=raw&smaxage=0&gen=js') );
                        } else {
-                               $tpl->set( 'jsvarurl', $this->makeUrl('-','action=raw&gen=js') );
+                               $tpl->set( 'jsvarurl', self::makeUrl('-','action=raw&gen=js') );
                        }
                } else {
                        $tpl->set('jsvarurl', false);
                }
                $newtalks = $wgUser->getNewMessageLinks();
 
-               if (count($newtalks) == 1 && $newtalks[0]["wiki"] === $wgDBname) {
+               if (count($newtalks) == 1 && $newtalks[0]["wiki"] === wfWikiID() ) {
                        $usertitle = $this->mUser->getUserPage();
                        $usertalktitle = $usertitle->getTalkPage();
                        if( !$usertalktitle->equals( $this->mTitle ) ) {
@@ -491,27 +490,27 @@ class SkinTemplate extends Skin {
                                'class' => $usertalkUrlDetails['exists']?false:'new',
                                'active' => ( $usertalkUrlDetails['href'] == $pageurl )
                        );
-                       $href = $this->makeSpecialUrl('Preferences');
+                       $href = self::makeSpecialUrl( 'Preferences' );
                        $personal_urls['preferences'] = array(
-                               'text' => wfMsg('mypreferences'),
-                               'href' => $this->makeSpecialUrl('Preferences'),
+                               'text' => wfMsg( 'mypreferences' ),
+                               'href' => self::makeSpecialUrl( 'Preferences' ),
                                'active' => ( $href == $pageurl )
                        );
-                       $href = $this->makeSpecialUrl('Watchlist');
+                       $href = self::makeSpecialUrl( 'Watchlist' );
                        $personal_urls['watchlist'] = array(
-                               'text' => wfMsg('watchlist'),
+                               'text' => wfMsg( 'watchlist' ),
                                'href' => $href,
                                'active' => ( $href == $pageurl )
                        );
-                       $href = $this->makeSpecialUrl("Contributions/$this->username");
+                       $href = self::makeSpecialUrl( "Contributions/$this->username" );
                        $personal_urls['mycontris'] = array(
-                               'text' => wfMsg('mycontris'),
+                               'text' => wfMsg( 'mycontris' ),
                                'href' => $href
                                # FIXME #  'active' => ( $href == $pageurl . '/' . $this->username )
                        );
                        $personal_urls['logout'] = array(
-                               'text' => wfMsg('userlogout'),
-                               'href' => $this->makeSpecialUrl( 'Userlogout',
+                               'text' => wfMsg( 'userlogout' ),
+                               'href' => self::makeSpecialUrl( 'Userlogout',
                                        $wgTitle->getNamespace() === NS_SPECIAL && $wgTitle->getText() === 'Preferences' ? '' : "returnto={$this->thisurl}"
                                )
                        );
@@ -534,14 +533,14 @@ class SkinTemplate extends Skin {
                                );
                                $personal_urls['anonlogin'] = array(
                                        'text' => wfMsg('userlogin'),
-                                       'href' => $this->makeSpecialUrl('Userlogin', 'returnto=' . $this->thisurl ),
+                                       'href' => self::makeSpecialUrl( 'Userlogin', 'returnto=' . $this->thisurl ),
                                        'active' => ( NS_SPECIAL == $wgTitle->getNamespace() && 'Userlogin' == $wgTitle->getDBkey() )
                                );
                        } else {
 
                                $personal_urls['login'] = array(
                                        'text' => wfMsg('userlogin'),
-                                       'href' => $this->makeSpecialUrl('Userlogin', 'returnto=' . $this->thisurl ),
+                                       'href' => self::makeSpecialUrl( 'Userlogin', 'returnto=' . $this->thisurl ),
                                        'active' => ( NS_SPECIAL == $wgTitle->getNamespace() && 'Userlogin' == $wgTitle->getDBkey() )
                                );
                        }
@@ -582,23 +581,23 @@ class SkinTemplate extends Skin {
                        'href' => $title->getLocalUrl( $query ) );
        }
 
-       function makeTalkUrlDetails( $name, $urlaction='' ) {
+       function makeTalkUrlDetails( $name, $urlaction = '' ) {
                $title = Title::newFromText( $name );
                $title = $title->getTalkPage();
-               $this->checkTitle($title, $name);
+               self::checkTitle( $title, $name );
                return array(
                        'href' => $title->getLocalURL( $urlaction ),
-                       'exists' => $title->getArticleID() != 0?true:false
+                       'exists' => $title->getArticleID() != 0 ? true : false
                );
        }
 
-       function makeArticleUrlDetails( $name, $urlaction='' ) {
+       function makeArticleUrlDetails( $name, $urlaction = '' ) {
                $title = Title::newFromText( $name );
                $title= $title->getSubjectPage();
-               $this->checkTitle($title, $name);
+               self::checkTitle( $title, $name );
                return array(
                        'href' => $title->getLocalURL( $urlaction ),
-                       'exists' => $title->getArticleID() != 0?true:false
+                       'exists' => $title->getArticleID() != 0 ? true : false
                );
        }
 
@@ -713,7 +712,7 @@ class SkinTemplate extends Skin {
                                                        'class' => false,
                                                        'text' => wfMsgExt( 'undelete_short', array( 'parsemag' ), $n ),
                                                        'href' => $undelTitle->getLocalUrl( 'target=' . urlencode( $this->thispage ) )
-                                                       #'href' => $this->makeSpecialUrl("Undelete/$this->thispage")
+                                                       #'href' => self::makeSpecialUrl( "Undelete/$this->thispage" )
                                                );
                                        }
                                }
@@ -766,7 +765,7 @@ class SkinTemplate extends Skin {
                                $content_actions['varlang-' . $vcount] = array(
                                                'class' => $selected,
                                                'text' => $varname,
-                                               'href' => $this->mTitle->getLocalUrl( $actstr . 'variant=' . urlencode( $code ) )
+                                               'href' => $this->mTitle->getLocalURL('',$code)
                                        );
                                $vcount ++;
                        }
@@ -799,20 +798,20 @@ class SkinTemplate extends Skin {
                $diff = $wgRequest->getVal( 'diff' );
 
                $nav_urls = array();
-               $nav_urls['mainpage'] = array('href' => $this->makeI18nUrl('mainpage'));
+               $nav_urls['mainpage'] = array( 'href' => self::makeI18nUrl( 'mainpage') );
                if( $wgEnableUploads ) {
                        if ($wgUploadNavigationUrl) {
-                               $nav_urls['upload'] = array('href' => $wgUploadNavigationUrl );
+                               $nav_urls['upload'] = array( 'href' => $wgUploadNavigationUrl );
                        } else {
-                               $nav_urls['upload'] = array('href' => $this->makeSpecialUrl('Upload'));
+                               $nav_urls['upload'] = array( 'href' => self::makeSpecialUrl( 'Upload' ) );
                        }
                } else {
                        if ($wgUploadNavigationUrl)
-                               $nav_urls['upload'] = array('href' => $wgUploadNavigationUrl );
+                               $nav_urls['upload'] = array( 'href' => $wgUploadNavigationUrl );
                        else
                                $nav_urls['upload'] = false;
                }
-               $nav_urls['specialpages'] = array('href' => $this->makeSpecialUrl('Specialpages'));
+               $nav_urls['specialpages'] = array( 'href' => self::makeSpecialUrl( 'Specialpages' ) );
 
 
                // A print stylesheet is attached to all pages, but nobody ever
@@ -869,11 +868,11 @@ class SkinTemplate extends Skin {
 
                if($id || $ip) { # both anons and non-anons have contri list
                        $nav_urls['contributions'] = array(
-                               'href' => $this->makeSpecialUrl('Contributions/' . $this->mTitle->getText() )
+                               'href' => self::makeSpecialUrl( 'Contributions/' . $this->mTitle->getText() )
                        );
                        if ( $wgUser->isAllowed( 'block' ) )
                                $nav_urls['blockip'] = array(
-                                       'href' => $this->makeSpecialUrl( 'Blockip/' . $this->mTitle->getText() )
+                                       'href' => self::makeSpecialUrl( 'Blockip/' . $this->mTitle->getText() )
                                );
                } else {
                        $nav_urls['contributions'] = false;
@@ -881,7 +880,7 @@ class SkinTemplate extends Skin {
                $nav_urls['emailuser'] = false;
                if( $this->showEmailUser( $id ) ) {
                        $nav_urls['emailuser'] = array(
-                               'href' => $this->makeSpecialUrl('Emailuser/' . $this->mTitle->getText() )
+                               'href' => self::makeSpecialUrl( 'Emailuser/' . $this->mTitle->getText() )
                        );
                }
                wfProfileOut( $fname );
@@ -909,6 +908,11 @@ class SkinTemplate extends Skin {
                $sitecss = '';
                $usercss = '';
                $siteargs = '&maxage=' . $wgSquidMaxage;
+               if( $this->loggedin ) {
+                       // Ensure that logged-in users' generated CSS isn't clobbered
+                       // by anons' publicly cacheable generated CSS.
+                       $siteargs .= '&smaxage=0';
+               }
 
                # Add user-specific code if this is a user and we allow that kind of thing
 
@@ -921,21 +925,24 @@ class SkinTemplate extends Skin {
                                $usercss = $wgRequest->getText('wpTextbox1');
                        } else {
                                $usercss = '@import "' .
-                                 $this->makeUrl($this->userpage . '/'.$this->skinname.'.css',
+                                 self::makeUrl($this->userpage . '/'.$this->skinname.'.css',
                                                                 'action=raw&ctype=text/css') . '";' ."\n";
                        }
 
                        $siteargs .= '&ts=' . $wgUser->mTouched;
                }
 
-               if ($wgContLang->isRTL()) $sitecss .= '@import "' . $wgStylePath . '/' . $this->stylename . '/rtl.css";' . "\n";
+               if( $wgContLang->isRTL() ) {
+                       global $wgStyleVersion;
+                       $sitecss .= "@import \"$wgStylePath/$this->stylename/rtl.css?$wgStyleVersion\";\n";
+               }
 
                # If we use the site's dynamic CSS, throw that in, too
                if ( $wgUseSiteCss ) {
                        $query = "usemsgcache=yes&action=raw&ctype=text/css&smaxage=$wgSquidMaxage";
-                       $sitecss .= '@import "' . $this->makeNSUrl('Common.css', $query, NS_MEDIAWIKI) . '";' . "\n";
-                       $sitecss .= '@import "' . $this->makeNSUrl(ucfirst($this->skinname) . '.css', $query, NS_MEDIAWIKI) . '";' . "\n";
-                       $sitecss .= '@import "' . $this->makeUrl('-','action=raw&gen=css' . $siteargs) . '";' . "\n";
+                       $sitecss .= '@import "' . self::makeNSUrl( 'Common.css', $query, NS_MEDIAWIKI) . '";' . "\n";
+                       $sitecss .= '@import "' . self::makeNSUrl( ucfirst( $this->skinname ) . '.css', $query, NS_MEDIAWIKI ) . '";' . "\n";
+                       $sitecss .= '@import "' . self::makeUrl( '-', 'action=raw&gen=css' . $siteargs ) . '";' . "\n";
                }
 
                # If we use any dynamic CSS, make a little CDATA block out of it.
@@ -961,7 +968,7 @@ class SkinTemplate extends Skin {
                                # XXX: additional security check/prompt?
                                $this->userjsprev = '/*<![CDATA[*/ ' . $wgRequest->getText('wpTextbox1') . ' /*]]>*/';
                        } else {
-                               $this->userjs = $this->makeUrl($this->userpage.'/'.$this->skinname.'.js', 'action=raw&ctype='.$wgJsMimeType.'&dontcountme=s');
+                               $this->userjs = self::makeUrl($this->userpage.'/'.$this->skinname.'.js', 'action=raw&ctype='.$wgJsMimeType.'&dontcountme=s');
                        }
                }
                wfProfileOut( $fname );