From 2b3a21f5c1c69fb1e03af717bb5b50037436d13c Mon Sep 17 00:00:00 2001 From: Derick Alangi Date: Fri, 11 Jan 2019 16:40:27 +0100 Subject: [PATCH] actions: Avoid use of is_null() PHP function where necessary WRT performance, is_null() is a few nanoseconds slower than === null due to function call overhead. Also, I personally think using the identical check on null is slightly more readable than using is_null(). Change-Id: Ie5b1ac17a18907e92eb3042decb7fc75e903123d --- includes/actions/HistoryAction.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/actions/HistoryAction.php b/includes/actions/HistoryAction.php index d6b80570ed..fdf4f85336 100644 --- a/includes/actions/HistoryAction.php +++ b/includes/actions/HistoryAction.php @@ -511,7 +511,7 @@ class HistoryPager extends ReverseChronologicalPager { if ( $row->rev_parent_id ) { $revIds[] = $row->rev_parent_id; } - if ( !is_null( $row->user_name ) ) { + if ( $row->user_name !== null ) { $batch->add( NS_USER, $row->user_name ); $batch->add( NS_USER_TALK, $row->user_name ); } else { # for anons or usernames of imported revisions -- 2.20.1