jenkins-bot [Tue, 4 Dec 2018 06:27:45 +0000 (06:27 +0000)]
Merge "build: Updating mediawiki/mediawiki-codesniffer to 23.0.0"
jenkins-bot [Tue, 4 Dec 2018 06:27:39 +0000 (06:27 +0000)]
Merge "Do not pass unused parameter"
jenkins-bot [Tue, 4 Dec 2018 06:27:33 +0000 (06:27 +0000)]
Merge "media: Do not pass unused parameter"
jenkins-bot [Tue, 4 Dec 2018 06:27:27 +0000 (06:27 +0000)]
Merge "Remove unused parameter"
Subramanya Sastry [Mon, 3 Dec 2018 22:05:02 +0000 (16:05 -0600)]
Sync up with Parsoid parserTests.txt
This now aligns with Parsoid commit
5eb1690104ff70e0bd090b5cb93900b4be766377
Change-Id: I051ff481147d9a2189442f885131b47a6c00d373
jenkins-bot [Mon, 3 Dec 2018 21:35:53 +0000 (21:35 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Mon, 3 Dec 2018 21:35:38 +0000 (21:35 +0000)]
Merge "Restore gray coloring for autocomments"
jenkins-bot [Mon, 3 Dec 2018 21:35:28 +0000 (21:35 +0000)]
Merge "Don't link wikilinks in section heading autocomments"
jenkins-bot [Mon, 3 Dec 2018 21:35:16 +0000 (21:35 +0000)]
Merge "Restore old HTML structure for history section links"
Translation updater bot [Mon, 3 Dec 2018 21:11:27 +0000 (22:11 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I44902269c4317e5263ab2cb24f1e11ae6cc6e0f8
jenkins-bot [Mon, 3 Dec 2018 21:07:44 +0000 (21:07 +0000)]
Merge "RevisionStore: Avoid exception on prev/next of deleted revision"
Kunal Mehta [Sat, 1 Dec 2018 09:39:48 +0000 (01:39 -0800)]
Restore gray coloring for autocomments
The main criticism of T165189 has been the "sea of blue" it causes. Given that
the most important part is the actual comment, other elements like the auto-
comment should be deemphasized (per Anomie).
This won't bring back exactly the same color scheme as before, as now the
arrow will also be colored gray instead of blue.
I don't think this is a permanent solution, and we should continue discussing
and iterating on how to address the prominence vs. accessibility issues.
It was also noted that the current gray is not fully accessible (T125657),
which should be addressed in a separate patch.
Bug: T165189
Change-Id: Ic8903a539017a3fd3d47627f8485caed09fce482
Kunal Mehta [Sat, 1 Dec 2018 09:19:33 +0000 (01:19 -0800)]
Don't link wikilinks in section heading autocomments
Previously, a manually constructed autocomment in the form of
/* [[Some link]] */
would create a link to the the section, and then the "Some link" page.
After T165189 was implemented, the entire autocomment is now a link to
the section, so we're creating links inside of a link...which is
problematic. In most contexts (history and watchlist particularly), the
section link is more important than the title in the section heading, so
that's what we'll favor here.
It's worth noting that this situation is a manually created edge case.
Even if the section heading is a wikilink, the edit summary will
autofill a section autocomment without the double brackets.
We'll now render the double brackets ([[...]]) and not link them. This
is what the user literally typed, and matches the existing practice of
rendering templates in section headings with their literal syntax. And
as a bonus, it's still possible for user scripts such as wikEdDiff to
turn the rendered double brackets into a real link if users want.
Bug: T165189
Change-Id: Ib10679edd76c72a60d7e1c89fc8454166e34c463
Kunal Mehta [Sat, 1 Dec 2018 08:47:03 +0000 (00:47 -0800)]
Restore old HTML structure for history section links
A follow-up to
0a8e16d7cfe6c thanks to Anomie's code review.
The section title is now inside <span dir="auto"> and <span
class="autocomment">, as before. $wgLang->getDirMark() between the arrow
and the text was restored.
Given the comment
/* External links */ removed bogus entries
the HTML before
0a8e16d7cfe6c looked like:
<a href="#External_links">→</a><span dir="auto"><span
class="autocomment">External links: </span> removed bogus entries</span>
after this change, it will look like:
<span dir="auto"><span class="autocomment"><a
href="#External_links">→External links</a>: </span> removed bogus
entries</span>
The issue of having links be inside other links will be addressed in a
separate patch.
Bug: T165189
Change-Id: I31d87a87ccaf50de58fdd0621c46133b2881b490
jenkins-bot [Mon, 3 Dec 2018 18:18:54 +0000 (18:18 +0000)]
Merge "Fix unexpected return type of User::idFromName()"
jenkins-bot [Mon, 3 Dec 2018 18:18:49 +0000 (18:18 +0000)]
Merge "Delete unused variable"
jenkins-bot [Mon, 3 Dec 2018 18:18:44 +0000 (18:18 +0000)]
Merge "mail: Correct return value of sendPersonalised() method"
jenkins-bot [Mon, 3 Dec 2018 17:27:38 +0000 (17:27 +0000)]
Merge "Delete always true condition"
jenkins-bot [Mon, 3 Dec 2018 17:25:22 +0000 (17:25 +0000)]
Merge "Delete unused variable"
Jakub Vrana [Sun, 2 Dec 2018 18:26:51 +0000 (19:26 +0100)]
Delete unused variable
Found by PHPStan.
Change-Id: If985b06fcc9e37b8747da69d1aac63a5ee944aef
jenkins-bot [Mon, 3 Dec 2018 16:28:59 +0000 (16:28 +0000)]
Merge "media: Add missing return to MediaTransformOutput::streamFile"
Alangi Derick [Mon, 3 Dec 2018 14:09:14 +0000 (15:09 +0100)]
mail: Correct return value of sendPersonalised() method
If email is not successfully sent, return Status (with appropriate
status error) and also, if successfully sent, return Status::newGood().
Change-Id: I602e30641b88614087d9aff83cf8c93e32af7b81
jenkins-bot [Mon, 3 Dec 2018 16:21:19 +0000 (16:21 +0000)]
Merge "Delete always true condition"
jenkins-bot [Mon, 3 Dec 2018 16:20:06 +0000 (16:20 +0000)]
Merge "[MCR] Introduce SlotRoleHandler and SlotRoleRegistry"
Alangi Derick [Mon, 3 Dec 2018 14:26:02 +0000 (15:26 +0100)]
media: Add missing return to MediaTransformOutput::streamFile
Change-Id: Icf3999ae1a70dc2e702680d9b8c542c0f16f3a17
jenkins-bot [Mon, 3 Dec 2018 13:39:23 +0000 (13:39 +0000)]
Merge "htmlform: Fix multiple PHPDoc annotations in htmlform module"
jenkins-bot [Mon, 3 Dec 2018 13:39:18 +0000 (13:39 +0000)]
Merge "block: Fix PHPDoc comments to match function signature (or method)"
Thiemo Kreuz [Mon, 3 Dec 2018 13:33:48 +0000 (14:33 +0100)]
Fix unexpected return type of User::idFromName()
The user_id is an unsigned integer in the database. But not all database
abstractions we use are guaranteed to return integer values as PHP
integers. Sometimes it's a string and needs an integer cast first.
Want proof? Search for usages of this method. Almost all add an (int)
cast. This is weird and should not be necessary.
Change-Id: If1d706f73350fca5b3a0f1e0de59e4518162445b
Alangi Derick [Mon, 3 Dec 2018 11:47:12 +0000 (12:47 +0100)]
htmlform: Fix multiple PHPDoc annotations in htmlform module
- Add @param annotation for $params variable for __construct() method
in the HTMLExpiryField class.
- Add @throws annotation for getOptionsOOUI() method that throws a
MWException and remove "@return array" as this method only throw an
exception now.
Change-Id: I292f6ae04b840f6f6f74b7c92f834f056659fbe2
jenkins-bot [Mon, 3 Dec 2018 12:45:28 +0000 (12:45 +0000)]
Merge "debug: Correct $level PHPDoc param datatype in SyslogHandler.php"
Alangi Derick [Mon, 3 Dec 2018 11:25:33 +0000 (12:25 +0100)]
export: Fix return value of write() function in DumpOutput.php
Per http://php.net/manual/en/function.print.php, print always returns
1 (integer value of one) but write() doesn't actually return this value
to it's caller. So "@return bool" in this case doesn't make sense as
one will think it's returning a bool type. `write()` only takes a string
and prints it, and if we really want to return it's value (in this case),
it will be "@return int" not data of type bool.
Change-Id: I45b4a157cde2f768d77dda76d6ae0caa47e28f20
Alangi Derick [Mon, 3 Dec 2018 11:00:49 +0000 (12:00 +0100)]
debug: Correct $level PHPDoc param datatype in SyslogHandler.php
In Monolog\Logger (Logger.php), the logger levels are constants (interger values).
Logger::DEBUG is a constant (int) with value 100 which depicts that error logging
level. Datatype of these values; DEBUG, INFO, WARNING, etc are all integers not
strings.
Change-Id: I1cc67381bc64800241f5f9b7232ffe5419388d8a
Alangi Derick [Mon, 3 Dec 2018 09:48:29 +0000 (10:48 +0100)]
block: Fix PHPDoc comments to match function signature (or method)
- Add @param annotation for $row to newFromRow() method in Restriction
interface declaration.
- Remove @param annotation for $option not used in loadByBlockId() method
signature.
Change-Id: Iec49b9541ea06da9f497e45bd35df26f8124aecf
jenkins-bot [Mon, 3 Dec 2018 05:10:26 +0000 (05:10 +0000)]
Merge "Delete always true condition"
James D. Forrester [Fri, 4 May 2018 18:39:47 +0000 (11:39 -0700)]
mediawiki.util: Drop jsMessage(), deprecated since 1.20 and mostly unused
This also means that mediawiki.notify is no longer loaded.
Bug: T193901
Change-Id: Ifa222ca05ec913c140284ee0113c0d7827215130
jenkins-bot [Mon, 3 Dec 2018 01:57:50 +0000 (01:57 +0000)]
Merge "Revert "Title::checkUserBlock should call User::isBlockedFrom for every action""
Legoktm [Mon, 3 Dec 2018 00:12:19 +0000 (00:12 +0000)]
Revert "Title::checkUserBlock should call User::isBlockedFrom for every action"
This reverts commit
b1e4ca70b8e375d52c35b46fb3157fb852948263.
Introduced a breaking change, and didn't follow the deprecation policy.
Bug: T210953
Change-Id: I11806165912d9188261d3c4c37dbae5cfd2865ec
Translation updater bot [Sun, 2 Dec 2018 20:53:50 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I6e2615bdd5a2aa9be73317d83770e61bc2b6b450
Jakub Vrana [Sun, 2 Dec 2018 18:28:11 +0000 (19:28 +0100)]
Delete always true condition
The typehint doesn't allow null here.
Found by PHPStan.
Change-Id: I3e30bf49e778c42e8313a5b6de3d943ed7002c81
Jakub Vrana [Sun, 2 Dec 2018 18:21:44 +0000 (19:21 +0100)]
Delete unused variable
Found by PHPStan.
Change-Id: I416069e4199e1cd3cf7a98a32cc1cb09c1525093
Jakub Vrana [Sun, 2 Dec 2018 18:14:36 +0000 (19:14 +0100)]
Delete always true condition
Found by PHPStan.
Change-Id: I3198b9ab568f469e32b3a511d8a0506fcc030fee
Jakub Vrana [Sun, 2 Dec 2018 18:06:53 +0000 (19:06 +0100)]
Delete always true condition
The typehint doesn't allow passing null here.
Found by PHPStan.
Change-Id: I978469c0df584968ab6d1b54c9ebff05c3222054
Jakub Vrana [Sun, 2 Dec 2018 08:59:17 +0000 (09:59 +0100)]
Delete always-true condition
Found by PHPStan.
Change-Id: Ibefd9d5d1b374448650a36702db18144f5feddae
jenkins-bot [Sun, 2 Dec 2018 01:50:14 +0000 (01:50 +0000)]
Merge "Use our fork of less.php"
jenkins-bot [Sun, 2 Dec 2018 01:28:26 +0000 (01:28 +0000)]
Merge "Add $wgReauthenticateTime to extension.json"
jenkins-bot [Sun, 2 Dec 2018 00:30:03 +0000 (00:30 +0000)]
Merge "SpecialRevisiondelete: Do not pass unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:25:43 +0000 (00:25 +0000)]
Merge "Do not pass unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:25:37 +0000 (00:25 +0000)]
Merge "Do not pass unused parameter"
Max Semenik [Tue, 16 Oct 2018 07:00:30 +0000 (00:00 -0700)]
Use our fork of less.php
Supports PHP 7.3, among other things
Bug: T206975
Depends-On: I06f1e43b0f12f9b56f9dff55a92b5ae4546acfcc
Change-Id: I84c5ed8ac0ae1c382ba035b37dc88ccd69494ac3
jenkins-bot [Sun, 2 Dec 2018 00:22:39 +0000 (00:22 +0000)]
Merge "Do not pass unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:22:34 +0000 (00:22 +0000)]
Merge "Do not pass unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:20:08 +0000 (00:20 +0000)]
Merge "RedisBagOStuff: Do not pass unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:18:23 +0000 (00:18 +0000)]
Merge "Remove duplicate keys from arrays"
jenkins-bot [Sun, 2 Dec 2018 00:18:18 +0000 (00:18 +0000)]
Merge "media: Do not pass unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:11:45 +0000 (00:11 +0000)]
Merge "Do not pass unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:11:40 +0000 (00:11 +0000)]
Merge "export: Do not pass unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:11:35 +0000 (00:11 +0000)]
Merge "rdbms: Pass required parameter"
Jakub Vrana [Sat, 1 Dec 2018 16:53:12 +0000 (17:53 +0100)]
SpecialRevisiondelete: Do not pass unused parameter
Found by PHPStan.
Change-Id: Iba7020f6bf793e525b4d82c286064d05609eef2f
jenkins-bot [Sun, 2 Dec 2018 00:00:53 +0000 (00:00 +0000)]
Merge "Remove unused use in anonymous function"
jenkins-bot [Sun, 2 Dec 2018 00:00:48 +0000 (00:00 +0000)]
Merge "Remove unused parameter"
jenkins-bot [Sun, 2 Dec 2018 00:00:43 +0000 (00:00 +0000)]
Merge "Use correct letter case"
jenkins-bot [Sun, 2 Dec 2018 00:00:38 +0000 (00:00 +0000)]
Merge "Remove unused use in anonymous function"
Jakub Vrana [Sat, 1 Dec 2018 16:55:25 +0000 (17:55 +0100)]
media: Do not pass unused parameter
Found by PHPStan.
Change-Id: Id9418a5aa95e8541824bbf1235307a3969e75fb8
jenkins-bot [Sun, 2 Dec 2018 00:00:32 +0000 (00:00 +0000)]
Merge "Change typehint callback to callable"
jenkins-bot [Sun, 2 Dec 2018 00:00:27 +0000 (00:00 +0000)]
Merge "Change typehint callback to callable"
Jakub Vrana [Sat, 1 Dec 2018 16:51:45 +0000 (17:51 +0100)]
RedisBagOStuff: Do not pass unused parameter
Found by PHPStan.
Change-Id: I20fe8ca713362d115d620a22e04c5dc984ae279e
Jakub Vrana [Sat, 1 Dec 2018 16:48:35 +0000 (17:48 +0100)]
media: Do not pass unused parameter
FileRepo::getHashPath() takes a $name parameter, but File::getHashPath()
doesn't.
Found by PHPStan.
Change-Id: I9cbcfd206249f4be7b50f2b104c797606bc4406a
Jakub Vrana [Sat, 1 Dec 2018 16:43:51 +0000 (17:43 +0100)]
export: Do not pass unused parameter
Found by PHPStan.
Change-Id: I0e4971a3d5a4170ada776cd88ea664806f23c6ed
Jakub Vrana [Sat, 1 Dec 2018 16:40:47 +0000 (17:40 +0100)]
rdbms: Pass required parameter
Found by PHPStan.
Change-Id: I8fbb64f7b5058b36381bccd5bc6a9d095b9ace15
jenkins-bot [Sat, 1 Dec 2018 23:45:23 +0000 (23:45 +0000)]
Merge "Remove unused use in anonymous function"
Fomafix [Mon, 26 Nov 2018 05:34:04 +0000 (06:34 +0100)]
InfoAction: Add missing @param type
null is explicit supported and in use.
Change-Id: I495ca2eacb5359c8bf88c094db39fa44ca5866e1
Umherirrender [Fri, 16 Nov 2018 23:30:28 +0000 (00:30 +0100)]
build: Updating mediawiki/mediawiki-codesniffer to 23.0.0
Avoid use of __METHOD__ magic constant in closure
Change-Id: I28d519530ca2fcde026a6cbb419848098d4617ca
Fomafix [Sun, 18 Nov 2018 17:33:45 +0000 (18:33 +0100)]
WebInstallerUpgrade: Simplify return paths
* Avoid else after return.
* Combine redundant return values.
Change-Id: If87f5b2163abc7867ce83081aa6ab9e358869060
Translation updater bot [Sat, 1 Dec 2018 20:53:32 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I849a483d1800b2b580f64d05f3f12453afbf7549
MarcoAurelio [Sat, 1 Dec 2018 15:18:07 +0000 (16:18 +0100)]
Fix typo 'defintion'
Bug: T201491
Change-Id: I2b6b87761e6e01b982feaccd98f08f66a1888a16
jenkins-bot [Sat, 1 Dec 2018 19:28:11 +0000 (19:28 +0000)]
Merge "Fix return typehint"
jenkins-bot [Sat, 1 Dec 2018 19:28:05 +0000 (19:28 +0000)]
Merge "Remove unused use in anonymous function"
jenkins-bot [Sat, 1 Dec 2018 18:49:27 +0000 (18:49 +0000)]
Merge "Use correct letter case"
Jakub Vrana [Sat, 1 Dec 2018 17:09:58 +0000 (18:09 +0100)]
Do not pass unused parameter
Found by PHPStan.
Change-Id: I4a73279b6956b9819e609536ae6774872f1736f4
Jakub Vrana [Sat, 1 Dec 2018 17:08:56 +0000 (18:08 +0100)]
Do not pass unused parameter
Found by PHPStan.
Change-Id: I6c33aa29af02b7a5ca01e2e20103e4a873cb722a
Jakub Vrana [Sat, 1 Dec 2018 17:08:04 +0000 (18:08 +0100)]
Do not pass unused parameter
Found by PHPStan.
Change-Id: I48a613d94624ef4f8c533b98b8c128b4cc9c47f5
Jakub Vrana [Sat, 1 Dec 2018 17:04:44 +0000 (18:04 +0100)]
Do not pass unused parameter
Found by PHPStan.
Change-Id: Icf9f1c87ff2690b7a16c99418cdb1dae9d97ce25
Jakub Vrana [Sat, 1 Dec 2018 17:01:10 +0000 (18:01 +0100)]
Do not pass unused parameter
Found by PHPStan.
Change-Id: I9bd5b9d134d0a551ea29ff995566a17583637caa
Jakub Vrana [Sat, 1 Dec 2018 16:46:07 +0000 (17:46 +0100)]
Do not pass unused parameter
Found by PHPStan.
Change-Id: I760e7382931ac00317319bee5223b0230b24bb7d
Jakub Vrana [Sat, 1 Dec 2018 16:33:21 +0000 (17:33 +0100)]
Remove unused parameter
Found by PHPStan.
Change-Id: I0480146fd7fce1d39db904f1c4b6dfa8314a74fe
jenkins-bot [Sat, 1 Dec 2018 15:47:22 +0000 (15:47 +0000)]
Merge "Changing "===" on secrets to hash_equals to protect from timing attacks."
Mogmog123 [Sat, 1 Dec 2018 01:25:06 +0000 (01:25 +0000)]
Changing "===" on secrets to hash_equals to protect from timing attacks.
Bug: T207777
Change-Id: I1e12ef94f455f96b4d70af27a315414500c709ab
jenkins-bot [Sat, 1 Dec 2018 10:50:18 +0000 (10:50 +0000)]
Merge "Message: Throw if given invalid serialized data"
jenkins-bot [Sat, 1 Dec 2018 10:49:38 +0000 (10:49 +0000)]
Merge "Message: Don't include Title objects in the serialization (part 1)"
Jakub Vrana [Sat, 1 Dec 2018 09:30:20 +0000 (10:30 +0100)]
Use correct letter case
Found by PHPStan.
Change-Id: I31619e0fb1819939b5b64ed01c6959668b86870c
Jakub Vrana [Sat, 1 Dec 2018 09:28:18 +0000 (10:28 +0100)]
Use correct letter case
Found by PHPStan.
Change-Id: Iaff53951e1e49b9bb99f7bf9da5a228765ead7f3
Jakub Vrana [Sat, 1 Dec 2018 09:17:34 +0000 (10:17 +0100)]
Remove unused use in anonymous function
Found by PHPStan.
Change-Id: I88247514703820a6afb7c9861dcf64326aa32d19
Jakub Vrana [Sat, 1 Dec 2018 09:16:46 +0000 (10:16 +0100)]
Remove unused use in anonymous function
Found by PHPStan.
Change-Id: I50d27a50806048697dcac8e24712a10a6c7e7c16
Jakub Vrana [Sat, 1 Dec 2018 09:13:38 +0000 (10:13 +0100)]
Remove unused use in anonymous function
Found by PHPStan.
Change-Id: Id2dd9996fd4d78da930ee0cc802bb07b66a5f084
Jakub Vrana [Sat, 1 Dec 2018 09:12:32 +0000 (10:12 +0100)]
Remove unused use in anonymous function
Found by PHPStan.
Change-Id: Ic00d2b7b42c7c75b673601eabe947b0f380a3399
Jakub Vrana [Sat, 1 Dec 2018 09:10:41 +0000 (10:10 +0100)]
Change typehint callback to callable
Found by PHPStan.
Change-Id: I09f21da69ad9b9357cee85a47717dbe1bca04070
Jakub Vrana [Sat, 1 Dec 2018 09:02:48 +0000 (10:02 +0100)]
Change typehint callback to callable
Found by PHPStan.
Change-Id: I77877a18131bd69996bad07f2ee1c5f3ba3ba2e7
Jakub Vrana [Sat, 1 Dec 2018 08:57:31 +0000 (09:57 +0100)]
Fix return typehint
Found by PHPStan.
Change-Id: Ia5280815f9dda25788de0438af1468adb8c915a6
Jakub Vrana [Sat, 1 Dec 2018 08:47:28 +0000 (09:47 +0100)]
Remove unused parameter
Found by PHPStan.
Change-Id: I8ed0561c18e2af4ee146123b534a864d5ab7f975
Translation updater bot [Fri, 30 Nov 2018 20:54:20 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia2a54ab49aa88e2450c66e91385ecfaac29312ef