Aaron Schulz [Tue, 18 Jun 2019 22:54:36 +0000 (23:54 +0100)]
rdbms: split out private LoadBalancer::getServerInfoStrict method
Change-Id: I9f77a07c75696f4a8353872375a7306d7734625a
Aaron Schulz [Wed, 19 Jun 2019 16:28:09 +0000 (17:28 +0100)]
rdbms: rename safeWaitForMasterPos() to waitForMasterPos() in ILoadBalancer
Change-Id: I2ad0c6f369ba992895a5306a57f1af16a772844c
SBassett [Sat, 22 Jun 2019 12:26:41 +0000 (12:26 +0000)]
Merge "Revert "Fix testsuites for LogFormatter""
SBassett [Sat, 22 Jun 2019 12:25:14 +0000 (12:25 +0000)]
Revert "Fix testsuites for LogFormatter"
This reverts commit
d0c2da82616a280f51feafa015dd67608c13e29b.
Reason for revert: Original patch set appeared to work then began failing multiple CI builds post-merge. Simply reverting for now due for T226293.
Big: T226293
Change-Id: I3e33300cecfe87926fcb8851689d67c3b1258b0f
Jforrester [Fri, 21 Jun 2019 22:11:42 +0000 (22:11 +0000)]
Merge "Remove support for calling OutputPage::wrapWikiMsg() with an options parameter"
rxy [Fri, 31 May 2019 20:04:09 +0000 (20:04 +0000)]
Fix testsuites for LogFormatter
Change-Id: I064f563cb54a50c3292b1f9e24b0bb467f69af9b
Reedy [Sat, 11 May 2019 15:25:26 +0000 (16:25 +0100)]
Remove support for calling OutputPage::wrapWikiMsg() with an options parameter
Bug: T220656
Change-Id: If9103eb702f3879172d6e860d974603b7b32d6f5
jenkins-bot [Fri, 21 Jun 2019 20:23:21 +0000 (20:23 +0000)]
Merge "rdbms: add replica server counting methods to ILoadBalancer"
jenkins-bot [Fri, 21 Jun 2019 16:12:05 +0000 (16:12 +0000)]
Merge "Deprecate Sanitizer::setupAttributeWhitelist/attributeWhitelist"
Reedy [Fri, 21 Jun 2019 08:26:36 +0000 (09:26 +0100)]
Fix excessive whitespace in BitmapMetadataHandlerTest.php
Change-Id: Ic801069c1a290626f863723409f156b071dec7f5
Follows-Up: I6705a8d46f53ef807edab10f8f0cb0eba6b560dc
jenkins-bot [Fri, 21 Jun 2019 06:07:33 +0000 (06:07 +0000)]
Merge "API: Update api-help-datatypes for Timestamp library changes"
jenkins-bot [Fri, 21 Jun 2019 06:06:56 +0000 (06:06 +0000)]
Merge "Update ObjectFactory and ConvertibleTimestamp"
jenkins-bot [Fri, 21 Jun 2019 01:26:15 +0000 (01:26 +0000)]
Merge "Some love to UserDupes"
jenkins-bot [Thu, 20 Jun 2019 22:53:01 +0000 (22:53 +0000)]
Merge "GlobalFunctions: Remove deprecated wfCountDown() function from core"
jenkins-bot [Thu, 20 Jun 2019 22:39:16 +0000 (22:39 +0000)]
Merge "Update documentation in DefaultSettings to reflect new Preprocessor default"
jenkins-bot [Thu, 20 Jun 2019 22:28:10 +0000 (22:28 +0000)]
Merge "resourceloader: Remove my `@author` comments from unit tests"
jenkins-bot [Thu, 20 Jun 2019 22:25:52 +0000 (22:25 +0000)]
Merge "resourceloader: Remove 'Series60' from Grade C regex"
Derick Alangi [Thu, 20 Jun 2019 21:49:04 +0000 (22:49 +0100)]
GlobalFunctions: Remove deprecated wfCountDown() function from core
The global function `wfCountDown()` was deprecated in 1.31 and a replacement
made available (\Maintenance::countdown()) in 1.31 as well. Currently, the few
usage in BSF have been cleaned up, hence can be removed.
Usage
=====
https://codesearch.wmflabs.org/search/?q=wfCountDown&i=nope&files=&repos=
Depends-On: Iae61d36899036ecdc0341feb3f1bcaa6b38dbf44
Depends-On: Id202148c6a6ceaadcefcf7a4ab8360edd9fe3b0b
Bug: T220656
Change-Id: Ic7460f1d35cb6f2eb8bf60694cdd4c55b2e001c0
jenkins-bot [Thu, 20 Jun 2019 21:41:45 +0000 (21:41 +0000)]
Merge "Filter out duplicate autoblocks when checking for blocks"
Thalia [Thu, 20 Jun 2019 10:29:01 +0000 (11:29 +0100)]
Filter out duplicate autoblocks when checking for blocks
Follow-up to I7654907.
Bug: T225919
Change-Id: I67e72d6c88e3cbfd9515a016b2782d1d9b123775
C. Scott Ananian [Wed, 19 Jun 2019 19:00:09 +0000 (15:00 -0400)]
Remove global function wfBCP47, deprecated in 1.31
Change-Id: I8b9956bec18cc7bbc9aafeec124e6c1fef262dc6
jenkins-bot [Thu, 20 Jun 2019 20:38:38 +0000 (20:38 +0000)]
Merge "languages: Use "your" instead of "my" in the updatedmarker value"
jenkins-bot [Thu, 20 Jun 2019 19:53:20 +0000 (19:53 +0000)]
Merge "config: ServiceOptions O(1) assert time in the common case"
Tim Starling [Thu, 20 Jun 2019 16:45:19 +0000 (11:45 -0500)]
config: ServiceOptions O(1) assert time in the common case
Check if the key array passed in the constructor is identical to the key
array passed to assertRequiredOptions(). This takes O(1) time if the key
arrays have the same underlying storage pointer, which is the common
case.
If the arrays have a different order but are otherwise identical, the
slow path is taken instead. The comparison will add O(N) overhead in
addition to the overhead of the array_diff() calls.
Change-Id: Icb9040ab66286b72a270e84f910cb578bed105b0
jenkins-bot [Thu, 20 Jun 2019 19:18:41 +0000 (19:18 +0000)]
Merge "Remove OutputPage::enableSectionEditLinks(), ParserOptions::get/setEditSection()"
C. Scott Ananian [Tue, 23 Apr 2019 17:09:36 +0000 (13:09 -0400)]
Deprecate Sanitizer::setupAttributeWhitelist/attributeWhitelist
These methods should be made private in the next release, but
hard-deprecate them for 1.34.
Tweak the return value of the attribute whitelist to be an
associative rather than a sequential array, which makes the
lookup of allowed attributes more efficient and avoids an
array_flip for every html element sanitized.
Bug: T221677
Change-Id: I17d734937accec6c2679dbe17328cf9554bd556a
jenkins-bot [Thu, 20 Jun 2019 18:02:25 +0000 (18:02 +0000)]
Merge "Parser: Remove deprecated method Parser::fetchFile()"
jenkins-bot [Thu, 20 Jun 2019 17:58:54 +0000 (17:58 +0000)]
Merge "installer: Remove deprecated method WebInstallerOutput::addWikiText()"
Brad Jorsch [Thu, 20 Jun 2019 16:55:34 +0000 (12:55 -0400)]
API: Update api-help-datatypes for Timestamp library changes
Instead of reproducing the documentation that's now at
https://www.mediawiki.org/wiki/Timestamp, let's just link to it.
Bug: T224730
Change-Id: I26c3bafc7cc9145b573c3ef84877633733be3cb1
Timo Tijhof [Thu, 20 Jun 2019 17:38:57 +0000 (18:38 +0100)]
resourceloader: Remove 'Series60' from Grade C regex
This existed to match UAs from the now-discontinued SymbianOS browser,
however, we already have 'SymbianOS' in the regex and all known
UA variants (which we have tests for) contain that phrase as well.
Change-Id: I643eb1e1df6a09873cda7d6fe2f325cd722b3ee5
Derick Alangi [Wed, 5 Jun 2019 16:38:39 +0000 (17:38 +0100)]
Parser: Remove deprecated method Parser::fetchFile()
Deprecated in 1.32 and no longer used, see usage below;
Usage
=====
https://codesearch.wmflabs.org/search/?q=%5CbfetchFile%5C(%20(.*%3F)%2C%20(.*%3F)%20%5C)&i=nope&files=&repos=
Change-Id: Id0f76ee5c0e2a230dabb563c9d9e5c0a584f6b2c
Derick Alangi [Wed, 5 Jun 2019 16:26:59 +0000 (17:26 +0100)]
installer: Remove deprecated method WebInstallerOutput::addWikiText()
Was deprecated in 1.32 and no longer used, hence removing from MW core.
Change-Id: I93c5dc1d74fd856c07b09e4c3028e223d2939522
Reedy [Tue, 18 Jun 2019 19:41:38 +0000 (20:41 +0100)]
Some love to UserDupes
Change-Id: I9c0310c928a518e6f0ed13998603544fe441358e
Gergő Tisza [Wed, 19 Jun 2019 17:58:20 +0000 (19:58 +0200)]
Update ObjectFactory and ConvertibleTimestamp
* wikimedia/object-factory -> 2.0.0
* wikimedia/timestamp -> 3.0.0
* wikimedia/xmp-reader -> 0.6.3
Needed for I5c0cc3a8. mediawiki/vendor equivalent is Iea05dc43.
Bug: T224729
Bug: T144482
Depends-On: Iea05dc439688871c574c639e617765ae88a75ff7
Change-Id: I6705a8d46f53ef807edab10f8f0cb0eba6b560dc
jenkins-bot [Thu, 20 Jun 2019 16:54:31 +0000 (16:54 +0000)]
Merge "Type hint against IResultWrapper in maintenance classes"
jenkins-bot [Thu, 20 Jun 2019 16:54:25 +0000 (16:54 +0000)]
Merge "Type hint against IResultWrapper in api classes"
jenkins-bot [Thu, 20 Jun 2019 16:26:37 +0000 (16:26 +0000)]
Merge "Remove $wgUseKeyHeader and OutputPage::getKeyHeader(), deprecated in 1.32"
jenkins-bot [Thu, 20 Jun 2019 16:24:00 +0000 (16:24 +0000)]
Merge "Remove OutputPage::addWikitext()* functions, hard-deprecated in 1.32"
jenkins-bot [Thu, 20 Jun 2019 16:21:48 +0000 (16:21 +0000)]
Merge "Update monolog/monolog from 1.22.1 -> 1.24.0"
Reedy [Thu, 20 Jun 2019 14:33:00 +0000 (15:33 +0100)]
Add some @since tags to ParserOutput::SUPPORTS_ constants
Change-Id: I2f6588fe563ed5c1dc5ef2a70e2ed59fdca99018
Aaron Schulz [Tue, 18 Jun 2019 21:12:06 +0000 (22:12 +0100)]
rdbms: add replica server counting methods to ILoadBalancer
This is slightly more robust and makes the intent much clearer
than random calling code checking getServerCount() all over the
place. In addition, this yields better separation of concern.
Also, cleanup the LoadBalancer constructer a bit and make the
validation a bit stricter.
Make some server index comparisons strict while at it.
Change-Id: Icc1a35bd65c6862ff81faa3ab9b2aa7cafe29443
jenkins-bot [Thu, 20 Jun 2019 11:22:07 +0000 (11:22 +0000)]
Merge "resourceloader: Document which FileModule methods use a DB"
jenkins-bot [Thu, 20 Jun 2019 11:02:36 +0000 (11:02 +0000)]
Merge "Fix wfLocalFile() replacement"
jenkins-bot [Thu, 20 Jun 2019 10:50:10 +0000 (10:50 +0000)]
Merge "resourceloader: Switch Xml::encodeJsCall call in getDeprecationInformation"
Lucas Werkmeister [Thu, 20 Jun 2019 10:01:03 +0000 (12:01 +0200)]
Fix wfLocalFile() replacement
This bit of ImageListPager used to call wfLocalFile(), but was
accidentally replaced with the replacement for wfFindFile() instead.
Bug: T226102
Change-Id: Id50a5359fe2353ae88012d1f5a3331f570b73922
Kosta Harlan [Thu, 20 Jun 2019 01:43:47 +0000 (21:43 -0400)]
Disable flaky Selenium test
Change-Id: Ia3f2403e452f4476238b349c9d6a6f8135267456
Follows-Up: Iaf7e095b3bb34072eea6bcac76ba29358b14cc09
Bug: T226144
Timo Tijhof [Thu, 20 Jun 2019 00:24:50 +0000 (01:24 +0100)]
resourceloader: Remove my `@author` comments from unit tests
Previously removed from includes/ already.
Also remove odd `@package`, which we never use.
And remove `@since` which doesn't make sense for test-only files.
Change-Id: Ib7265d39329ecadd5279b11820f77f54189b55d2
jenkins-bot [Thu, 20 Jun 2019 00:00:55 +0000 (00:00 +0000)]
Merge "AutoLoader: Skip tokenizing of irrelevant lines in ClassCollector"
Timo Tijhof [Wed, 19 Jun 2019 22:44:39 +0000 (23:44 +0100)]
resourceloader: Document which FileModule methods use a DB
Also, for the unit test, disable the two methods we use there
that can get called. The unintended side-effects of these two
methods was the only reason it used `@group Database`.
Removing that makes the test a bit faster as well.
Enforce this via MediaWikiServices for this suite to avoid an
untracked dependency slipping back in in the future.
Bug: T225730
Change-Id: I6c54466e9517d9899bc39f8f9bb946369c0a526d
Translation updater bot [Wed, 19 Jun 2019 21:35:03 +0000 (23:35 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I4b61ff429f73f4d8252206f6613551d20b5b230f
jenkins-bot [Wed, 19 Jun 2019 20:47:01 +0000 (20:47 +0000)]
Merge "Remove deprecated ApiAction logging code from ApiMain.php"
Umherirrender [Wed, 19 Jun 2019 19:43:51 +0000 (21:43 +0200)]
Type hint against IResultWrapper in api classes
Change-Id: If3870e6b8d343dd12390f5155d97edbbe080ac77
Umherirrender [Wed, 19 Jun 2019 19:42:32 +0000 (21:42 +0200)]
Type hint against IResultWrapper in maintenance classes
Change-Id: I6a58e9cfe645056a854c80b2db1e71fb59bd226b
jenkins-bot [Wed, 19 Jun 2019 19:32:17 +0000 (19:32 +0000)]
Merge "Reduce selector specificity"
C. Scott Ananian [Wed, 19 Jun 2019 18:49:22 +0000 (14:49 -0400)]
Remove OutputPage::enableSectionEditLinks(), ParserOptions::get/setEditSection()
These methods were deprecated in 1.31, and most of the related code
was removed in
b4e557f8f8a72d4539e0cf5f83add4eef8df418b but these three
methods appear to have been overlooked.
Change-Id: Iea6c8b1b628a7b6acf9b65497966af9fc4ab662e
C. Scott Ananian [Wed, 19 Jun 2019 18:22:42 +0000 (14:22 -0400)]
Remove $wgUseKeyHeader and OutputPage::getKeyHeader(), deprecated in 1.32
These implemented a since-abandoned draft IETF spec, and the code was
broken due to (1) case-(in)sensitivity issues with the Accept-Language
header and (2) the BCP47 language code compatibility workaround we use.
Change-Id: Ia53d07cd8ce8ab1497294ea244c13c7499f632c7
C. Scott Ananian [Wed, 19 Jun 2019 15:57:36 +0000 (11:57 -0400)]
Remove OutputPage::addWikitext()* functions, hard-deprecated in 1.32
This starts cleaning up the programmer-visible API for OutputPage
and removed some deprecated untidy parser modes.
Change-Id: Ib464b57248f114b68424ec1175d36ad86d1319ad
Matěj Suchánek [Wed, 19 Jun 2019 17:27:56 +0000 (19:27 +0200)]
Style change tags correctly on Special:Newpages
Bug: T212613
Change-Id: I6905273bf9bb3d93480df201a2935d8b0e831805
Aaron Schulz [Wed, 19 Jun 2019 16:05:16 +0000 (17:05 +0100)]
rdbms: deprecate unused ILoadBalancer::safeGetLag method
Change-Id: Ib3bc2862548271613da30ad1be836d28a82e6cc9
Timo Tijhof [Tue, 18 Jun 2019 17:26:06 +0000 (18:26 +0100)]
AutoLoader: Skip tokenizing of irrelevant lines in ClassCollector
This makes AutoLoaderStructureTest in PHPUnit and the
generateLocalAutoload.php maintenance script much faster.
On my machine, it made it 35X faster (or time spent reduced by 97%).
Bug: T225730
Change-Id: Ife959bd17ce9c2ae952dfbd158ddb3d8475e8cb2
Timo Tijhof [Wed, 19 Jun 2019 14:38:32 +0000 (15:38 +0100)]
resourceloader: Switch Xml::encodeJsCall call in getDeprecationInformation
Also rename one of the test classes to have a more descriptive name.
Bug: T32956
Change-Id: I1a970c198300b7ef0d99c15609f1fb7fa8783b98
jenkins-bot [Wed, 19 Jun 2019 14:10:33 +0000 (14:10 +0000)]
Merge "resourceloader: Define the default language and skin in constants"
Andrew Otto [Wed, 19 Jun 2019 14:05:50 +0000 (10:05 -0400)]
Remove deprecated ApiAction logging code from ApiMain.php
ApiAction was disabled in WMF production in
https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/516303
Bug: T222267
Change-Id: I527811ef84506cf35fe7b9b981fb405776fceb1a
Fomafix [Sun, 16 Jun 2019 20:30:15 +0000 (22:30 +0200)]
resourceloader: Define the default language and skin in constants
This allows to use the default values at several places.
Change-Id: I53f29c2162c4cac9caf672e816ebfeb97c452389
jenkins-bot [Wed, 19 Jun 2019 13:27:07 +0000 (13:27 +0000)]
Merge "rdbms: mention wait time in LoadBalancer::safeWaitForMasterPos() error logging"
jenkins-bot [Wed, 19 Jun 2019 13:27:01 +0000 (13:27 +0000)]
Merge "rdbms: merge openConnection into getConnection in LoadBalancer"
jenkins-bot [Wed, 19 Jun 2019 12:40:12 +0000 (12:40 +0000)]
Merge "resourceloader: Migrate use of 'raw' modules to 'raw' requests"
jenkins-bot [Wed, 19 Jun 2019 12:26:04 +0000 (12:26 +0000)]
Merge "resourceloader: Remove redundant 'group' setting for StartupModule"
jenkins-bot [Wed, 19 Jun 2019 11:20:31 +0000 (11:20 +0000)]
Merge "resourceloader: Ignore coverage for getBaseModulesInternal() wrapper"
Aaron Schulz [Mon, 17 Jun 2019 18:16:12 +0000 (19:16 +0100)]
rdbms: merge openConnection into getConnection in LoadBalancer
Add error suppression feature to getConnection() itself so that
callers can easily be migrated to it. Deprecate openConnection(),
which is poorly named and had a poor division of responsibility
with getConnection().
Split out some new private methods for readability:
* sanitizeConnectionFlags(), which warns about and strips unusable flags
* enforceConnectionFlags(), which handles some DBO_TRX sanity logic
* lazyLoadReplicationPositions(), which handles the chronology callback
Make sure "waitForPos" is loaded before pickReaderIndex() so that the
optimization of being extra picky about replication lag (in seconds)
actually applies.
Change-Id: I225ed6e6edf39cdf237f2322ea59f35d30f2e01a
jenkins-bot [Wed, 19 Jun 2019 06:56:00 +0000 (06:56 +0000)]
Merge "phan: Add internal stubs for imagick, pcntl, redis & sockets"
C. Scott Ananian [Wed, 19 Jun 2019 05:58:37 +0000 (01:58 -0400)]
Update documentation in DefaultSettings to reflect new Preprocessor default
This is a follow-up to Ica5d1ad5b1e677542962fc36d582a793f941155e and
updates a bit of documentation missed in the original patch.
Change-Id: Iaf2b07be4b6946782780a846f026c071edaaf567
Aaron Schulz [Wed, 19 Jun 2019 02:19:53 +0000 (03:19 +0100)]
rdbms: mention wait time in LoadBalancer::safeWaitForMasterPos() error logging
Change-Id: I134e58949bab25e73874ea29d1b306e4fffa6ef9
jenkins-bot [Wed, 19 Jun 2019 02:14:15 +0000 (02:14 +0000)]
Merge "language: Move some language-related classes to includes/language/"
jenkins-bot [Wed, 19 Jun 2019 02:11:22 +0000 (02:11 +0000)]
Merge "Various cleanups to MediaWiki::preOutputCommit"
jenkins-bot [Wed, 19 Jun 2019 01:35:47 +0000 (01:35 +0000)]
Merge "Use UUIDv4 for mediawiki.api-request log event ID."
jenkins-bot [Wed, 19 Jun 2019 01:25:09 +0000 (01:25 +0000)]
Merge "Fix return type of UploadStash::listFiles"
Petr Pchelko [Wed, 15 May 2019 05:06:09 +0000 (07:06 +0200)]
Use UUIDv4 for mediawiki.api-request log event ID.
Bug: T222966
Change-Id: Ie753229ed15545a62349154d442ae9e297951455
jenkins-bot [Tue, 18 Jun 2019 23:40:01 +0000 (23:40 +0000)]
Merge "Use IDatabase as return type for BotPassword::getDB"
jenkins-bot [Tue, 18 Jun 2019 22:59:07 +0000 (22:59 +0000)]
Merge "resourceloader: Skip modules with circular deps in tree optimiser"
Timo Tijhof [Thu, 13 Jun 2019 21:02:36 +0000 (22:02 +0100)]
language: Move some language-related classes to includes/language/
Bug: T225756
Change-Id: Ica351483d83a3a912d58ebb194b30828541fbcf3
jenkins-bot [Tue, 18 Jun 2019 20:34:15 +0000 (20:34 +0000)]
Merge "rdbms: Fix return type of DatabaseMysqlBase::mysqlFetchArray"
jenkins-bot [Tue, 18 Jun 2019 20:33:42 +0000 (20:33 +0000)]
Merge "resourceloader: Fix return type in ResourceLoader-related classes"
Timo Tijhof [Thu, 13 Jun 2019 18:28:38 +0000 (19:28 +0100)]
resourceloader: Ignore coverage for getBaseModulesInternal() wrapper
The getBaseModules() method is covered already.
Change-Id: I92d9063b72cee9e3be7329927bf5b97028399c14
Umherirrender [Tue, 18 Jun 2019 20:18:49 +0000 (22:18 +0200)]
rdbms: Fix return type of DatabaseMysqlBase::mysqlFetchArray
Change-Id: I7797ae79e8b4c1a88a4f1da342ef4a4f5a78ed74
Umherirrender [Tue, 18 Jun 2019 20:17:41 +0000 (22:17 +0200)]
resourceloader: Fix return type in ResourceLoader-related classes
Change-Id: I543e321129cf8fadc1159017b622528f462ea116
Umherirrender [Tue, 18 Jun 2019 19:40:09 +0000 (21:40 +0200)]
Use IDatabase as return type for BotPassword::getDB
There is no guarantee that this is a maintenance able connection,
but drop, create or alter is also not needed in this case
Change-Id: I7dd294b3d28ef8c4e416e826f38ed39f824b2f8f
jenkins-bot [Tue, 18 Jun 2019 19:38:45 +0000 (19:38 +0000)]
Merge "Return null from overwritten FormlessAction::onView"
jenkins-bot [Tue, 18 Jun 2019 19:38:39 +0000 (19:38 +0000)]
Merge "Update type of PermissionManager::resultToError"
jenkins-bot [Tue, 18 Jun 2019 19:38:33 +0000 (19:38 +0000)]
Merge "Fix return type of GenerateSitemap::getPageRes"
jenkins-bot [Tue, 18 Jun 2019 19:35:14 +0000 (19:35 +0000)]
Merge "Fix return type of CeeFormatter::format"
Kunal Mehta [Tue, 18 Jun 2019 19:19:37 +0000 (15:19 -0400)]
phan: Add internal stubs for imagick, pcntl, redis & sockets
Phan will automatically use these stubs if the extensions are not installed.
Also added a brief README for how to generate the stubs in the first place.
Bug: T224893
Change-Id: I1d31d03801fbc7b18dfc758453c95439acd96d19
Umherirrender [Tue, 18 Jun 2019 19:13:10 +0000 (21:13 +0200)]
Fix return type of CeeFormatter::format
FormatterInterface defines the return type as mixed
Change-Id: I41735b9fe887f9436cf6294a46eb5419c8da251f
Umherirrender [Tue, 18 Jun 2019 19:10:39 +0000 (21:10 +0200)]
Return null from overwritten FormlessAction::onView
The abstract class is documented to use null for doing nothing, not void
Change-Id: I99f0747117f83f4f2ae554c759a8e1737e7dc8f7
Umherirrender [Tue, 18 Jun 2019 18:33:53 +0000 (20:33 +0200)]
Fix return type of UploadStash::listFiles
SpecialUploadStash is using the return and already checking for truthy
Change-Id: Ie26f327d5ec9d67c39cf757591d2a779aecda86f
jenkins-bot [Tue, 18 Jun 2019 18:32:40 +0000 (18:32 +0000)]
Merge "ApiCSPReport: Support origin/path matching for false positives"
Umherirrender [Tue, 18 Jun 2019 18:28:37 +0000 (20:28 +0200)]
Fix return type of GenerateSitemap::getPageRes
Change-Id: I68729366f294b93aab5d2c76581c0847c11076d7
jenkins-bot [Tue, 18 Jun 2019 18:19:52 +0000 (18:19 +0000)]
Merge "ApiCSPReport: Log user ID instead of name, and limit urls to origin"
jenkins-bot [Tue, 18 Jun 2019 16:00:41 +0000 (16:00 +0000)]
Merge "WebInstaller: Add ARIA `role="main"` to overall div"
jenkins-bot [Tue, 18 Jun 2019 15:48:54 +0000 (15:48 +0000)]
Merge "Introduce separate unit tests PHPUnit configuration"