From: Thiemo Kreuz <thiemo.kreuz@wikimedia.de>
Date: Fri, 11 Jan 2019 18:25:26 +0000 (+0100)
Subject: export: Mark DumpFilter::mark() as being protected
X-Git-Tag: 1.34.0-rc.0~3093
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin//%22%24encUrl/%22?a=commitdiff_plain;h=ed96e6f1a7dadc716dce05ed6f81291d9d325972;p=lhc%2Fweb%2Fwiklou.git

export: Mark DumpFilter::mark() as being protected

I used
https://codesearch.wmflabs.org/search/?q=-%3Epass%5C(
to make sure there really is no other call to this. This function really
is meant to be protected.

I also used
https://codesearch.wmflabs.org/search/?q=function%20pass%5C(&files=php
to make sure I got all subclasses.

Required for I7da632c43681438aa886bdb709379f10cd9cc658.

Change-Id: I9aaf95c66a6efa22131de627ce015587a109858b
---

diff --git a/includes/export/DumpFilter.php b/includes/export/DumpFilter.php
index 088c7b19cb..75e149cea3 100644
--- a/includes/export/DumpFilter.php
+++ b/includes/export/DumpFilter.php
@@ -128,7 +128,7 @@ class DumpFilter {
 	 * @param object $page
 	 * @return bool
 	 */
-	function pass( $page ) {
+	protected function pass( $page ) {
 		return true;
 	}
 }
diff --git a/includes/export/DumpNamespaceFilter.php b/includes/export/DumpNamespaceFilter.php
index 12b9b55eab..0b8afa216f 100644
--- a/includes/export/DumpNamespaceFilter.php
+++ b/includes/export/DumpNamespaceFilter.php
@@ -84,7 +84,7 @@ class DumpNamespaceFilter extends DumpFilter {
 	 * @param object $page
 	 * @return bool
 	 */
-	function pass( $page ) {
+	protected function pass( $page ) {
 		$match = isset( $this->namespaces[$page->page_namespace] );
 		return $this->invert xor $match;
 	}
diff --git a/includes/export/DumpNotalkFilter.php b/includes/export/DumpNotalkFilter.php
index d99b1b1da7..c201c76b2f 100644
--- a/includes/export/DumpNotalkFilter.php
+++ b/includes/export/DumpNotalkFilter.php
@@ -31,7 +31,7 @@ class DumpNotalkFilter extends DumpFilter {
 	 * @param object $page
 	 * @return bool
 	 */
-	function pass( $page ) {
+	protected function pass( $page ) {
 		return !MWNamespace::isTalk( $page->page_namespace );
 	}
 }