jenkins-bot [Fri, 6 Apr 2018 23:53:13 +0000 (23:53 +0000)]
Merge "Fix param doc of Skin::makeSpecialUrlSubpage"
jenkins-bot [Fri, 6 Apr 2018 23:07:29 +0000 (23:07 +0000)]
Merge "Remove "probably you" from password reset email information"
jenkins-bot [Fri, 6 Apr 2018 23:04:48 +0000 (23:04 +0000)]
Merge "Provide PHPUnit 4 and 6 compatibility layer"
jenkins-bot [Fri, 6 Apr 2018 23:00:51 +0000 (23:00 +0000)]
Merge "Don't rely on magic __call in MWNamespaceTest"
jenkins-bot [Fri, 6 Apr 2018 22:12:03 +0000 (22:12 +0000)]
Merge "Fix --memory-limit option to maintenance scripts"
Kunal Mehta [Fri, 2 Mar 2018 10:42:16 +0000 (02:42 -0800)]
Provide PHPUnit 4 and 6 compatibility layer
PHPUnit 6 removed some functions that were heavily used in version 4. To
be able to support both versions for a short time, we'll use a trait to
fill in the missing methods until we drop PHPUnit 4 support.
This trait is included in MediaWikiTestCase so most tests will be able
to benefit from it by default. Otherwise, anything that calls
setExpectedException() or getMock() will need to use it.
Change-Id: I707129e471e960e034e2aa994a467b9dc0239b69
Kunal Mehta [Fri, 6 Apr 2018 21:17:22 +0000 (14:17 -0700)]
Don't rely on magic __call in MWNamespaceTest
Change-Id: I32a7e7a55bc733f19d7c5ed1fbc6cfde748d4812
Translation updater bot [Fri, 6 Apr 2018 19:53:35 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: If0f967280101e28c85fbd85f290cc0ad219b94f7
Umherirrender [Fri, 6 Apr 2018 18:55:34 +0000 (20:55 +0200)]
Fix param doc of Skin::makeSpecialUrlSubpage
The $urlaction is passed to Title::getLocalURL which allows also
string[]
Change-Id: I9594f37b704403ffa96f490b079c4008153e9fb8
jenkins-bot [Fri, 6 Apr 2018 18:25:38 +0000 (18:25 +0000)]
Merge "maintenance: Fix autopatrols typo in deleteAutoPatrolLogs"
Timo Tijhof [Fri, 6 Apr 2018 17:38:14 +0000 (18:38 +0100)]
maintenance: Fix autopatrols typo in deleteAutoPatrolLogs
Follows-up
e1a23c9aad.
Change-Id: I43c00b2ac884a80f779be9eead50ad3de6d13fc6
jenkins-bot [Fri, 6 Apr 2018 16:46:28 +0000 (16:46 +0000)]
Merge "rdbms: move assertOpen() call near the top of Database::query"
jenkins-bot [Fri, 6 Apr 2018 16:41:47 +0000 (16:41 +0000)]
Merge "Add missing "use" clause to DumpTestCase"
jenkins-bot [Fri, 6 Apr 2018 14:02:11 +0000 (14:02 +0000)]
Merge "Revert "Default installations to using RemexHtml for tidying""
Addshore [Fri, 6 Apr 2018 10:47:47 +0000 (10:47 +0000)]
Revert "Default installations to using RemexHtml for tidying"
This reverts commit
efcef34d3da74613b01a320873bc59e134748183.
This is causing failures in CI for extensions
Depends-On: If9789a61d52f60882fc2f0226757c9d93e1c6362
Change-Id: I17cf305a951b2bf1f03285b12c3e131abcffd31d
jenkins-bot [Fri, 6 Apr 2018 04:50:18 +0000 (04:50 +0000)]
Merge "Default installations to using RemexHtml for tidying"
jenkins-bot [Fri, 6 Apr 2018 00:35:43 +0000 (00:35 +0000)]
Merge "tests: Reset Postgres sequences when cloning and truncating"
jenkins-bot [Fri, 6 Apr 2018 00:05:57 +0000 (00:05 +0000)]
Merge "rdbms: Allow PostgreSQL schema-check functions to find temporary tables"
Brad Jorsch [Sun, 18 Mar 2018 17:23:58 +0000 (13:23 -0400)]
tests: Reset Postgres sequences when cloning and truncating
This improves the repeatability of the unit tests by making the ID
values generated depend less on what previous tests might have done.
It also prevents tests from using up sequence numbers for the live DB's
tables.
Change-Id: Iaa8ae1e5cef4b9099bd1b4b8fc806f5af372a7ff
jenkins-bot [Thu, 5 Apr 2018 22:55:30 +0000 (22:55 +0000)]
Merge "Add DeleteUnknownPreferences hook"
Brad Jorsch [Sun, 18 Mar 2018 03:13:43 +0000 (23:13 -0400)]
rdbms: Allow PostgreSQL schema-check functions to find temporary tables
PostgreSQL puts temporary tables and such in a hidden, per-connection
"schema" that's checked for unqualified table accesses before the normal
search_path. We should check that in all the schema-checking functions.
Change-Id: I1194ac31f31133b177f624138afee19d00e454b9
Brad Jorsch [Thu, 5 Apr 2018 16:13:08 +0000 (12:13 -0400)]
rdbms: Add a deprecationLogger callback
Much like the existing errorLogger, but for logging deprecation
warnings.
The default in the RDBMS layer is to call trigger_error() with
E_USER_DEPRECATED. The default in MediaWiki (via MWLBFactory) is to log
to the 'deprecated' log group, much like wfDeprecated() does, although
unfortunately we can't effectively use that directly since we have no
idea of a proper $callerOffset to pass.
Change-Id: Id13625e249516e84d72b6310953bb338a90976da
jenkins-bot [Thu, 5 Apr 2018 21:33:26 +0000 (21:33 +0000)]
Merge "rdbms: Remove support for PostgreSQL < 9.2, and improve INSERT IGNORE for 9.5"
jenkins-bot [Thu, 5 Apr 2018 20:59:10 +0000 (20:59 +0000)]
Merge "rdbms: Roll back empty implicit transaction on error"
Brad Jorsch [Sun, 18 Mar 2018 00:29:31 +0000 (20:29 -0400)]
rdbms: Remove support for PostgreSQL < 9.2, and improve INSERT IGNORE for 9.5
MediaWiki doesn't support PostgreSQL < 9.2, so drop the support for
older versions.
At the same time, since we're messing with the DatabasePostgres::insert()
code anyway, let's start using ON CONFLICT DO NOTHING for PG >= 9.5.
And since we're doing that, let's do the same for
DatabasePostgres::nativeInsertSelect().
Change-Id: I7bf13c3272917ebafeaff11eb116714a099afdf3
Aaron Schulz [Thu, 5 Apr 2018 20:49:55 +0000 (13:49 -0700)]
rdbms: move assertOpen() call near the top of Database::query
This should be done before bothering with begin() calls or setting
the value of fields like "trxDoneWrites" or "lastWriteTime".
Change-Id: Ieace2870f5496fcf230c5c8381baca4b8038db1d
Translation updater bot [Thu, 5 Apr 2018 20:02:00 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id32906c9e0becbdec14faf77335f79ab4cd06b84
Brad Jorsch [Thu, 5 Apr 2018 18:16:03 +0000 (14:16 -0400)]
rdbms: Roll back empty implicit transaction on error
If we're not going to set trxStatus to an error state in this case, we
need to issue a rollback to be sure the database (i.e. PostgreSQL) isn't
still in an error state too.
Bug: T189999
Change-Id: Id6e203b216fff937b6a97d779b36c278e3366409
jenkins-bot [Thu, 5 Apr 2018 18:10:06 +0000 (18:10 +0000)]
Merge "Fix SamplingStatsdClient for PHP 7.1+"
James D. Forrester [Wed, 4 Apr 2018 17:18:56 +0000 (10:18 -0700)]
Default installations to using RemexHtml for tidying
This combines two changes – defaulting tidying to on, previously off, and
defaulting the tidying library to RemexHtml, previously the tidy binary.
Config options are going to be a bit of a mess until we drop support for
the old tidy binary config route.
Bug: T185753
Depends-On: I0a8973f508fbf65160177b003260831639828eea
Change-Id: I6879a77a78d780c7c056d807dde20682c6097d1a
jenkins-bot [Thu, 5 Apr 2018 15:51:49 +0000 (15:51 +0000)]
Merge "mw.special.apisandbox: Use a real button to insert values in multi fields"
jenkins-bot [Thu, 5 Apr 2018 15:29:20 +0000 (15:29 +0000)]
Merge "rdbms: make Database query error handling more strict"
Bartosz Dziewoński [Thu, 9 Mar 2017 16:06:08 +0000 (17:06 +0100)]
mw.special.apisandbox: Use a real button to insert values in multi fields
Stuffing an indicator inside a normal widget is weird.
Also, always add it, even when we also handle Enter presses on the input.
Change-Id: I7191b4f31bfe4b42a524c786994150f318fd8cd9
jenkins-bot [Thu, 5 Apr 2018 14:06:28 +0000 (14:06 +0000)]
Merge "Swap isset by null check in ApiSetNotificationTimestamp/ApiPurge"
jenkins-bot [Thu, 5 Apr 2018 13:45:48 +0000 (13:45 +0000)]
Merge "Change default of $wgLogAutopatrol from true to false"
jenkins-bot [Thu, 5 Apr 2018 12:09:43 +0000 (12:09 +0000)]
Merge "SizeFilterWidget: Reduce width"
kaldari [Tue, 9 Jan 2018 08:15:14 +0000 (00:15 -0800)]
Change default of $wgLogAutopatrol from true to false
"$wgLogAutopatrol = true" basically just spams the logging table
and isn't useful in most cases (or ever?)
Bug: T184485
Change-Id: I418cc2fcc7017e5d2cbc0c6159b4c459b9c77ac7
Umherirrender [Thu, 5 Apr 2018 10:39:24 +0000 (12:39 +0200)]
Swap isset by null check in ApiSetNotificationTimestamp/ApiPurge
Change-Id: I1ebcbacf476a716d23b183dcbf379555ee1519dd
Gergő Tisza [Thu, 5 Apr 2018 09:48:07 +0000 (11:48 +0200)]
Fix SamplingStatsdClient for PHP 7.1+
Bug: T182380
Change-Id: I74a8aef1230c56d0c6a7856f8397e657fc6d1c40
addshore [Fri, 23 Mar 2018 11:33:10 +0000 (11:33 +0000)]
Api requests can throw a ApiUsageException, and that should be expected
Change-Id: I4aa6e7511747c0d811e2e617b88e681a6eda875d
Aaron Schulz [Thu, 5 Apr 2018 04:46:55 +0000 (21:46 -0700)]
Add missing "use" clause to DumpTestCase
Change-Id: I0420e95003509634a87b98df279242cdc05843b2
Aaron Schulz [Fri, 23 Mar 2018 09:57:21 +0000 (02:57 -0700)]
rdbms: make Database query error handling more strict
Handle all errors in query() that might have caused rollback by
putting the Database handle into an error state that can only be
resolved by cancelAtomic() or rollback(). Other queries will be
rejected until then.
This results in more immediate exceptions in some cases where
atomic section mismatch errors would have been thrown, such as a
an error bubbling up from a child atomic section. Most cases were
a try/catch block assumes that only the statement was rolled back
now result in an error and rollback.
Callers using try/catch to handle key conflicts should instead use
SELECT FOR UPDATE to find conflicts beforehand, or use IGNORE, or
the upsert()/replace() methods. The try/catch pattern is unsafe and
no longer allowed, except for some common errors known to just
rollback the statement. Even then, such statements can come from
child atomic sections, so committing would be unsafe. Luckily, in
such cases, there will be a mismatch detected on endAtomic() or a
dangling section detected in close(), resulting in rollback.
Remove caching from DatabaseMyslBase::getServerVariableSettings
in case some SET query changes the values.
Bug: T189999
Change-Id: I532bc5201681a915d0c8aa7a3b1c143b040b142e
jenkins-bot [Wed, 4 Apr 2018 23:10:03 +0000 (23:10 +0000)]
Merge "User: Remove deprecated, unused auth functions"
Florian Schmidt [Fri, 30 Mar 2018 21:17:48 +0000 (23:17 +0200)]
User: Remove deprecated, unused auth functions
According to a github search they're not used anywhere anymore and
already deprecated since 1.27:
::getEditTokenTimestamp
::getPasswordFactory
::passwordChangeInputAttribs
Change-Id: I904e46e7343baee28dc960f8fd5437ae9d17fc4b
jenkins-bot [Wed, 4 Apr 2018 22:53:59 +0000 (22:53 +0000)]
Merge "CSSMin: Don't match empty string as remappable url"
jenkins-bot [Wed, 4 Apr 2018 22:53:15 +0000 (22:53 +0000)]
Merge "Convert HTTP links to MediaWiki.org to HTTPS"
jenkins-bot [Wed, 4 Apr 2018 21:36:36 +0000 (21:36 +0000)]
Merge "rdbms: rename and clarify getTransactionLagStatus method regarding begin()"
Timo Tijhof [Wed, 4 Apr 2018 20:07:33 +0000 (21:07 +0100)]
CSSMin: Don't match empty string as remappable url
The empty string being matched causes an undefined array index
notice in production, seen from various random gadgets, but spiked
after a change in MonoBook from last week that introduced a
broken background-image rule with empty string as url.
In browsers, that is actually interpreted as valid and "expands"
to the current url and re-fetches as Accept:image/*, silly, but
still broken. The broken icon was fixed in MonoBook, but we still
need to avoid trying to remap empty string as url.
Two changes:
1. Fix regex used by remap() to not match empty string.
This was already fixed for the 'url()' case without the
optional quotes, but with quotes, it was being matched as
non-empty. This is now fixed by using '+' instead of '*'.
Added tests to confirm they produce output, and PHPUnit
is configured to also assert no Notices are emitted (which
it converts to fatal exceptions).
2. Fix processUrlMatch() as sanity check to throw if the key
is missing.
Bug: T191237
Change-Id: I0ada337b0b4ab73c80236367ff79c31bcd13aa7d
Translation updater bot [Wed, 4 Apr 2018 20:12:20 +0000 (22:12 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I56c13502176ea25a03148afc4f2256079e76dc82
jenkins-bot [Wed, 4 Apr 2018 19:45:46 +0000 (19:45 +0000)]
Merge "Change index on rc_namespace, rc_title to rc_namespace, rc_title, rc_timestamp"
jenkins-bot [Wed, 4 Apr 2018 19:36:31 +0000 (19:36 +0000)]
Merge "Fix parsing of <pre> tags generated by extension tag hooks"
jenkins-bot [Wed, 4 Apr 2018 19:28:49 +0000 (19:28 +0000)]
Merge "Revert "Work around Firefox 57 attribute parsing regression""
jenkins-bot [Wed, 4 Apr 2018 19:04:14 +0000 (19:04 +0000)]
Merge "Special:Preference: Check for changes before enabling Save button"
Zoranzoki21 [Sun, 18 Mar 2018 12:58:15 +0000 (12:58 +0000)]
Convert HTTP links to MediaWiki.org to HTTPS
Bug: T189687
Change-Id: I846d3a74f617b98c8237f2a8babef85c6c128b14
jenkins-bot [Wed, 4 Apr 2018 18:17:05 +0000 (18:17 +0000)]
Merge "Update OOUI to v0.26.2"
Volker E [Wed, 4 Apr 2018 17:55:02 +0000 (10:55 -0700)]
Update OOUI to v0.26.2
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.26.2
Depends-On: If570668a7fa615b2ffc3474ce5a161515af05f3b
Change-Id: I0131533e91fc0e308f90aea2555ead07740b093d
jenkins-bot [Wed, 4 Apr 2018 17:57:17 +0000 (17:57 +0000)]
Merge "Use fallback languages in ResourceLoaderImage"
jenkins-bot [Wed, 4 Apr 2018 16:18:14 +0000 (16:18 +0000)]
Merge "rdbms: clean up DBO_TRX behavior for onTransaction* callbacks"
jenkins-bot [Wed, 4 Apr 2018 16:15:21 +0000 (16:15 +0000)]
Merge "Special:ProtectedTitles: Use HTMLForm"
jenkins-bot [Wed, 4 Apr 2018 16:05:39 +0000 (16:05 +0000)]
Merge "Use new API for descriptions in TitleWidget"
jenkins-bot [Wed, 4 Apr 2018 15:39:22 +0000 (15:39 +0000)]
Merge "Remove outdated comment for .background-image-svg"
jenkins-bot [Wed, 4 Apr 2018 15:34:13 +0000 (15:34 +0000)]
Merge "RCFilters: Followup Iebc3176c5d: Bidi isolate filter tags"
Ed Sanders [Wed, 4 Apr 2018 14:47:31 +0000 (15:47 +0100)]
Use new API for descriptions in TitleWidget
Bug: T191333
Change-Id: I5682f2fe3000d61c3760d22e9a567c762cf36710
Niklas Laxström [Wed, 4 Apr 2018 14:29:58 +0000 (16:29 +0200)]
Remove outdated comment for .background-image-svg
Since we dropped prefixed versions, we are no longer embedding
multiple times.
Change-Id: I58ad6f732289253c22cf12c74e340cd81c26e943
jenkins-bot [Wed, 4 Apr 2018 14:16:48 +0000 (14:16 +0000)]
Merge "Convert Maintenance to the new shell framework"
jenkins-bot [Wed, 4 Apr 2018 14:09:59 +0000 (14:09 +0000)]
Merge "Switch Installer to the new execution framework"
jenkins-bot [Wed, 4 Apr 2018 14:09:33 +0000 (14:09 +0000)]
Merge "Switch ServiceWiring to the new execution framework"
Max Semenik [Thu, 18 Jan 2018 02:24:34 +0000 (18:24 -0800)]
Convert Maintenance to the new shell framework
Change-Id: Ibec8a84071fdf061f9831b2964143d99464cd4cc
Max Semenik [Wed, 25 Oct 2017 02:07:05 +0000 (19:07 -0700)]
Switch Installer to the new execution framework
Change-Id: Id04ba0751ff94e9614852e351377405f65b6ea1c
Max Semenik [Wed, 25 Oct 2017 01:51:45 +0000 (18:51 -0700)]
Switch ServiceWiring to the new execution framework
To test:
$wgMimeDetectorCommand = 'file -bi';
$services = \MediaWiki\MediaWikiServices::getInstance();
echo $services->getMimeAnalyzer()->guessMimeType('/vagrant/mediawiki/README');
Change-Id: Iaf124901c68292736e5588636f5ec746147f6a54
Moriel Schottlender [Thu, 29 Mar 2018 19:46:09 +0000 (22:46 +0300)]
RCFilters: Followup Iebc3176c5d: Bidi isolate filter tags
Bug: T190718
Change-Id: I8e556624ddbc4e824a3fb9724f6fb721c18d2e85
Antoine Musso [Tue, 13 Mar 2018 09:16:15 +0000 (10:16 +0100)]
Let install.php detect and inject extensions [2]
For CI, I went with a dirty trick to find extensions and either
wfLoadExtension() or include them. That has since been ported to
Installer::findExtensions() and LocalSettingsGenerator::getText().
The WebInstaller() relies on that to detect extensions and let the user
tick the ones to be installed.
Add --with-extensions to install.php so one can include all extensions
from the command line.
Note: The CliInstaller always wfLoad() any skin it can find.
The original patch
53926d9d was broken and got reverted. This is the
proper one.
Bug: T189567
Change-Id: I41820fce12e01224d64ab711e016835ef4d4febc
Amir Sarabadani [Thu, 22 Mar 2018 19:46:49 +0000 (20:46 +0100)]
Change index on rc_namespace, rc_title to rc_namespace, rc_title, rc_timestamp
Bug: T190444
Change-Id: I5c59f1ee9306710505654a8db965f85ebf855873
Aaron Schulz [Mon, 19 Mar 2018 05:26:11 +0000 (22:26 -0700)]
rdbms: clean up DBO_TRX behavior for onTransaction* callbacks
* Make onTransactionIdle() wait until any transaction round
is gone, even if there is no SQL transaction active. This
is what onTransactionPreCommitOrIdle() already does.
* Decouple "transaction round mode" (DBO_TRX) from whether a
round is active via a 'trxRoundId' LB info field. If rounds
are enabled, but not is started, then the transaction state
should be interpreted as "idle".
* Improve related documentation.
* Add more related unit tests.
Change-Id: I3ab18f577ec0375897fcb63f18f4ee2deeb436e9
James D. Forrester [Tue, 3 Apr 2018 20:37:46 +0000 (13:37 -0700)]
Update OOjs to v2.2.0
Release notes:
https://gerrit.wikimedia.org/r/plugins/gitiles/oojs/core/+/v2.2.0/History.md
Change-Id: If2f673da4c2f6c1576620d96ed28ac4c538ba119
jenkins-bot [Tue, 3 Apr 2018 19:53:55 +0000 (19:53 +0000)]
Merge "rdbms: clean up session/transaction loss logic in Database"
jenkins-bot [Tue, 3 Apr 2018 18:48:19 +0000 (18:48 +0000)]
Merge "OOUIHTMLForm styles: Replace fixed properties with `.transition()` mixin"
jenkins-bot [Tue, 3 Apr 2018 18:48:05 +0000 (18:48 +0000)]
Merge "OOUIHTMLForm styles: Unify spacing aligned to new base font-size"
Volker E [Mon, 2 Apr 2018 20:45:23 +0000 (13:45 -0700)]
OOUIHTMLForm styles: Replace fixed properties with `.transition()` mixin
Change-Id: I16789cca4d797e3147dfbaac8b50280d0240a1b7
Volker E [Sat, 31 Mar 2018 05:26:39 +0000 (22:26 -0700)]
OOUIHTMLForm styles: Unify spacing aligned to new base font-size
Follow-up to I693d168d2ccf2babbcfe8952af3e1c262aa97773
Bug: T177668
Change-Id: I86077eadbf0986868cbaabd41c33b48e333d7973
Amir Sarabadani [Thu, 22 Mar 2018 14:17:56 +0000 (15:17 +0100)]
Make autopatrol third option in rc_patrolled and use it in API
Bug: T184791
Change-Id: If64ba8b845b122a87f20646dddf72ef257b793cb
jenkins-bot [Tue, 3 Apr 2018 15:37:05 +0000 (15:37 +0000)]
Merge "Populate ar_rev_id and make it non-nullable"
Antoine Musso [Tue, 3 Apr 2018 08:31:09 +0000 (10:31 +0200)]
tests: fix PHPUnit @requires for APCU
@requires is an annotation used by PHPUnit to flag a test as requiring a
PHP function or extension.
c214c9a95 changed it to list two functions
separated by a slash:
@requires function apc_store/apcu_store
However that is not recognized by PHPUnit and the test is always
skipped.
Change the @requires to require the APCU extension.
Repro case:
phpunit.php --verbose includes/libs/MemoizedCallableTest.php
Follow-up
c214c9a95255abf1032d389d0fe8bcbde38b55db
Bug: T140587
Change-Id: I1fdd52c8fc8ca1c7c0c7f914e6da8774799ba5d8
jenkins-bot [Tue, 3 Apr 2018 09:09:46 +0000 (09:09 +0000)]
Merge "LanguageConverter tweaks to Pig Latin converter"
Translation updater bot [Tue, 3 Apr 2018 07:00:01 +0000 (09:00 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I23379ec2eb8320618f5be56618ed5c45587c8825
Sam Wilson [Tue, 3 Apr 2018 03:56:18 +0000 (11:56 +0800)]
Add DeleteUnknownPreferences hook
This makes it possible for extensions to add to the WHERE clause
with which unknown preferences are deleted.
Bug: T188966
Change-Id: Ifb22ca42207956f2b07333da026ff0b215a83930
jenkins-bot [Tue, 3 Apr 2018 06:13:32 +0000 (06:13 +0000)]
Merge "Add further test cases to deleteAutoPatrolLogsTest"
Marius Hoch [Tue, 3 Apr 2018 05:15:43 +0000 (07:15 +0200)]
Add further test cases to deleteAutoPatrolLogsTest
Also make --batch-size work and make an if check nicer
(makes no functional difference AFAICT).
Bug: T189594
Change-Id: I3ce63386cb35441acfa226f313ec8aac1aa417a6
jenkins-bot [Tue, 3 Apr 2018 05:25:52 +0000 (05:25 +0000)]
Merge "Introduce deleteAutoPatrolLogs maintenance script"
Amir Sarabadani [Sat, 17 Mar 2018 23:34:32 +0000 (00:34 +0100)]
Introduce deleteAutoPatrolLogs maintenance script
It's useful to delete old patrol logs that are not useful
Bug: T189594
Change-Id: I605bb85f172eb25df45ed83ce50a3d1044f1c281
jenkins-bot [Tue, 3 Apr 2018 01:18:42 +0000 (01:18 +0000)]
Merge "DB: Add img_description_id column"
jenkins-bot [Mon, 2 Apr 2018 21:48:21 +0000 (21:48 +0000)]
Merge "build: Updating mediawiki/mediawiki-codesniffer to 17.0.0"
Aaron Schulz [Mon, 2 Apr 2018 21:39:33 +0000 (14:39 -0700)]
rdbms: rename and clarify getTransactionLagStatus method regarding begin()
Make sure any value from the last transaction is cleared and not used.
For sanity, make getLagFromPtHeartbeat() use this regardless of the age of
the transaction unless it returns null.
Change-Id: I52df6147f99736ad1a389ae70d347ae968e50c7f
Aaron Schulz [Mon, 2 Apr 2018 21:02:47 +0000 (14:02 -0700)]
Revert "rdbms: make getMasterPos() ignore GTIDs outside of gtid_domain_id"
This had a noticeable increase in LoadBalancer::doWait timeouts.
This reverts commit
ceb7d61ee7ef3edc6705abd41ec86b3afcd9c491.
Change-Id: I7004d55a05c20f646f70d778d7b6496123e270a4
Aaron Schulz [Mon, 2 Apr 2018 19:56:11 +0000 (12:56 -0700)]
rdbms: avoid incorrect warnings in getLagFromPtHeartbeat()
Change-Id: I4c0d42be0ee0c518d7bacdae0f76feb53007861e
jenkins-bot [Mon, 2 Apr 2018 18:02:28 +0000 (18:02 +0000)]
Merge "Make LanguageConverter roman-numeral cases consistent"
Brad Jorsch [Thu, 4 Jan 2018 19:35:13 +0000 (14:35 -0500)]
Populate ar_rev_id and make it non-nullable
Revisions deleted before MediaWiki 1.5 do not have a value in this
field. This is going to be a problem for migration to the MCR schema, so
provide a maintenance script to clean this up.
Then, for good measure, change the schema to make the field
non-nullable.
Bug: T182678
Change-Id: Ie2e11f12a30f379db32c3e074658012c6f93adb0
jenkins-bot [Mon, 2 Apr 2018 12:15:44 +0000 (12:15 +0000)]
Merge "Selenium: update WebdriverIO configuration"
Translation updater bot [Mon, 2 Apr 2018 07:27:16 +0000 (09:27 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I35703b36f31021e7ba272c3b1869808cb95b580f
Prateek Saxena [Mon, 2 Apr 2018 05:08:22 +0000 (10:38 +0530)]
Special:Preference: Check for changes before enabling Save button
* Changing mousedown and keydown to mouseup and keyup
…so that isPrefsChanged gets the updated value and can return
something useful
* Changing one to on
…so that if a value is updated and then changed back to the
original, the button can be disabled again
Bug: T180538
Change-Id: I7146f8d3166e09e13b26321e7a6a7c8ac74f9aaf