From: Kunal Mehta <legoktm@gmail.com>
Date: Tue, 12 May 2015 00:59:07 +0000 (-0700)
Subject: Add ':' to $wgInvalidUsernameCharacters
X-Git-Tag: 1.31.0-rc.0~11425^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/%22%24ccApp/ecrire?a=commitdiff_plain;h=9aa5cd1b1c619a89687d4e6441f5220b50670072;p=lhc%2Fweb%2Fwiklou.git

Add ':' to $wgInvalidUsernameCharacters

This will prevent the creation of new users with a colon character
in their username. Existing accounts or system users will not be affected.

Colons themselves are not an issue, however they are used as the delimiter
for namespaces and interwikis. In a global account type system where there
are wikis with multiple languages, usernames that begin with a localized
namespace prefix will be invalid on some wikis and not others, which is
problematic. Preventing the usage of colons avoids that issue entirely.

Bug: T98757
Change-Id: I3c823325e209b2c48c1eee1fbc82a130c768cd2c
---

diff --git a/RELEASE-NOTES-1.26 b/RELEASE-NOTES-1.26
index 8cb750340a..3d6651f952 100644
--- a/RELEASE-NOTES-1.26
+++ b/RELEASE-NOTES-1.26
@@ -13,6 +13,8 @@ production.
 === New features in 1.26 ===
 * Change tags can now be hidden in the interface by disabling the associated
   "tag-<id>" interface message.
+* ':' (colon) is now invalid in usernames for new accounts. Existing accounts
+  are not affected.
 
 ==== External libraries ====
 
diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index 31724f6dcd..857d69ee51 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -4438,7 +4438,7 @@ $wgHiddenPrefs = array();
  * This is used in a regular expression character class during
  * registration (regex metacharacters like / are escaped).
  */
-$wgInvalidUsernameCharacters = '@';
+$wgInvalidUsernameCharacters = '@:';
 
 /**
  * Character used as a delimiter when testing for interwiki userrights