From: Timo Tijhof <krinklemail@gmail.com>
Date: Sat, 31 Aug 2019 15:33:06 +0000 (+0100)
Subject: Setup: Remove debug message for "caches"
X-Git-Tag: 1.34.0-rc.0~461
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/%22%24ccApp/ecrire?a=commitdiff_plain;h=70cb2664805a723c063a063bd4899c254f44b308;p=lhc%2Fweb%2Fwiklou.git

Setup: Remove debug message for "caches"

This is currently forcing more object cache interfaces to be constructed
than might be needed in a given request. The configuration for these
interfaces is usually quite straight forward or can be trivially
verified from eval.php.

If we do want to log this, I would recommend doing it from the classes
constructor instead e.g. something like:

  LoggerFactory::getInstance('MessageCache')->debug( get_class( $cache ) );

Bug: T189966
Change-Id: I06dc6dfbdf274bb57e9295b0c757b8d52c02acbe
---

diff --git a/includes/Setup.php b/includes/Setup.php
index 226780080d..c1c6ef2ae6 100644
--- a/includes/Setup.php
+++ b/includes/Setup.php
@@ -789,14 +789,6 @@ if ( $wgCommandLineMode ) {
 $wgMemc = ObjectCache::getLocalClusterInstance();
 $messageMemc = wfGetMessageCacheStorage();
 
-wfDebugLog( 'caches',
-	'cluster: ' . get_class( $wgMemc ) .
-	', WAN: ' . ( $wgMainWANCache === CACHE_NONE ? 'CACHE_NONE' : $wgMainWANCache ) .
-	', stash: ' . $wgMainStash .
-	', message: ' . get_class( $messageMemc ) .
-	', session: ' . get_class( ObjectCache::getInstance( $wgSessionCacheType ) )
-);
-
 // Most of the config is out, some might want to run hooks here.
 Hooks::run( 'SetupAfterCache' );