From a0ac6a453bd00326f5903f4fa19a7b4b01cf9e67 Mon Sep 17 00:00:00 2001 From: Stephane Bisson Date: Wed, 3 May 2017 14:58:22 -0400 Subject: [PATCH] RC Filters: always join with 'page' The 'last revision' filter group relies on the 'page' table to filter and highlight. Bug: T163561 Change-Id: I29be21596ce02270859936203c921777c952e3a4 --- includes/specials/SpecialRecentchanges.php | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/includes/specials/SpecialRecentchanges.php b/includes/specials/SpecialRecentchanges.php index aaa99b60f1..e1435096fa 100644 --- a/includes/specials/SpecialRecentchanges.php +++ b/includes/specials/SpecialRecentchanges.php @@ -247,11 +247,10 @@ class SpecialRecentChanges extends ChangesListSpecialPage { ] ]; } - if ( $user->isAllowed( 'rollback' ) ) { - $tables[] = 'page'; - $fields[] = 'page_latest'; - $join_conds['page'] = [ 'LEFT JOIN', 'rc_cur_id=page_id' ]; - } + // JOIN on page, used for 'last revision' filter highlight + $tables[] = 'page'; + $fields[] = 'page_latest'; + $join_conds['page'] = [ 'LEFT JOIN', 'rc_cur_id=page_id' ]; ChangeTags::modifyDisplayQuery( $tables, -- 2.20.1