From 16de3266d2dd404bc50ea50668b449a23565d069 Mon Sep 17 00:00:00 2001 From: =?utf8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Date: Wed, 7 Jul 2010 15:05:05 +0000 Subject: [PATCH] new-installer: Revert DB driver check breakage in r69128 We should use isCompiled() to check if we can actually use a DB driver. Just constructing the object isn't enough. r69128 regressed so that the installed displayed Oracle as an option for me, even though I have no driver for it. --- includes/installer/Installer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php index 625c2efd69..2366ad21ed 100644 --- a/includes/installer/Installer.php +++ b/includes/installer/Installer.php @@ -404,7 +404,7 @@ abstract class Installer { foreach ( $this->dbTypes as $name ) { $db = $this->getDBInstaller( $name ); $readableName = wfMsg( 'config-type-' . $name ); - if ( $db ) { + if ( $db->isCompiled() ) { $compiledDBs[] = $name; $goodNames[] = $readableName; } -- 2.20.1