From 09567cc3680e97ad004599d7b8f35d84b1e38edf Mon Sep 17 00:00:00 2001 From: Derick Alangi Date: Wed, 15 May 2019 15:17:23 +0100 Subject: [PATCH] SearchResultSet: MW version number should be a string in wfDeprecated call Seems this was a typo and I think 1.32 which is a double/float will be implicitly converted to true (bool) because it will resolve 1.32 to 1 as integer and then 1 which maps to true (bool). To avoid this, use '1.32' instead of the integer form of the version. Change-Id: Ifaf6ab0d36bc02bd1707f8caf375f65a30eb1af5 --- includes/search/SearchResultSet.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/search/SearchResultSet.php b/includes/search/SearchResultSet.php index 18331ddc75..3d3b4460bd 100644 --- a/includes/search/SearchResultSet.php +++ b/includes/search/SearchResultSet.php @@ -84,7 +84,7 @@ class SearchResultSet implements Countable, IteratorAggregate { // This class will eventually be abstract. SearchEngine implementations // already have to extend this class anyways to provide the actual // search results. - wfDeprecated( __METHOD__, 1.32 ); + wfDeprecated( __METHOD__, '1.32' ); } $this->containedSyntax = $containedSyntax; $this->hasMoreResults = $hasMoreResults; -- 2.20.1