Krinkle [Sat, 25 Dec 2010 03:26:09 +0000 (03:26 +0000)]
Added remote binding for custom collapsibles and minor improvements
* Fixed JSLint errors
* Added support for custom collapsibles that can have togglelink(s) anywhere in the document
* To prevent people from making secret toggle links (vandalism?) for things like '#content', prefix 'mw-customcollapsible-' is required
* Merged a few comments (bit less verbose)
* Adding extra check when fixing li-value. Value-attribute of an ordered list items defaults to '-1' instead of '' in Mozilla Firefox 3.
Krinkle [Sat, 25 Dec 2010 00:29:41 +0000 (00:29 +0000)]
Reverting r78889 and r78865. Breaks changeslist on translatewiki (unpatrolled-flag exclamation mark popping up on page histories and and diff-views where they shouldn't instead of an 'm' for minor)
- = ChangesList::flag( 'minor' );
- The jquery effects plugin and collapsible implementation, also in those commits, are redundant now.
- If/when skins.commons is needed again, we can simply add that part back in.
- (r78891 is not reverted because the file it altered was deleted while r78865 was -merged)
Krinkle [Fri, 24 Dec 2010 16:08:42 +0000 (16:08 +0000)]
Fixing typo from r78944
Krinkle [Fri, 24 Dec 2010 15:52:44 +0000 (15:52 +0000)]
Adding message for collapsible link in core for localization (Follow-up r78935, r78915)
Krinkle [Fri, 24 Dec 2010 15:27:11 +0000 (15:27 +0000)]
Adding fallback for collapsible messages
Krinkle [Fri, 24 Dec 2010 15:24:28 +0000 (15:24 +0000)]
Forgot to namespace the click handler. Unbinding all click handlers is indeed risky (Follow-up r78935 CR)
Krinkle [Fri, 24 Dec 2010 15:07:01 +0000 (15:07 +0000)]
Adding default styling for redirects
* Fixes bug 26266
* HTML class .allpagesredirect (redirects on [[Special:AllPages]]), .redirect-in-category (redirects in category listings)
Krinkle [Fri, 24 Dec 2010 14:34:27 +0000 (14:34 +0000)]
Removing debug call. Follow-up r78935 CR
Krinkle [Fri, 24 Dec 2010 13:44:24 +0000 (13:44 +0000)]
Make sure the TOC is there when toggleToc is called. Although the function calling it checks it too, it could be called by a third party, or the TOC could've dissapeared :O (Follow-up r78941)
Krinkle [Fri, 24 Dec 2010 13:41:57 +0000 (13:41 +0000)]
jslint warnings fixed in mw.util
Platonides [Fri, 24 Dec 2010 13:29:28 +0000 (13:29 +0000)]
We use lowercse in 'bug' here.
Platonides [Fri, 24 Dec 2010 13:28:12 +0000 (13:28 +0000)]
(Bug 26412) Search results headers no longer show a bogus edit link.
Platonides [Fri, 24 Dec 2010 12:08:47 +0000 (12:08 +0000)]
Add a couple of comments from my WC
Brian Wolff [Fri, 24 Dec 2010 10:24:16 +0000 (10:24 +0000)]
follow up to r78952 add parser tests relating to internal links with % encoding and + signs in them.
Brian Wolff [Fri, 24 Dec 2010 09:53:08 +0000 (09:53 +0000)]
(Bug 26410) In an internal link, a plus sign is treated as a space if the link
has a % sign in it, but interperted as a + if no % sign is present.
This changes how the parser interperts links slightly. However:
*I can't imagine anyone is relying on this behaviour
*Things should be consistent. a + sign shouldn't magically change meaning
if there is a % sign somewhere else in the link.
*Pages are allowed to contain % signs in their title, and + signs,
you should be able to link to such pages just by typing there name without
resorting to %2B.
*If you have a page named foo%+ having [[{{PAGENAME}}]] link to a different
page seems inherently wrong.
*The previous behaviour seemed accidental.
nadeesha [Fri, 24 Dec 2010 05:16:05 +0000 (05:16 +0000)]
Change the copyright section
nadeesha [Fri, 24 Dec 2010 05:13:54 +0000 (05:13 +0000)]
Change the values of the ADMIN_EMAIL_ADDRESS/ VALID_YOUR_NAME variables and change the copyright section
Krinkle [Fri, 24 Dec 2010 01:41:15 +0000 (01:41 +0000)]
Follow-up r77121
* Clearing float after sidebar to prevent it from sticking out on short pages
* Changing line-breaking clear-float to a non-line breaking one
Tim Starling [Fri, 24 Dec 2010 01:31:17 +0000 (01:31 +0000)]
A couple of deepRenames tweaks
Krinkle [Fri, 24 Dec 2010 01:30:23 +0000 (01:30 +0000)]
Fixing TODO from r78915
* Removed old "kr-" prefix for the plugin
* Moved function call from the bottom of the script to mw init function
Roan Kattouw [Fri, 24 Dec 2010 01:22:11 +0000 (01:22 +0000)]
Really fix bug 26131: just putting the site+user <link> at the bottom of the <head> isn't good enough if the client-side loader is gonna add dynamically populated <style> tags below it later, so we need those dynamic <style> tags to go before the site+user <link> but after the skin <link>. Make OutputPage insert a <meta> tag between these two, marking the spot for the client side load which inserts dynamic <style> tags above this <meta> tag rather than at the end of the <head>
Krinkle [Fri, 24 Dec 2010 01:06:29 +0000 (01:06 +0000)]
correcting comments in mw.util
Krinkle [Fri, 24 Dec 2010 00:55:20 +0000 (00:55 +0000)]
Porting tocToggle to ResourceLoader
* Path is now set to sitewide rather than current path so that it doesn't apply to just the current article but to the entire domain (fixes bug 26324)
* To avoid cookievalue being overriden by an older cookie from the legacy code (which had a more specific path and thus overrides it), using a different cookiename now ("mw_hidetoc" instead of "hidetoc")
Krinkle [Thu, 23 Dec 2010 23:34:32 +0000 (23:34 +0000)]
Improving jquery.makeCollapsible:
* Setting toggle function in a variable to easier reuse it through the plugin
* Replace "-hide" and "-show" classes with "expanded" and "collapsed" respectively
* For more flexibility, if there's a toggle-element already, bind the function to it and use it instead. Otherwise, just create one as usual. See [[betawiki:User:Krinkle/CollapsingTestpageKr#footer|CollapsingTestpageKr#Combination example]]
** It's more likely that the source has a custom position of the togglelink waiting for it to be bound, then it to be already bound.
* Some comments improved
* Message key "hide" to "collapsible-collapse" (Follow-up r78915 CR)
* Message key "show" to "collapsible-expand"
* Changed toggle-link content filling from html() to text() (message errors like <keyname> caused an HTML-element to be created)
Roan Kattouw [Thu, 23 Dec 2010 23:28:12 +0000 (23:28 +0000)]
Followup r78933: reapply r78802
Roan Kattouw [Thu, 23 Dec 2010 23:26:10 +0000 (23:26 +0000)]
Revert r78023 and its follow-up r78802: change seems to have been made for somewhat cosmetic reasons ("it makes more sense for this to be here rather than there") and breaks stuff. Will reapply typo fix from r78802 in next commit
Priyanka Dhanda [Thu, 23 Dec 2010 23:12:31 +0000 (23:12 +0000)]
Some test cleanup.
Chad Horohoe [Thu, 23 Dec 2010 21:49:01 +0000 (21:49 +0000)]
Revert r78903, r78904, r78905, r78906 (changing opendir() to use sfFinder class) per CR and wikitech-l objections.
It's arguable whether the code is cleaner either way, and adding all this code for the (relatively few) places we do file listings just isn't worth it.
Raimond Spekking [Thu, 23 Dec 2010 21:06:31 +0000 (21:06 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-23 20:39:00 UTC)
Roan Kattouw [Thu, 23 Dec 2010 21:01:54 +0000 (21:01 +0000)]
(bug 26399) Preload module info for all modules in startup module, to prevent lots of individual queries. Also improve preloadModuleInfo() to register the absence of message blobs for modules that do have messages (they were being missed because they were expected to have blobs for this reason)
Chad Horohoe [Thu, 23 Dec 2010 20:24:11 +0000 (20:24 +0000)]
* Fix r78774 for Oracle and Postgres, broke by method rename
* Get rid of Postgres version check, already handled by PostgresInstaller::submitConnectForm()
Roan Kattouw [Thu, 23 Dec 2010 20:14:18 +0000 (20:14 +0000)]
Proper exception handling in ResourceLoader. Catch exceptions and output them in comments. Instead of just surrounding everything in a big try { } block, catch module-level exceptions where possible to allow error-free modules loaded in the same request to still be output normally. Modules that don't get output because of an exception are marked as missing in the client-side loader so other modules depending on them won't get loaded either.
Sam Reed [Thu, 23 Dec 2010 20:00:02 +0000 (20:00 +0000)]
Another variable type hint, and some function documentation
Sam Reed [Thu, 23 Dec 2010 19:53:28 +0000 (19:53 +0000)]
More minor bits of documentation
Object type hint on mPrinter
Krinkle [Thu, 23 Dec 2010 19:42:26 +0000 (19:42 +0000)]
removing cursor style from JS, adding to CSS file instead
Krinkle [Thu, 23 Dec 2010 19:27:43 +0000 (19:27 +0000)]
fixing comment in jquery.makeCollapsible.js (in mw 'jquery' is written in lowercase in filenames
Krinkle [Thu, 23 Dec 2010 19:26:30 +0000 (19:26 +0000)]
whitespace according to mw conventions + using mw.msg instead of english hardcoding
Krinkle [Thu, 23 Dec 2010 19:25:16 +0000 (19:25 +0000)]
adding jQuery.makeCollapsible plugin
Sam Reed [Thu, 23 Dec 2010 19:24:38 +0000 (19:24 +0000)]
Add some method documentation
Roan Kattouw [Thu, 23 Dec 2010 18:38:24 +0000 (18:38 +0000)]
Fix r78897: remove dependency on makeCollapsible as well
X! [Thu, 23 Dec 2010 18:28:25 +0000 (18:28 +0000)]
Followup to r78903: Add proper SVN info
X! [Thu, 23 Dec 2010 18:22:10 +0000 (18:22 +0000)]
Followup to r78903: Forgot to svn add
X! [Thu, 23 Dec 2010 18:20:13 +0000 (18:20 +0000)]
Per discussion on mailing list, modifying some uses of opendir()/readdir()/closedir() to use new sfFinder class.
Krinkle [Thu, 23 Dec 2010 17:50:52 +0000 (17:50 +0000)]
didn't mean to commit this
Krinkle [Thu, 23 Dec 2010 16:36:37 +0000 (16:36 +0000)]
using .append() instead of innerHTML+=. The latter replaces the html and causes all bound event handlers to be list
Happy-melon [Thu, 23 Dec 2010 16:21:06 +0000 (16:21 +0000)]
Follow-up r78865 CR
Happy-melon [Thu, 23 Dec 2010 15:03:24 +0000 (15:03 +0000)]
Follow-up r78865 CR; restore arrow helper functions, fixing fatal on TWN.
Roan Kattouw [Thu, 23 Dec 2010 14:16:20 +0000 (14:16 +0000)]
Fix JS errors thrown by SimpleSearch: add dependency from jquery.autoEllipsis to jquery.highlightText, and fix the latter for the RegExp.escape() -> $.escapeRE() rename
Roan Kattouw [Thu, 23 Dec 2010 14:07:25 +0000 (14:07 +0000)]
Followup r78539: don't renew a cookie that expires at the end of the session anyway, no point in doing that.
nadeesha [Thu, 23 Dec 2010 11:58:32 +0000 (11:58 +0000)]
Added MediaWikiOnAlreadyInstalledTestCase.php to the test suite
nadeesha [Thu, 23 Dec 2010 10:36:22 +0000 (10:36 +0000)]
Updated the test cases as per the code review comments
nadeesha [Thu, 23 Dec 2010 10:30:25 +0000 (10:30 +0000)]
Added MediaWikiInstallationMessage.php and MediaWikiInstallationVariables.php as per the code review comment
Siebrand Mazeland [Thu, 23 Dec 2010 09:21:11 +0000 (09:21 +0000)]
Tweak 'nocookiesfornew'
Happy-melon [Thu, 23 Dec 2010 00:06:58 +0000 (00:06 +0000)]
(bug 17456) implement CollapsibleTables in core javascript. Using ResourceLoader/jQuery, this is now able to replace not only the ubiquitous collapsible tables in articles ([[mw:Manual:Collapsible tables]]), but also most of the other places we collapse things as well, like the enhanced Watchlist/RecentChanges feed.
Sam Reed [Wed, 22 Dec 2010 21:52:37 +0000 (21:52 +0000)]
Better release notes for r78841
Sam Reed [Wed, 22 Dec 2010 21:50:00 +0000 (21:50 +0000)]
Fixup date and uppercase parameter from r78824
Platonides [Wed, 22 Dec 2010 21:44:05 +0000 (21:44 +0000)]
Reimplement $cp1252Table avoiding th e5.3-only heredoc.
Sam Reed [Wed, 22 Dec 2010 21:40:33 +0000 (21:40 +0000)]
* (bug 24287) Wrap/similar on api help output
Roan Kattouw [Wed, 22 Dec 2010 21:32:57 +0000 (21:32 +0000)]
Fix r78828: comma to dot
Sam Reed [Wed, 22 Dec 2010 21:30:43 +0000 (21:30 +0000)]
Per bug 14869 being fixed, bug 8130 and bug 14020 have been fixed. Marking them as resolved in the RELEASE-NOTES too
Sam Reed [Wed, 22 Dec 2010 21:12:50 +0000 (21:12 +0000)]
Remove spurious 0 from r78831
Sam Reed [Wed, 22 Dec 2010 21:08:40 +0000 (21:08 +0000)]
Add a really basic example for completeness
Sam Reed [Wed, 22 Dec 2010 21:03:51 +0000 (21:03 +0000)]
Fix trailing whitespace in ApiQueryQueryPage.
Add comment noting that the pages are case sensitive
Raimond Spekking [Wed, 22 Dec 2010 20:55:03 +0000 (20:55 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-21 20:31:00 UTC)
Sam Reed [Wed, 22 Dec 2010 20:52:06 +0000 (20:52 +0000)]
Delete all the "API for MediaWiki 1.8+" comments
Add since to ApiQueryQueryPage
Roan Kattouw [Wed, 22 Dec 2010 20:49:29 +0000 (20:49 +0000)]
Fix misspelling of my name, that I seem to have put in myself. Kinda embarrassing
Roan Kattouw [Wed, 22 Dec 2010 20:48:10 +0000 (20:48 +0000)]
Replace my old e-mail address with my new one in API comments. A bit outdated (dropped the old one in September '08)
Sam Reed [Wed, 22 Dec 2010 20:43:22 +0000 (20:43 +0000)]
Minor followup to r78822, locally cache the cachedTimestamp so we don't have to do duplicate db calls for the same information
Sam Reed [Wed, 22 Dec 2010 20:38:19 +0000 (20:38 +0000)]
RELEASE-NOTES for r78824, r78786
Roan Kattouw [Wed, 22 Dec 2010 20:35:37 +0000 (20:35 +0000)]
(bug 14869) Add API module for accessing QueryPage-based special pages. Took 2.5 years and a flight to England to get this done, but there you go :)
Sam Reed [Wed, 22 Dec 2010 20:33:35 +0000 (20:33 +0000)]
Comment out unreachable code line
Roan Kattouw [Wed, 22 Dec 2010 20:31:32 +0000 (20:31 +0000)]
Refactor the retrieval of the cache timestamp into getCachedTimestamp() so the future API module can use it
Roan Kattouw [Wed, 22 Dec 2010 19:57:31 +0000 (19:57 +0000)]
Remove nonsense comment about order being relevant
Sam Reed [Wed, 22 Dec 2010 18:25:40 +0000 (18:25 +0000)]
Spaces and braces
Roan Kattouw [Wed, 22 Dec 2010 18:08:52 +0000 (18:08 +0000)]
Followup r78786: make back compat mode actually work by moving up $dbr assignment
Roan Kattouw [Wed, 22 Dec 2010 17:29:31 +0000 (17:29 +0000)]
Followup r78786: var->protected
Roan Kattouw [Wed, 22 Dec 2010 17:20:50 +0000 (17:20 +0000)]
(bug 26395) Change name of Cornish language to Kernowek
Sam Reed [Wed, 22 Dec 2010 16:28:52 +0000 (16:28 +0000)]
Followup r78805, remove now unused function
Sam Reed [Wed, 22 Dec 2010 16:21:02 +0000 (16:21 +0000)]
Simple commit trimming some trailing whitespace
Sam Reed [Wed, 22 Dec 2010 16:20:16 +0000 (16:20 +0000)]
Show images that don't exist, as they are included in the count
Roan Kattouw [Wed, 22 Dec 2010 16:19:32 +0000 (16:19 +0000)]
Mark LinkSearch as uncacheable and fix its headers display. Followup r78786
Roan Kattouw [Wed, 22 Dec 2010 16:18:24 +0000 (16:18 +0000)]
Fix reported database error in updateSpecialPages.php for SpecialMIMEsearch, by returning 0 rather than false from QueryPage::recache() for uncacheable pages
Sam Reed [Wed, 22 Dec 2010 16:16:12 +0000 (16:16 +0000)]
Followup r78023, change usage of $style to $styles, not introduced in this revision, but was moved by it
Roan Kattouw [Wed, 22 Dec 2010 15:58:15 +0000 (15:58 +0000)]
Performance crusade in SpecialListredirects:
* Use the rd_* fields to build redirect objects directly rather than running additional queries to grab them
** If the rd_* fields are not available (i.e. when running from cache), use Article::getRedirectTarget() rather than grabbing the revision text
* Preload the existence status of the redirects and their targets in a LinkBatch so Linker::link() won't query them one at a time
Roan Kattouw [Wed, 22 Dec 2010 15:54:27 +0000 (15:54 +0000)]
Treat interwiki titles as known-bad in LinkCache, prevents useless queries for interwiki titles with possibly misleading results
Alexandre Emsenhuber [Wed, 22 Dec 2010 15:29:29 +0000 (15:29 +0000)]
We need to select the namespace, even hardcoded, this is causing: Notice: Undefined property: stdClass::$namespace in includes/QueryPage.php on line 307
Alexandre Emsenhuber [Wed, 22 Dec 2010 15:24:13 +0000 (15:24 +0000)]
No need to recreate a second object if we already have the good one ;)
Niklas Laxström [Wed, 22 Dec 2010 15:22:59 +0000 (15:22 +0000)]
Few @since annotations
Sam Reed [Wed, 22 Dec 2010 15:20:10 +0000 (15:20 +0000)]
Followup r78786, fix special wanted pages. Aliasing pages in left join doesn't work
Trim some trailing whitespace too
Alexandre Emsenhuber [Wed, 22 Dec 2010 15:06:08 +0000 (15:06 +0000)]
Follow-up r78786: for consistency, removed array() when there's only one item
Roan Kattouw [Wed, 22 Dec 2010 15:00:33 +0000 (15:00 +0000)]
Really do what r78790 claimed to do (fix E_STRICT in r78786)
Roan Kattouw [Wed, 22 Dec 2010 14:53:24 +0000 (14:53 +0000)]
Followup r7876: fix another E_STRICT: kill additional parameter in doQuery() override; I guess doQuery() must've had that third parameter before but doesn't have it anymore
Roan Kattouw [Wed, 22 Dec 2010 14:35:57 +0000 (14:35 +0000)]
Followup r78786: remove useless getTitle() override, was causing E_STRICT
Roan Kattouw [Wed, 22 Dec 2010 14:16:25 +0000 (14:16 +0000)]
Merge querypage-work2 branch from trunk. The most relevant changes are:
* QueryPage now uses array-based query building instead of raw SQL
* Converted all QueryPage-based special pages that were using old-style wfSpecialFoo functions to new-style SpecialPage subclasses; this is possible because QueryPage is changed to extend SpecialPage
* Backward compatibility for extensions is partly preserved: getSQL() is fallen back on for QueryPage subclasses that don't implement getQueryInfo(), but getOrder() will be ignored (implement getOrderFields() instead). This also means that dual compatibility (1.18 compat and b/c with pre-1.18) is trivial
Extension changes will be merged after this commit.
These changes make it easier to write an API module for QueryPages (bug 14869); this wasn't done in the branch but will be done in trunk soon.
Sam Reed [Wed, 22 Dec 2010 11:16:24 +0000 (11:16 +0000)]
Followup r78775, svn:eol-style native SET UP YOUR AUTOPROPS
nadeesha [Wed, 22 Dec 2010 10:13:12 +0000 (10:13 +0000)]
delete the additional variable
nadeesha [Wed, 22 Dec 2010 09:35:23 +0000 (09:35 +0000)]
Add MediaWiki 1.18 alpha installer test cases
Chad Horohoe [Wed, 22 Dec 2010 05:21:22 +0000 (05:21 +0000)]
Rewrite install steps again (cleanup r76390)
* No longer iterating and modifying the same array
* Allows multiple attachments to the same step
* Database -> DatabaseMysql
Krinkle [Wed, 22 Dec 2010 04:08:40 +0000 (04:08 +0000)]
small fixes
* Change assumptions about default/newest skin in CSS comments from Monobook to Vector
* Single-item array to string
Platonides [Wed, 22 Dec 2010 01:11:22 +0000 (01:11 +0000)]
Revert r78767. The problem was $wgDBerrorLog being false.