Bartosz Dziewoński [Thu, 24 Nov 2016 15:18:24 +0000 (16:18 +0100)]
Html: Unblacklist HTML5 form validation attributes
We blacklisted them in 2010. Modern browsers support them fairly well,
and it doesn't seem to conflict with any of our code.
I tested this with SecurePoll poll creation form, which contains an
astonishingly wide range of form controls and validation options.
Change-Id: I08244addcf9b6eb96137895f28e7b750914fef5c
Bartosz Dziewoński [Fri, 2 Dec 2016 18:17:35 +0000 (19:17 +0100)]
HTMLForm: Suppress HTML5 form validation for non-JS users when needed
Our 'hide-if' fields are fundamentally incompatible with HTML5 form
validation attributes. If you have a checkbox field A, and field B
that is required, but hidden if A is unchecked - that's impossible to
express with HTML5 form validation. The only thing you can do is
remove the validation on B (or on the entire form).
The field contents are still validated server-side, just like if the
browser did not support HTML5 forms. The validation is also re-enabled
in JavaScript, since we have extra support for 'hide-if' field that
makes them work.
Change-Id: Ia7ffa76965a7c14af9b6d2db007b6255498398d9
jenkins-bot [Tue, 10 Jan 2017 22:00:13 +0000 (22:00 +0000)]
Merge "Reduce WAN object cache logging spam for reject set() calls"
jenkins-bot [Tue, 10 Jan 2017 21:42:09 +0000 (21:42 +0000)]
Merge "Add an refresh probability comment to worthRefreshPopular()"
jenkins-bot [Tue, 10 Jan 2017 21:28:21 +0000 (21:28 +0000)]
Merge "Added reason suggestion in block/delete/protect forms"
Aaron Schulz [Tue, 10 Jan 2017 21:20:02 +0000 (13:20 -0800)]
Reduce WAN object cache logging spam for reject set() calls
Change-Id: I276c91b3b3b47d337f9c1d91a8348ca8f3d57194
rlot [Wed, 4 Jan 2017 17:52:17 +0000 (18:52 +0100)]
Added reason suggestion in block/delete/protect forms
Bug: T34950
Change-Id: I9778c4992b127c36355949665b4fdf7482e7e0e7
jenkins-bot [Tue, 10 Jan 2017 19:24:55 +0000 (19:24 +0000)]
Merge "Implement OO.ui.isMobile"
jenkins-bot [Tue, 10 Jan 2017 19:22:35 +0000 (19:22 +0000)]
Merge "Removed deprecated unused method in RedisConnectionPool.php"
jenkins-bot [Tue, 10 Jan 2017 19:19:18 +0000 (19:19 +0000)]
Merge "registration: Don't initialize MWServices super early"
Kunal Mehta [Tue, 10 Jan 2017 18:47:08 +0000 (10:47 -0800)]
registration: Don't initialize MWServices super early
Previously, MediaWikiServices would be initialized on the first
wfLoadExtension() call, which is super early and before it should be.
There's actually no reason we need to create the BagOStuff object in the
constructor, so let's defer it to loadFromQueue(). It now gets called
from the top of Setup.php, which is still a little early, but better
than before.
Bug: T154960
Change-Id: I3feef3b974ba1ba3afec0d453e1899cd476e72fb
Yuriy Shnitkovskiy [Tue, 10 Jan 2017 11:02:31 +0000 (13:02 +0200)]
Removed deprecated unused method in RedisConnectionPool.php
There are no usages of RedisConnectionPool::handleException() in core or extensions
so it can safely be removed.
Bug: T61113
Change-Id: Icd9ceb394625e9610f5071d13fbfd2760c464870
TTO [Tue, 10 Jan 2017 11:49:42 +0000 (11:49 +0000)]
Fix wrong syntax in release notes
Change-Id: I1ab89c7c8ddfe61287fc6d71698cdb4957cc0b04
Yuriy Shnitkovskiy [Tue, 10 Jan 2017 09:51:50 +0000 (11:51 +0200)]
Removed deprecated usages of Interwiki methods in core
Change-Id: Ibd25968660466c44189ccb01df1d8bec6e1b207c
David Lynch [Mon, 9 Jan 2017 21:23:31 +0000 (13:23 -0800)]
jquery.accessKeyLabel: correct accesskey for MacOS Firefox >= 14
Rewrote the accesskey logic to be a switch rather than a fuzzy pile of ifs, so
it's easier to understand.
Bug: T121183
Change-Id: Id4de206ab92fba1468c6b1a9a199150561cce33c
Translation updater bot [Mon, 9 Jan 2017 13:40:07 +0000 (14:40 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I9bed4493b6a5d12f6b77ad79e511d4c0ca4b53f7
Matthias Mullie [Thu, 5 Jan 2017 15:31:06 +0000 (16:31 +0100)]
Don't execute upload.loadConfig when it may not exist
Upload.BookletLayout creates a mw.Upload object, which has no
loadConfig method.
ForeignStructuredUpload.BookletLayout, which is a child of
Upload.BookletLayout, creates a mw.ForeignStructuredUpload
object, which does have this method.
Thus, that method should be moved to where we know the object
will have it.
Change-Id: Ibb1c0f2b8260a8b0a7cc9f02e3434aed7d163637
jenkins-bot [Mon, 9 Jan 2017 06:45:15 +0000 (06:45 +0000)]
Merge "Added log extract to Special:ChangeContentModel"
rlot [Sun, 8 Jan 2017 18:05:12 +0000 (19:05 +0100)]
Added log extract to Special:ChangeContentModel
Bug: T154874
Change-Id: I571ea324f31935c2394dce77e31c74c3afb76358
Aaron Schulz [Sun, 8 Jan 2017 03:00:00 +0000 (19:00 -0800)]
Add an refresh probability comment to worthRefreshPopular()
Change-Id: Ia6717881c7d5c19481c87ade5972c0ff641d6e11
Aaron Schulz [Sun, 8 Jan 2017 00:10:23 +0000 (16:10 -0800)]
Avoid IDEA warning about $keys being both a parameter and loop variable
Change-Id: Id562053a71f135fa863cb88b5f081982c01575cf
Translation updater bot [Sat, 7 Jan 2017 20:55:54 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I4de5673f7ed0e4f5693634d8c387b154c548737c
jenkins-bot [Sat, 7 Jan 2017 17:58:30 +0000 (17:58 +0000)]
Merge "Make RefreshLinksJob handle LinksUpdateConstructed hooks doing DB writes"
Aaron Schulz [Sat, 7 Jan 2017 05:52:29 +0000 (21:52 -0800)]
Make RefreshLinksJob handle LinksUpdateConstructed hooks doing DB writes
Bug: T153618
Change-Id: Iae52e9225fe132f2aa99e161611bf8258736d38d
Timo Tijhof [Wed, 4 Jan 2017 03:12:06 +0000 (19:12 -0800)]
Remove left-over references from comments to removed FSRepo class
Follows-up
8b18ae7b5.
Change-Id: I10badb3e4648b2b32168a8aaad35855b2f6ae35e
awu42 [Wed, 4 Jan 2017 22:44:16 +0000 (17:44 -0500)]
Removed deprecated Linker functions
Removed:
- getInterwikiLinkAttributes (deprecated in 1.25)
- getInternalLinkAttributes (deprecated in 1.25)
- getInternalLinkAttributesObj (deprecated in 1.25)
- getLinkAttributesInternal (deprecated in 1.25)
- usages in includes/DummyLinker.php
Bug: T61113
Change-Id: I98182f4145dafdc6e60953f25a5f20575257a854
TTO [Sat, 7 Jan 2017 02:27:23 +0000 (02:27 +0000)]
Additional test for {{PAGELANGUAGE}} magic word
Make sure it returns the default content language on pages where the
language is not explicitly set.
Bug: T59603
Change-Id: I7b1437bf1650166c8be77e5bd84181c577961f27
jenkins-bot [Sat, 7 Jan 2017 07:26:05 +0000 (07:26 +0000)]
Merge "Pull rendering of single result out of SpecialSearch"
divadsn [Fri, 6 Jan 2017 19:44:36 +0000 (19:44 +0000)]
Add a new {{PAGELANGUAGE}} variable for use in wikitext
Returns the language code of the page being parsed.
Bug: T59603
Change-Id: I229edd6251cf1120b3395d1811dbb9d96d9cd8ee
jenkins-bot [Sat, 7 Jan 2017 00:27:35 +0000 (00:27 +0000)]
Merge "API: Allow finding log events and links to special pages"
jenkins-bot [Fri, 6 Jan 2017 23:15:43 +0000 (23:15 +0000)]
Merge "phpunit: Use assertEquals(, $delta) in UserTest instead of greater/lessThan"
jenkins-bot [Fri, 6 Jan 2017 23:07:55 +0000 (23:07 +0000)]
Merge "CollationFa: Third time's the charm"
jenkins-bot [Fri, 6 Jan 2017 21:55:26 +0000 (21:55 +0000)]
Merge "Add $wgSoftBlockRanges"
Translation updater bot [Fri, 6 Jan 2017 21:35:05 +0000 (22:35 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: If8375874e48c4835a4b398137806e8a44b8442f5
Brad Jorsch [Wed, 23 Nov 2016 19:51:30 +0000 (14:51 -0500)]
Add $wgSoftBlockRanges
This variable allows for blocking anonymous contributions from certain
IP addresses. Account creation from these addresses will be allowed.
The idea here is that, for example, Wikimedia could add 10.0.0.0/8 to
prevent logged-out bots on labs from making confusing edits. See
I74f5f4a3.
The default for the new variable is empty to avoid causing issues on
upgrade for wikis on private networks.
Change-Id: I6c11a6b9e1a740de074e7ccd753418f94c4b6288
Brad Jorsch [Fri, 6 Jan 2017 17:49:27 +0000 (12:49 -0500)]
API: Allow finding log events and links to special pages
Log events are sometimes attributed to a special page; it should be
allowed to use rcnamespace or lenamespace to filter for these.
It's also possible for special pages to be the targets of redirects, so
list=allredirects and prop=redirects should find them.
Maybe someday we'll record links to and transclusions of special pages
too (see T19597), so we may as well make it possible to query for those
as well via list=alllinks, list=alltransclusions, list=backlinks,
list=embeddedin, prop=linkshere, prop=transcludedin, prop=links, and
prop=templates.
NS_MEDIA has similar considerations: although we currently "normalize"
page links to the corresponding File and I don't think anything logs the
Media title rather than the File, transclusions and redirects do show
up in those tables.
Bug: T154319
Change-Id: I00348f83855c6c703b6bd6015f6d3bedc5bfd1c5
jenkins-bot [Fri, 6 Jan 2017 14:10:01 +0000 (14:10 +0000)]
Merge "API should allow querying user contribs by userid"
blackspirit96 [Tue, 29 Nov 2016 22:34:21 +0000 (00:34 +0200)]
API should allow querying user contribs by userid
It verifies that the userids are valid and then it gathers
all the contribs. Anonymous users are not suported by userids
because every anonymous user have userid === 0.
Bug: T114465
Change-Id: Id4f4fb76ea06332a7c83a55922fdfda2d665e85a
MtDu [Fri, 6 Jan 2017 13:04:41 +0000 (07:04 -0600)]
Add a reason field to both Special:PageLanguage and ApiSetPageLanguage
Most MediaWiki actions allow a user to enter a comment/reason for taking the action.
This is logged in the change log.
Currently, both ApiSetPageLanguage and Special:PageLanguage don't do this.
This patch fixes this issue.
Bug: T154644
Change-Id: I6ae021086e1ec4440d6b2894a1b85d62eb36e172
jenkins-bot [Fri, 6 Jan 2017 05:34:44 +0000 (05:34 +0000)]
Merge "Add tagging support to imagerotate, revisiondelete, and tag API modules"
Aaron Schulz [Thu, 10 Nov 2016 20:29:27 +0000 (12:29 -0800)]
Include JS variable for NewPP report
Adapted from reverted commit
b7c4c8717f9.
Bug: T110763
Change-Id: If249b679c534879bfac622592a1d2fa913a0cf9d
jenkins-bot [Thu, 5 Jan 2017 23:06:57 +0000 (23:06 +0000)]
Merge "parser: Update outdated comment about ImageGallery"
jenkins-bot [Thu, 5 Jan 2017 21:49:41 +0000 (21:49 +0000)]
Merge "Sync up with Parsoid parserTests."
Arlo Breault [Thu, 5 Jan 2017 21:20:18 +0000 (13:20 -0800)]
Sync up with Parsoid parserTests.
This now aligns with Parsoid commit
974dd5b3d70acf59bb15e057dc37e3702195f3e0
Change-Id: Ia45d8e2539e7fec23503706be1b40a6eaf1f5888
Translation updater bot [Thu, 5 Jan 2017 21:15:20 +0000 (22:15 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I77079f820222d35e482bf65c5fe634835c8b1ce8
jenkins-bot [Thu, 5 Jan 2017 20:55:15 +0000 (20:55 +0000)]
Merge "Follow-up
873d3c9ff: move new RC filters UI below the custom links"
jenkins-bot [Thu, 5 Jan 2017 20:26:07 +0000 (20:26 +0000)]
Merge "Add userExpLevel filter in the RCFilters UI"
Roan Kattouw [Thu, 5 Jan 2017 20:18:51 +0000 (12:18 -0800)]
Follow-up
873d3c9ff: move new RC filters UI below the custom links
Wikis can add custom links, and these go between mw-specialpage-summary
and rcoptions. We want our UI to appear below these custom links, not above,
so insert it before rcoptions instead of after mw-specialpage-summary.
Change-Id: Ieacc054633046719bdc991c7f04d5eaa21a17189
Moriel Schottlender [Wed, 7 Dec 2016 22:19:53 +0000 (14:19 -0800)]
Add userExpLevel filter in the RCFilters UI
Bug: T149435
Change-Id: I6a19d4b24c45068dbd9ddb8a36a0f8a87868b912
jenkins-bot [Thu, 5 Jan 2017 18:50:05 +0000 (18:50 +0000)]
Merge "Follow up to I42e74ed3bcd0bfa9ec0c344ba67668210450c975"
jenkins-bot [Thu, 5 Jan 2017 17:42:51 +0000 (17:42 +0000)]
Merge "Updated mediawiki_selenium Ruby gem"
Justin Du [Thu, 5 Jan 2017 16:44:11 +0000 (10:44 -0600)]
Follow up to I42e74ed3bcd0bfa9ec0c344ba67668210450c975
* Make pagelang-unchanged-language-default message documentation more explicit
* Use same code when displaying pagelang-unchanged-language-default and pagelang-unchanged-language
* Use 'this action' instead of 'this API'
Change-Id: I4bb4e380e090e507a26ca24b5364d8cfc7a7de71
Fomafix [Wed, 4 Jan 2017 10:46:37 +0000 (11:46 +0100)]
PHP code style: No space after unary not operator
Change-Id: I4d3df0cfcda4d88e405164123893e57786fbe15e
jenkins-bot [Thu, 5 Jan 2017 15:11:02 +0000 (15:11 +0000)]
Merge "Proper handling of invalid/unknown time zones"
Bartosz Dziewoński [Wed, 28 Dec 2016 15:10:24 +0000 (16:10 +0100)]
CollationFa: Third time's the charm
We have to use a tertiary sortkey for everything with the primary
sortkey of 2627. Otherwise, the "Remove duplicate prefixes" logic
in IcuCollation would remove them.
The following characters will now be considered separate letters in
the 'xx-uca-fa' collation for the purpose of displaying the headings
on category pages: ء ئ ا و ٲ ٳ
Bug: T139110
Change-Id: Ibbea5d76348e4cdc38b74cba44286910b2ed592f
jenkins-bot [Thu, 5 Jan 2017 14:15:14 +0000 (14:15 +0000)]
Merge "Code style: no space after unary minus operator"
Bartosz Dziewoński [Thu, 5 Jan 2017 13:38:32 +0000 (14:38 +0100)]
Code style: no space after unary minus operator
Searched for /([^\d\w\s\)\]]\s*)- \d/ to find potential issues.
It seems there's no PHPCS check for this, huh.
Also fixed typo in a comment in LoginSignupSpecialPage.
Change-Id: Iaab1a1f5a9f234971e550e7909aa5c3e0c02a983
jenkins-bot [Thu, 5 Jan 2017 10:40:04 +0000 (10:40 +0000)]
Merge "Fixed typo in comment"
jenkins-bot [Thu, 5 Jan 2017 10:29:54 +0000 (10:29 +0000)]
Merge "Add language fallback from rup (Aromanian) to ro (Romanian)"
jenkins-bot [Thu, 5 Jan 2017 06:29:10 +0000 (06:29 +0000)]
Merge "Adding new interface for review filters to RecentChanges"
This, that and the other [Sun, 25 Dec 2016 04:55:11 +0000 (15:55 +1100)]
Proper handling of invalid/unknown time zones
Currently, a user who has an invalid time zone stored in the database is
effectively locked out of their account on HHVM sites. This patch addresses
this by (1) preventing users from setting invalid time zones, and (2) not
throwing an unhandled exception if a user's TZ is unknown.
When the user saves their preferences, the code silently rewrites invalid
time zones to UTC. I think this is OK, since to cause this to happen you
have to manually muck around with the Preferences page DOM or submit the
form from a script.
Bug: T137182
Change-Id: I28c5e2ac9f2e681718c6080fb49b3b01e4af46dd
jenkins-bot [Thu, 5 Jan 2017 03:29:02 +0000 (03:29 +0000)]
Merge "Add API action to set the language of a page"
MtDu [Wed, 4 Jan 2017 00:51:24 +0000 (18:51 -0600)]
Add API action to set the language of a page
Currently, a user who wants to set a page's language must use the
Special:PageLanguage interface. However, this is not easy for bots and
scripts to use. The addition of action=setpagelanguage to the API makes
this process easier for such users.
Bug: T74958
Change-Id: I42e74ed3bcd0bfa9ec0c344ba67668210450c975
Moriel Schottlender [Tue, 8 Nov 2016 01:14:13 +0000 (17:14 -0800)]
Adding new interface for review filters to RecentChanges
Add a new filter experience to Special:RecentChanges with
a drop-down filter menu. Put it behind the rcenhancedfilters
preference, which is hidden for now.
Bug: T149435
Bug: T149452
Bug: T144448
Change-Id: Ic545ff1462998b610d7edae59472ecce2e7d51ea
Ed Sanders [Wed, 4 Jan 2017 23:45:33 +0000 (23:45 +0000)]
Implement OO.ui.isMobile
Check for MobileFrontend being used (skin='minerva').
Change-Id: If66f2fb10f96e270ed1433f0db74310734bd6156
Erik Bernhardson [Tue, 15 Nov 2016 00:14:31 +0000 (16:14 -0800)]
Pull rendering of single result out of SpecialSearch
First step in refactoring the search results page. Pulls out widgets
to render our two styles of search result, Full and Simple.
Bug: T150390
Change-Id: If78cb0c29ae394f16e465c15a8e8246c1b56dcea
jenkins-bot [Wed, 4 Jan 2017 21:31:58 +0000 (21:31 +0000)]
Merge "Replace invalid UTF-8 sequences with U+FFFD in edit summaries"
This, that and the other [Sun, 1 Jan 2017 04:04:56 +0000 (15:04 +1100)]
Replace invalid UTF-8 sequences with U+FFFD in edit summaries
Bug: T95353
Change-Id: Ib22b563e7bc4022754752632f0eebfad00e8eb01
Translation updater bot [Wed, 4 Jan 2017 21:00:05 +0000 (22:00 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I76593d3c6b29ff62339b74bcffb174653d59747d
jenkins-bot [Wed, 4 Jan 2017 20:39:30 +0000 (20:39 +0000)]
Merge "mediawiki.page.watch.ajax: Use title with spaces instead of _"
Fomafix [Wed, 4 Jan 2017 17:45:57 +0000 (18:45 +0100)]
mediawiki.page.watch.ajax: Use title with spaces instead of _
Since
1f15d1d5828dfbc70d036a52da57460ea0e89175 titles with spaces get shown
with _ instead of spaces in the success notification message.
Change-Id: I80bd1d2440ce8b815abb1fe19f4bd080bcc00fcc
Bartosz Dziewoński [Wed, 4 Jan 2017 17:21:47 +0000 (18:21 +0100)]
EditPage: Make makeTemplatesOnThisPageList() public
We want to use it in VE: I63e663d05aefb47274f1f28bdcafc5317c2fc4f6.
Bug: T149009
Change-Id: Id617f9afbddf094140133f9659efc4b4e746148c
jenkins-bot [Wed, 4 Jan 2017 16:41:54 +0000 (16:41 +0000)]
Merge "Add missing QueryAllSpecialPagesTest $queryPages property"
jenkins-bot [Wed, 4 Jan 2017 16:14:30 +0000 (16:14 +0000)]
Merge "Align fieldset borders with WikimediaUI color palette"
WMDE-Fisch [Wed, 4 Jan 2017 14:48:33 +0000 (15:48 +0100)]
Fixed typo in comment
Change-Id: I58dba2018a20c34537222ba7711a39c75855be52
WMDE-Fisch [Wed, 4 Jan 2017 11:54:45 +0000 (12:54 +0100)]
Fix var name in ApiUpload
Found via phan.
Change-Id: I38b35db6b83d0728bcc8e0990f646b7d331cab13
Amir Sarabadani [Wed, 4 Jan 2017 10:22:25 +0000 (13:52 +0330)]
Align fieldset borders with WikimediaUI color palette
Unnoticeable change
Bug: T152025
Change-Id: Ia7d7cc66f96af8d78a8c520c302287bf57da8629
jenkins-bot [Wed, 4 Jan 2017 04:42:25 +0000 (04:42 +0000)]
Merge "Avoid hardcoding cache and cache key in populateInterwiki.php"
Timo Tijhof [Wed, 4 Jan 2017 03:29:35 +0000 (19:29 -0800)]
phpunit: Use assertEquals(, $delta) in UserTest instead of greater/lessThan
Follows-up
9d8358e09.
Documented at
https://phpunit.de/manual/4.8/en/appendixes.assertions.html#appendixes.assertions.assertEquals
Change-Id: Id337626c069663883d6a4bde58432637d33eb8c0
jenkins-bot [Wed, 4 Jan 2017 03:29:49 +0000 (03:29 +0000)]
Merge "Make some replication logging more structured"
Timo Tijhof [Wed, 4 Jan 2017 03:00:10 +0000 (19:00 -0800)]
Avoid hardcoding cache and cache key in populateInterwiki.php
Follows-up
0ac10f3790.
Bug: T114577
Change-Id: I1f5fbc40adc66a673428e495be94fc8118d6e14f
jenkins-bot [Wed, 4 Jan 2017 02:29:46 +0000 (02:29 +0000)]
Merge "Avoid starting transactions in getHeartbeatData()"
Timo Tijhof [Wed, 4 Jan 2017 02:15:40 +0000 (18:15 -0800)]
parser: Update outdated comment about ImageGallery
Follows-up
f90634a6.
Change-Id: Ic17dc03cc37b85f222f3bb525e4cb39afc6f22ae
TTO [Wed, 4 Jan 2017 01:25:54 +0000 (01:25 +0000)]
Release notes for un-deprecation of WikiRevision::getText
This function was un-deprecated in
I3f0e0f7fe38bd4e2001efbe17cdba6bcc90b036f, mainly to stop Google
Code-In students from continually trying to remove the function before
we have decided what to do with it (see T152282).
Change-Id: I460c76f2dea89646545a969c3637433070059b1c
James D. Forrester [Wed, 4 Jan 2017 00:27:21 +0000 (16:27 -0800)]
Update OOjs UI to v0.18.3
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.18.3
Change-Id: I8f26c0024d44dd2bac2c19c869254a7154c4103e
C. Scott Ananian [Tue, 3 Jan 2017 21:47:59 +0000 (16:47 -0500)]
Revert "Protect language converter markup in the preprocessor."
This effectively reverts commit
28774022769d2273be16c6c6e1cca710a1fd97ef in
order to unblock the deploy train. The underlying behavior might not be
incorrect, but it was unexpected.
Bug: T153761
Change-Id: Ifc9c7cf3482dd5d222ff4da24a6d4cc401e9d965
jenkins-bot [Tue, 3 Jan 2017 21:00:45 +0000 (21:00 +0000)]
Merge "Cleanup after Iba0138a6"
jenkins-bot [Tue, 3 Jan 2017 20:58:47 +0000 (20:58 +0000)]
Merge "tests: mock should not __clone Database"
jenkins-bot [Tue, 3 Jan 2017 20:47:06 +0000 (20:47 +0000)]
Merge "ApiSandbox: Display params as JSON on request page"
jenkins-bot [Tue, 3 Jan 2017 20:27:47 +0000 (20:27 +0000)]
Merge "DateTimeInputWidget: Only show calendar when focusing date components, not time components"
Brad Jorsch [Tue, 3 Jan 2017 19:55:12 +0000 (14:55 -0500)]
Cleanup after Iba0138a6
Iba0138a6 removed the custom error handler in Hooks::run(), but didn't
remove the comment describing it and left behind an unused variable.
Change-Id: I9b043fa8bd79625e63d35f95f2fa3ac1b214275c
Brad Jorsch [Tue, 3 Jan 2017 19:23:32 +0000 (14:23 -0500)]
ApiClearHasMsg: Clean up after I341b395e
Since I341b395e, $this->getRequest()->wasPosted() should never be false.
So don't bother testing for it.
Change-Id: Iccc60424ed5442d950f4968297fdd18001b3a02a
jenkins-bot [Tue, 3 Jan 2017 16:54:45 +0000 (16:54 +0000)]
Merge "tests: speed up fetchTextTest"
Antoine Musso [Tue, 3 Jan 2017 16:46:29 +0000 (17:46 +0100)]
tests: mock should not __clone Database
The Database __clone relies on a connLogger which is set in the
constructor.
However, when creating a mock of Database, PHPUnit 5.x does a __clone
which uses a connLogger. That leads to a fatal error.
The sole caller is FileBackendDBRepoWrapperTest, have its mock to skip
invoking __clone().
Change-Id: I2ee3b561104bdacc0232ba5e90b3eae3fbaa6f8f
addshore [Tue, 3 Jan 2017 16:25:52 +0000 (16:25 +0000)]
Add missing QueryAllSpecialPagesTest $queryPages property
Change-Id: Ic19e1b5f656599ed1dc06818403a0a8bca8004b7
Amir Sarabadani [Tue, 3 Jan 2017 15:59:16 +0000 (19:29 +0330)]
Proper instantiating of QueryPage special pages in QueryAllSpecialPagesTest
Change-Id: If4420067011da756b8a36917f1c35fd2d380dae9
jenkins-bot [Tue, 3 Jan 2017 15:21:50 +0000 (15:21 +0000)]
Merge "Remove unused static methods in LanguageConverter subclasses"
jenkins-bot [Tue, 3 Jan 2017 15:15:58 +0000 (15:15 +0000)]
Merge "Do not try to change directory when running Phan tests with no params"
Subin Siby [Tue, 3 Jan 2017 14:35:34 +0000 (20:05 +0530)]
Disable statistics update on import with maintenance/importDump.php
Disable updating statistics in importDump.php to quickly finish imports from command line.
Bug: T144600
Change-Id: Ib827c068fb20cc03aab47e3106d489f18be1dac6
Antoine Musso [Tue, 3 Jan 2017 14:39:27 +0000 (15:39 +0100)]
tests: speed up fetchTextTest
The test is adding/resetting database data on every tests, however it is
not necessary.
Switch from addDBData to addDBDataOnce.
Drop the tablesUsed[] additions, they are not needed and trigger a
resetDB().
Change the textId### variables tracking created revisions to static
variables so they are kept between tests.
On my setup the test run time goes down from 1.7 sec to 0.5 sec.
Change-Id: Ibd3183b7fbf7dcf2c0c6d1268e1b94b11919cbf3