nadeesha [Thu, 30 Dec 2010 09:07:23 +0000 (09:07 +0000)]
Added 'LINK_DIV' variable
nadeesha [Thu, 30 Dec 2010 08:37:01 +0000 (08:37 +0000)]
Added two variables 'LINK_FORM' and 'LINK_RIGHT_FRAMEWORK'
Alexandre Emsenhuber [Thu, 30 Dec 2010 07:24:41 +0000 (07:24 +0000)]
Fix for r79231: $dbname was missing
Sam Reed [Thu, 30 Dec 2010 03:00:45 +0000 (03:00 +0000)]
Remove another usage of extract()
Sam Reed [Thu, 30 Dec 2010 02:56:36 +0000 (02:56 +0000)]
No magic variables are used after this extract call. All done $defaults['blah']. Hence remove extract call
Sam Reed [Thu, 30 Dec 2010 02:48:27 +0000 (02:48 +0000)]
Extract sucks
Wrap long line
Sam Reed [Thu, 30 Dec 2010 02:45:28 +0000 (02:45 +0000)]
Followup r79229, fix varible type fail
Sam Reed [Thu, 30 Dec 2010 02:44:26 +0000 (02:44 +0000)]
Add function return type hint to wfGetLBFactory
More parameter documentation to CloneDatabase
Sam Reed [Thu, 30 Dec 2010 02:41:20 +0000 (02:41 +0000)]
Array to array
Add some function documentation
Sam Reed [Thu, 30 Dec 2010 00:56:30 +0000 (00:56 +0000)]
Per CR on r68482, fix adss to add
Also remove trailing whitespace in files
Roan Kattouw [Wed, 29 Dec 2010 22:30:07 +0000 (22:30 +0000)]
Fix r79213: and $ts === null too, per CR
Roan Kattouw [Wed, 29 Dec 2010 22:28:26 +0000 (22:28 +0000)]
Followup r71751: change strict comparison to loose per CR, and add a comment explaining why
Raimond Spekking [Wed, 29 Dec 2010 20:54:05 +0000 (20:54 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-29 20:34:00 UTC)
Bryan Tong Minh [Wed, 29 Dec 2010 20:32:14 +0000 (20:32 +0000)]
Follow-up to r75282: don't query if there are no pages to query
Roan Kattouw [Wed, 29 Dec 2010 20:20:55 +0000 (20:20 +0000)]
Followup r78824: add missing message
Chad Horohoe [Wed, 29 Dec 2010 18:37:08 +0000 (18:37 +0000)]
Fix example per r78832 CR
Chad Horohoe [Wed, 29 Dec 2010 17:15:46 +0000 (17:15 +0000)]
Followup r78823: just remove the offending line entirely
Chad Horohoe [Wed, 29 Dec 2010 17:03:07 +0000 (17:03 +0000)]
Tweak comment
Platonides [Wed, 29 Dec 2010 16:45:16 +0000 (16:45 +0000)]
Follow up r79183 removing global added in r79154
Platonides [Wed, 29 Dec 2010 16:42:46 +0000 (16:42 +0000)]
(Bug 26458) Section edit links appear on pages that user does not have right to edit (
X! [Wed, 29 Dec 2010 16:40:31 +0000 (16:40 +0000)]
Self-reverting my reversion of r79154 in r79158. The old version is flawed and broken beyond belief. At least this version works.
Platonides [Wed, 29 Dec 2010 16:24:59 +0000 (16:24 +0000)]
Replace the global $additionalMWCLIArgs with a class variable.
Provide a default value for verbose since it is checked regardless of existance.
Platonides [Wed, 29 Dec 2010 16:15:23 +0000 (16:15 +0000)]
Follow up r67663. Now with 100% less sugar, er.. @s!
Platonides [Wed, 29 Dec 2010 15:52:07 +0000 (15:52 +0000)]
Move MediaWikiTestCase class to a new file and load it from phpunit.php
This restores the ability to run single tests with
php phpunit.php includes/filename.php
Platonides [Wed, 29 Dec 2010 15:21:25 +0000 (15:21 +0000)]
Follow up r79107 for old PHPUnit versions.
Platonides [Wed, 29 Dec 2010 15:15:56 +0000 (15:15 +0000)]
Don't error no matter if the article exists or not.
Change the parent to MediaWikiTestCase.
Platonides [Wed, 29 Dec 2010 15:11:44 +0000 (15:11 +0000)]
Fix the DELETE FROM `unittest_objectcache` WHERE keyname = 'my_wiki-unittest_:user:id:1 error
Platonides [Wed, 29 Dec 2010 15:08:29 +0000 (15:08 +0000)]
Follow up r79173. Pass the parameters in the right order.
Platonides [Wed, 29 Dec 2010 15:01:47 +0000 (15:01 +0000)]
Follow up r79109.
Don't setup/destroy for databaseless tests.
Make needsDB() return based on the DocComment.
Delayed db init until the test is run, so that it isn't set for excluded tests (the exclusion is done after all the classes are instantiated).
Bryan Tong Minh [Wed, 29 Dec 2010 11:57:52 +0000 (11:57 +0000)]
Add main contributors in SpecialVersion to README and index.php as well
X! [Wed, 29 Dec 2010 05:38:11 +0000 (05:38 +0000)]
-Set configuration automatically if not set. This allows for evasion of the makefile, ergo, more control.
-Remove instances of @covers; they were breaking code-coverage
X! [Wed, 29 Dec 2010 03:35:17 +0000 (03:35 +0000)]
Partial revert of r79154. hexmode asserts that these work, even though I keep getting OK (0 tests, 0 assertions)
X! [Wed, 29 Dec 2010 02:23:51 +0000 (02:23 +0000)]
Make MediaWikiParserTest work now in PHPUnit. There are still a few bugs, such as stopping tests if one fails,
lack of fuzz testing and other parser test options, and the DB creation is still a little flaky.
A MediaWikiPHPUnitCommand class had to be created to allow for custom CLI parameters.
OverlordQ [Tue, 28 Dec 2010 22:26:45 +0000 (22:26 +0000)]
Followup to r79094, PG handles temporary tables correctly so you dont need to do cleanup
Chad Horohoe [Tue, 28 Dec 2010 22:20:01 +0000 (22:20 +0000)]
Fix hardcoded debugging from r79093
Raimond Spekking [Tue, 28 Dec 2010 20:55:53 +0000 (20:55 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-27 20:57:00 UTC)
Jack Phoenix [Tue, 28 Dec 2010 20:46:12 +0000 (20:46 +0000)]
add Roan to Special:Version credits
X! [Tue, 28 Dec 2010 19:27:34 +0000 (19:27 +0000)]
Add test to supplement Bug 26425 (followup to r79013)
X! [Tue, 28 Dec 2010 19:12:27 +0000 (19:12 +0000)]
Add BlockTest unit test
X! [Tue, 28 Dec 2010 18:47:09 +0000 (18:47 +0000)]
NewDBTest does not need the function anymore.
Fixed bug that caused a catchable fatal error (fix from r79117)
Platonides [Tue, 28 Dec 2010 18:44:32 +0000 (18:44 +0000)]
Fix bug 14404. The articles are now always saved with the default options.
Most importantily, articles with {{int:X}} will now have consistent table
links no matter the language of the last saving user.
Existing articles with broken tables will be updated on a null edit (a purge is not enough).
Test added in r79121.
Platonides [Tue, 28 Dec 2010 18:43:49 +0000 (18:43 +0000)]
Add failing test for bug 14404.
X! [Tue, 28 Dec 2010 18:30:03 +0000 (18:30 +0000)]
Fix r79109: listTables() does not work without a prefix, and verified that SQLite works now
Chad Horohoe [Tue, 28 Dec 2010 18:23:43 +0000 (18:23 +0000)]
Add @covers annotations to IP tests
Chad Horohoe [Tue, 28 Dec 2010 18:17:16 +0000 (18:17 +0000)]
* verbose and color default output from phpunit
* Make a bunch of tests subclass MediaWikiTestCase
* Parser tests and ResourceLoaderTest can't subclass it yet due to various issues
Platonides [Tue, 28 Dec 2010 18:16:46 +0000 (18:16 +0000)]
Play safe and clear the article object internals, too (eg. mTouched).
Platonides [Tue, 28 Dec 2010 18:15:48 +0000 (18:15 +0000)]
This precondition is no longer needed after r78393
X! [Tue, 28 Dec 2010 18:10:18 +0000 (18:10 +0000)]
Followup to r79109: Use a clean DB by default for each test
Chad Horohoe [Tue, 28 Dec 2010 17:51:07 +0000 (17:51 +0000)]
Followup r79112: missed one rename
Chad Horohoe [Tue, 28 Dec 2010 17:45:33 +0000 (17:45 +0000)]
Rename MediaWikiTestSetup to MediaWikiTestCase: this is going to be the base class for all unit tests from now on
X! [Tue, 28 Dec 2010 17:15:50 +0000 (17:15 +0000)]
It's here! It's finally here! The skies are falling, pigs have sprouted wings, and it's pretty cold in hell!
-Add a working PHPUnit test that instantiates a new DB, adds set data, and deleted when done.
-Add listTables() to the Database classes (only MySql and SQLite use it, and only MySQL is tested)
Platonides [Tue, 28 Dec 2010 15:54:51 +0000 (15:54 +0000)]
Set $wgAdaptiveMessageCache for parserTests until NikeRabbit fixes r78179
X! [Tue, 28 Dec 2010 15:13:42 +0000 (15:13 +0000)]
assertType() is deprecated, switching usages tp assertInternalType() and assertInstanceOf()
Niklas Laxström [Tue, 28 Dec 2010 09:54:25 +0000 (09:54 +0000)]
Follow up r23393, also remove the getter method
Shinjiman [Tue, 28 Dec 2010 09:30:48 +0000 (09:30 +0000)]
Localisation updates Cantonese, Chinese and Literary Chinese
X! [Tue, 28 Dec 2010 04:08:25 +0000 (04:08 +0000)]
Wrong URL in README
Chad Horohoe [Tue, 28 Dec 2010 01:22:38 +0000 (01:22 +0000)]
Nitpick r79094: fix var names
Chad Horohoe [Tue, 28 Dec 2010 01:19:16 +0000 (01:19 +0000)]
Followup r79093: Move DROP TABLE code to Database classes and properly rename back to original table prefix in destroyDatabase()
Chad Horohoe [Tue, 28 Dec 2010 00:44:16 +0000 (00:44 +0000)]
Refactor table cloning code into its own class so it can maybe be used by things other than the parser tests
Krinkle [Mon, 27 Dec 2010 23:23:55 +0000 (23:23 +0000)]
* Follow-up r79087. Applying to other skins that have similar article styling in relation to headings and thumbs.
* Follow-up r79086. Fixing margin (I shouldn't have added the numbers, caused the margins to be a litle bigger then they were, now they're the same as before the border>margin change)
Chad Horohoe [Mon, 27 Dec 2010 23:02:13 +0000 (23:02 +0000)]
Comment out "subscribe to mediawiki-l" feature until we actually implement it. I'd really like to see this working, but we need to build some sort of API for Mailman.
Raimond Spekking [Mon, 27 Dec 2010 21:17:44 +0000 (21:17 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-27 20:57:00 UTC)
Krinkle [Mon, 27 Dec 2010 20:53:11 +0000 (20:53 +0000)]
Adding overflow:hidden to heading elements in Vector.
This has been tested in Vector in a large number of browsers to not have side effects and only making the underline no longer shine through transparent borders or margins of thumbs.
Also, due to float clearing abilities of overflow:hidden (it's all over the internet) this also causes the editsection link to no longer be stacked down (see en.wiki WP:BUNCH), see bug 26449.
Krinkle [Mon, 27 Dec 2010 20:45:07 +0000 (20:45 +0000)]
Room around thumbs should be margin, not a transparent border.
.tleft / .tright { border-width: 0.5em 0 0.8em 1.4em; }
becomes: "margin: 0.5em 0 0.8em 1.4em;"
adding ".thumb margin-bottom: 0.5em;" becomes: "margin: 0.5em 0 1.3em 1.4em;"
* Related to r79010
Happy-melon [Mon, 27 Dec 2010 20:02:10 +0000 (20:02 +0000)]
Follow-up r79084: synchronise keys.
Happy-melon [Mon, 27 Dec 2010 19:50:51 +0000 (19:50 +0000)]
Follow-up r79083: Fix notices on TW.
Happy-melon [Mon, 27 Dec 2010 19:07:28 +0000 (19:07 +0000)]
Refactoring in RecentChanges/Watchlist:
* Use new jQuery/RL collapsible implementation, remove legacy JS.
* Refactor ChangesList::flag() and ChangesList::recentChangesFlags(), the latter to now take an array rather than a growing list of out-of-order parameters.
* Resolve the FIXME requested in r44421 (just passed its second birthday :D) by replacing extract() calls with direct references.
Platonides [Mon, 27 Dec 2010 18:56:31 +0000 (18:56 +0000)]
If running against the grid, there's no need to start and stop the server in localhost.
Platonides [Mon, 27 Dec 2010 18:55:41 +0000 (18:55 +0000)]
Remove debugging var_dump, add , in message.
Platonides [Mon, 27 Dec 2010 18:53:29 +0000 (18:53 +0000)]
Get rid of a different configuration file syntax for PHP 5.2
Directly parse them in php.
Krinkle [Mon, 27 Dec 2010 17:37:19 +0000 (17:37 +0000)]
Treat premade toggle links as a custom instead of default case (ie. dont change the text) (Follow-up r78989 CR)
Platonides [Mon, 27 Dec 2010 17:17:45 +0000 (17:17 +0000)]
(Bug 26434) - Generated password from "Create account by email" does not work.
Another consequence of the $ts === 0 from r71751.
Fixed in a more verbose way. Behavior documented in tables.sql
Sam Reed [Mon, 27 Dec 2010 16:56:50 +0000 (16:56 +0000)]
*(bug 26404) Enable call graphs for doxygen-generated doc
Platonides [Mon, 27 Dec 2010 16:51:59 +0000 (16:51 +0000)]
Replace __METHOD__ with __FUNCTION__
Using a title like testParse instead of ExtraParserTest::testParse (thus without colons),
means that it doesn't need to be checked if it's an interwiki, and no interwiki db (either Cdb or normal db) is needed.
So these tests can be run as Databaseless.
Krinkle [Mon, 27 Dec 2010 16:43:50 +0000 (16:43 +0000)]
The toggle link may be in any of the cells of the first row. The default will stick to the last cell but when detecting premade links, it now scans the entire first row instead of just the last cell.
Sam Reed [Mon, 27 Dec 2010 16:29:44 +0000 (16:29 +0000)]
One would hope we have no .php3 files left laying around
Chad Horohoe [Mon, 27 Dec 2010 15:41:11 +0000 (15:41 +0000)]
Move setup_plpgsql() to PostgresInstaller and make it use status objects for when the rest of this is moved over too
Tobias [Mon, 27 Dec 2010 14:21:56 +0000 (14:21 +0000)]
Special:Permalink as alias for Special:PermanentLink (added in r79036)
Chad Horohoe [Mon, 27 Dec 2010 13:56:20 +0000 (13:56 +0000)]
* Followup r78450: just use selectField() instead of pg_fetch_result() with a raw doQuery()
* Remove useless isset() check, this will always be set with some default in DefaultSettings.php
Daniel Friesen [Mon, 27 Dec 2010 12:23:06 +0000 (12:23 +0000)]
Commit getPersonalTools to allow personal bar generation to be simplified.
nadeesha [Mon, 27 Dec 2010 10:49:25 +0000 (10:49 +0000)]
Adding README file for the Installer testing
nadeesha [Mon, 27 Dec 2010 10:43:18 +0000 (10:43 +0000)]
Updated the copyright section
nadeesha [Mon, 27 Dec 2010 10:34:17 +0000 (10:34 +0000)]
Remove 'str_replace('//','/',' from the require_once( str_replace('//','/',dirname(__FILE__).'/') .'MediaWikiInstallationCommonFunction.php');
nadeesha [Mon, 27 Dec 2010 07:34:57 +0000 (07:34 +0000)]
Adding MediaWiki installer test scripts and installer directory
nadeesha [Mon, 27 Dec 2010 07:22:08 +0000 (07:22 +0000)]
Deleting installer directory to have a fresh commit
Brion Vibber [Mon, 27 Dec 2010 03:21:43 +0000 (03:21 +0000)]
* bug 26437: fix for Sanitizer::decodeCharReferences converting invalid hex character references
Patch by Umherirrender: https://bugzilla.wikimedia.org/attachment.cgi?id=7931&action=edit
Also added a parser regression test case: "HTML Hex character encoding bogus encoding (bug 26437 regression check)"
Happy-melon [Mon, 27 Dec 2010 00:07:41 +0000 (00:07 +0000)]
Follow-up r79036: update comment.
Happy-melon [Mon, 27 Dec 2010 00:03:35 +0000 (00:03 +0000)]
(bug 268) add Special:PermanentLink/### as an internally-linkable redirect to index.php?oldid=###.
Also refactor SpecialPage::getRedirectQuery() to return an associative array to pass to wfArrayToCGI(), rather than bodging the query string together internally.
Platonides [Sun, 26 Dec 2010 22:55:32 +0000 (22:55 +0000)]
Revert r75588 and r77381. Block just the tainted pairs of username/passwords until a proper solution for weak passwords is added, hopefully for 1.18.
Platonides [Sun, 26 Dec 2010 22:24:55 +0000 (22:24 +0000)]
When running phpunit with globals backup, $skinsInitialised will be kept to true, but $wgValidSkinNames reset to an empty array. Workarounding.
Brion Vibber [Sun, 26 Dec 2010 22:01:26 +0000 (22:01 +0000)]
Thumbnail previews for PNG, JPEG, GIF, and SVG files on Special:Upload in browsers supporting HTML 5 FileAPI
Known good:
* Firefox 3.6+
* Chrome 7.something+
Krinkle [Sun, 26 Dec 2010 20:41:08 +0000 (20:41 +0000)]
adding hoverIntent plugin
Brion Vibber [Sun, 26 Dec 2010 20:39:21 +0000 (20:39 +0000)]
Throw an exception instead of low-level PHP fatal error if something invokes the Exif() class when exif functions aren't actually present. (Discovered with PagedTiffHandler enabled on my test machine.)
Raimond Spekking [Sun, 26 Dec 2010 20:38:54 +0000 (20:38 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-26 20:27:00 UTC)
Ryan Lane [Sun, 26 Dec 2010 19:45:01 +0000 (19:45 +0000)]
Adding maintenance script to purge stale flagged revs entries from memcached (for entries that have rev idsin the key). Should be made more generic.
Platonides [Sun, 26 Dec 2010 19:30:10 +0000 (19:30 +0000)]
Document parser, add test cases for the external entry points to it.
Platonides [Sun, 26 Dec 2010 19:23:11 +0000 (19:23 +0000)]
Remove ParserOptions clonations, already cloned in getParserOptions().
Ref r70783
Platonides [Sun, 26 Dec 2010 19:21:45 +0000 (19:21 +0000)]
Store the options used by the parsing in ParserOutput, per r70783 CR.
Daniel Friesen [Sun, 26 Dec 2010 14:15:27 +0000 (14:15 +0000)]
Changing the skin loader to load classes using the pattern "Skin{$skinName}" instead of `"Skin" . ucfirst($key)` as the current behavior has been causing bugs with extension based skins attempting to use the autoloader to load their skins.
Under current behavior for "MonoBook" the skin loader will load "SkinMonobook" instead of "SkinMonoBook". Because the skin system loads from skins/ when it can't find a skin and php's class system is case insensitive by a fluke MonoBook has been fine despite the skin loader trying to load SkinMonobook despite the class being named SkinMonoBook.
However our autoloader is case-sensitive, and as a result if you try to name your extension based skin class something like SkinStereoBook the skin will break with a cryptic error message because the skin loader attempts to load SkinStereobook, doesn't find it in the autoloader, then throws a php error when it tries to load skins/StereoBook.php and can't find the file.
We have also been using the $skinName to generate the name of the file to load from skins/ so this value is already expected to be safe for use in this way.
Daniel Friesen [Sun, 26 Dec 2010 13:45:13 +0000 (13:45 +0000)]
Back out getPersonalTools from r79014 which did not belong in that commit.