Chad Horohoe [Tue, 6 Jul 2010 20:56:37 +0000 (20:56 +0000)]
Remove a few functions that have been labelled deprecated forever and have no callers anywhere
Chad Horohoe [Tue, 6 Jul 2010 20:44:48 +0000 (20:44 +0000)]
Revert r69005 (adding valid_tag to parsertest tables). Not sure what freaky magic was going on, can't seem to replicate
Ævar Arnfjörð Bjarmason [Tue, 6 Jul 2010 20:40:05 +0000 (20:40 +0000)]
new-installer: Delay database object construction until ->execute time
My method of putting code that alters $this->parent->installSteps in
the MySQL constructor didn't work because the installer will construct
objects for all the databases, even those it doesn't use.
This ostensibly happens because it needs to be able to provide
defaults for all of them on the DBConnect page.
But when I was going to fix that by exiting the MySQL constructior by
checking $wgDBtype I found that it didn't work, because WebInstaller
calls Installer's __construct *before* any sessions are read or set
up, so $wgDBtype will always be mysql, since that's the default.
Fix that by delaying the construction of the database objects. The
WebInstaller (or equivalent) now has to call ->setupDatabaseObjects()
in its ->execute method. This way the defaults on the DBConnect will
still be provided, but we'll have access to session data in the
database constructors.
Ughed-by: Chad <innocentkiller@gmail.com>
Chad Horohoe [Tue, 6 Jul 2010 19:06:44 +0000 (19:06 +0000)]
Followup r69007, use $wgDeletedDirectory since it exists now
Chad Horohoe [Tue, 6 Jul 2010 18:57:06 +0000 (18:57 +0000)]
Disable installer when LocalSettings.php is detected
Chad Horohoe [Tue, 6 Jul 2010 18:31:55 +0000 (18:31 +0000)]
Refactor installation into parent class, shouldn't be up to children to implement. Have the child pass callbacks to be done at beginning and end of stages for output
Chad Horohoe [Tue, 6 Jul 2010 14:42:06 +0000 (14:42 +0000)]
Also add a box around warnings like errors
Chad Horohoe [Tue, 6 Jul 2010 14:41:15 +0000 (14:41 +0000)]
Turn getStatusErrorBox() into getStatusBox() so it can handle warnings too
Chad Horohoe [Tue, 6 Jul 2010 14:31:43 +0000 (14:31 +0000)]
Make this public again, MysqlInstaller uses it :(
Sam Reed [Tue, 6 Jul 2010 13:15:59 +0000 (13:15 +0000)]
Stylize API
Add a few braces
Philip Tzou [Tue, 6 Jul 2010 07:29:41 +0000 (07:29 +0000)]
Follow up r69081. Use wfEmptyMsg() rather than the ugly comparison.
Philip Tzou [Tue, 6 Jul 2010 06:59:52 +0000 (06:59 +0000)]
Bug 24027: Variants like "zh" should get purged as others.
Philip Tzou [Tue, 6 Jul 2010 05:00:15 +0000 (05:00 +0000)]
1. Fix the underline bug in the title(namespace) conversion, which displayed title like "User_talk:Example".
2. Improve the function of namespace conversion. Allow admins to custom namespace conversion in MediaWiki's messages([[MediaWiki:conversion-nsX]]).
Philip Tzou [Tue, 6 Jul 2010 03:06:31 +0000 (03:06 +0000)]
Bug 24072: The manual conversion of title was taken interferes by other manual conversion rule(s). This patch fixed the problem and add a new test to parserTests.txt to prevent it to reappear again.
Raimond Spekking [Mon, 5 Jul 2010 21:51:11 +0000 (21:51 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-05 21:20:00 UTC)
Jack Phoenix [Mon, 5 Jul 2010 20:45:20 +0000 (20:45 +0000)]
removed TablePager CSS from Modern's main.css as shared.css already contains that and Modern includes shared.css. Also merged two .TablePager rules into one in shared.css and updated comments
Jack Phoenix [Mon, 5 Jul 2010 20:40:09 +0000 (20:40 +0000)]
cleanup to CSS files (spaces -> tabs for indentation, trimmed trailing spaces, updated a few comments)
Max Semenik [Mon, 5 Jul 2010 20:31:01 +0000 (20:31 +0000)]
Removed sysopRequired() and developerRequired() from OutputPage. Even junkiest extensions don't use them anymore, thanks to exceptions they've been throwing for the last 4 years.
Max Semenik [Mon, 5 Jul 2010 19:47:46 +0000 (19:47 +0000)]
Got rid of remaining usages of immediateBegin()/immediateCommit(), marked these functions with wfDeprecated()
Alexandre Emsenhuber [Mon, 5 Jul 2010 09:14:29 +0000 (09:14 +0000)]
Fixed some doxygen warnings
Philip Tzou [Mon, 5 Jul 2010 05:18:08 +0000 (05:18 +0000)]
Update the Chinese conversion tables.
Chad Horohoe [Mon, 5 Jul 2010 00:29:38 +0000 (00:29 +0000)]
Make visibilities actually mean it
Chad Horohoe [Mon, 5 Jul 2010 00:06:06 +0000 (00:06 +0000)]
Not the parent, use this
Ævar Arnfjörð Bjarmason [Sun, 4 Jul 2010 22:11:20 +0000 (22:11 +0000)]
LocalSettingsGenerator: Document $wgLanguageCode in the generated LocalSettings.php
Ævar Arnfjörð Bjarmason [Sun, 4 Jul 2010 22:11:18 +0000 (22:11 +0000)]
LocalSettingsGenerator: Document $wgDiff3 in the generated LocalSettings.php
Ævar Arnfjörð Bjarmason [Sun, 4 Jul 2010 22:11:14 +0000 (22:11 +0000)]
LocalSettingsGenerator: Align the few assignments in the generated LocalSettings.php that weren't aligned
This makes the generated code prettier and easier to read.
Ævar Arnfjörð Bjarmason [Sun, 4 Jul 2010 21:25:16 +0000 (21:25 +0000)]
new-installer: A better implementation of the database user creation added in r69008
Since MysqlInstaller isn't in the same class hierarchy as WebInstaller
the database user functions I added in r69008 messed up the namespace
for non-MySQL, and added redundant user creation messages to
e.g. SQLite, which doesn't even have users.
Instead support either a plain string in $installSteps, or an array
that has callback data that'll be called with call_user_func_array.
The implementation is a bit ad-hoc, we should probably move the magic
in Hooks.php's wfRunHooks to some general library function so we can
use that here, or perhaps just implement these installSteps with
something like:
$wgHook['Installer::steps'][] = array(...)
And then use wfRunHooks to run all the steps. But in the meantime
this'll do.
This breaks the nascent CliInstaller (indicating that we should do
these calls better), and I haven't added the equivalent functionality
to $envChecks.
Alexandre Emsenhuber [Sun, 4 Jul 2010 20:43:58 +0000 (20:43 +0000)]
Removed error suppression opertators (per bug 24159)
Ævar Arnfjörð Bjarmason [Sun, 4 Jul 2010 19:44:21 +0000 (19:44 +0000)]
new-installer: Use `` instead of wfShellExec() like the old installer
This avoids runnin into the memory limitation of ulimit.sh when
auto-detecting if programs exist during installation. On my 64 bit
Debian system calling e.g. diff3 --version takes more than the default
10MB memory limit.
Can be reproduced as:
<?php
require 'maintenance/commandLine.inc';
$var = wfShellExec("/usr/bin/diff3 --version 2>&1");
echo "<$var>\n";
?>
Which on my system gives you:
php test.php
/home/avar/g/phase3/bin/ulimit4.sh: xmalloc: ../bash/variables.c:3446: cannot allocate 1270 bytes (53248 bytes allocated)
<>
The old installer just did ``, revert to this behavior until we raise
the default memory limit, or find some workaround for this issue.
Chad Horohoe [Sun, 4 Jul 2010 19:41:26 +0000 (19:41 +0000)]
Add LocalSettings checker thing. Haven't used it in the UI yet and the needsUpgrade() probably doesn't work right yet :)
Raimond Spekking [Sun, 4 Jul 2010 18:55:14 +0000 (18:55 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-04 18:27:00 UTC)
Ævar Arnfjörð Bjarmason [Sun, 4 Jul 2010 16:40:28 +0000 (16:40 +0000)]
new-installer: Return newGood() from CreateDBAccount if we're not creating an account
This unbreaks the installation when we're not creating a user, broken
in my last commit.
Max Semenik [Sun, 4 Jul 2010 16:35:33 +0000 (16:35 +0000)]
Revert r64063, will use a different approach for selected languages later
Ævar Arnfjörð Bjarmason [Sun, 4 Jul 2010 16:16:28 +0000 (16:16 +0000)]
new-installer: GRANT permissions to our new non-root user by sourcing users.sql
The old installer sourced maintenance/users.sql to create a new
non-root user if requested. Do that in the new installer as well.
So far this only works on MySQL, but I'm adding a generic setupUser
function on the assumption that other databases (except SQLite) want
to do some sort of user setup.
Chad Horohoe [Sun, 4 Jul 2010 15:56:46 +0000 (15:56 +0000)]
Deprecated $wgFileStore in favor of $wgDeletedDirectory. Included b/c code for wikis with $wgFileStore still set
Chad Horohoe [Sun, 4 Jul 2010 15:29:52 +0000 (15:29 +0000)]
Add valid_tag to list of tables for parsertests. Mine seemed to need it
Ævar Arnfjörð Bjarmason [Sun, 4 Jul 2010 15:03:13 +0000 (15:03 +0000)]
new-installer: Don't use some made-up $host:$ip for memcached in an example, but 127.0.0.1:11211 which is the default
Alexandre Emsenhuber [Sun, 4 Jul 2010 14:41:26 +0000 (14:41 +0000)]
Fixed some doxygen warnings
Alexandre Emsenhuber [Sun, 4 Jul 2010 14:38:34 +0000 (14:38 +0000)]
* Modified Special:Ipblocklist to subclass SpecialPage instead of using wfSpecialIblocklist()
* Changed some calls from Xml:: to Html::
* Coding style
Rotem Liss [Sun, 4 Jul 2010 14:03:33 +0000 (14:03 +0000)]
Localization update for he.
Alexandre Emsenhuber [Sun, 4 Jul 2010 12:24:13 +0000 (12:24 +0000)]
Added alias for 'Badtitle' so that it stops throwing warnings when accessing a "Bad title" page
Danny B [Sun, 4 Jul 2010 11:39:32 +0000 (11:39 +0000)]
* Fixing (sub)section names - they can't have the same name, because they are used as id's in HTML.
Platonides [Sun, 4 Jul 2010 11:16:52 +0000 (11:16 +0000)]
Make the "E-mail notification about changes" options fit at the right into a 1024 width screen.
Alexandre Emsenhuber [Sun, 4 Jul 2010 10:21:59 +0000 (10:21 +0000)]
Remove array( ... ) from SpecialMypage, SpecialMytalk and SpecialMycontributions for consistency with other special pages
Rotem Liss [Sat, 3 Jul 2010 21:53:03 +0000 (21:53 +0000)]
Localization update for he.
Alexandre Emsenhuber [Sat, 3 Jul 2010 21:09:25 +0000 (21:09 +0000)]
Fixed some doxygen warnings
Alexandre Emsenhuber [Sat, 3 Jul 2010 20:35:32 +0000 (20:35 +0000)]
Two error suppression opertators less (per bug 24159)
Raimond Spekking [Sat, 3 Jul 2010 19:51:54 +0000 (19:51 +0000)]
Follow-up r68904: Rename 'ImagePage.css' to 'Filepage.css': More generic name and CamelCase in messages keys is uncommon
Add 'Filepage.css' to MessagesEn.php to be sure that the message is shown on Special:AllMessages
Raimond Spekking [Sat, 3 Jul 2010 19:15:49 +0000 (19:15 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-03 18:40:00 UTC)
Alexandre Emsenhuber [Sat, 3 Jul 2010 18:39:20 +0000 (18:39 +0000)]
Modified Special:Filepath to subclass SpecialPage; also changed some calls from Xml:: to Html::
Shinjiman [Sat, 3 Jul 2010 15:28:33 +0000 (15:28 +0000)]
Localisation updates Cantonese, Chinese and Literary Chinese
Alexandre Emsenhuber [Sat, 3 Jul 2010 14:33:09 +0000 (14:33 +0000)]
* document new hooks
* fixed quotes
Alexandre Emsenhuber [Sat, 3 Jul 2010 13:37:49 +0000 (13:37 +0000)]
Fix E_STRICT about different function signature
Max Semenik [Sat, 3 Jul 2010 06:32:37 +0000 (06:32 +0000)]
(bug 24244) Updated comments in DefaultSettings.php to reflect Image: --> File: namespace rename.
Max Semenik [Sat, 3 Jul 2010 06:06:02 +0000 (06:06 +0000)]
New installer: fixed fatal exception due to attempted DB access from User::loadOptions()
Alexandre Emsenhuber [Fri, 2 Jul 2010 22:07:13 +0000 (22:07 +0000)]
Removed trailing spaces
Andrew Garrett [Fri, 2 Jul 2010 21:40:47 +0000 (21:40 +0000)]
Remove double-wrapping in trs
Alexandre Emsenhuber [Fri, 2 Jul 2010 21:35:27 +0000 (21:35 +0000)]
Added /maintenance/tests to the directory list
Alexandre Emsenhuber [Fri, 2 Jul 2010 21:22:38 +0000 (21:22 +0000)]
Fixed some doxygen warnings
Andrew Garrett [Fri, 2 Jul 2010 21:20:54 +0000 (21:20 +0000)]
Add vertical-label option to HTMLForm, for CommunityHiring
Mark A. Hershberger [Fri, 2 Jul 2010 21:15:13 +0000 (21:15 +0000)]
* Eliminate CLIInstallerOutput per r68645 since, yes, it wasn't needed.
* Make sure output only happens in the top-level Installer implementations.
* Differentiate Status warning messages from Status error messages in the Installer.
* Change abstract method from Install::showStatusError() to Install::showStatusMessage() since we'll use it to show warnings now, too.
* TODO Need a better way to extract/display Status warning messages since, from my look at the Status class, it looks like warnings are implemented, but not really used.
Bryan Tong Minh [Fri, 2 Jul 2010 19:54:46 +0000 (19:54 +0000)]
(bug 24212) Added MediaWiki:ImagePage.css which is also included on foreign client wikis.
Raimond Spekking [Fri, 2 Jul 2010 19:30:05 +0000 (19:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-02 19:08:00 UTC)
Rotem Liss [Fri, 2 Jul 2010 19:22:44 +0000 (19:22 +0000)]
Localization update for he.
Alexandre Emsenhuber [Fri, 2 Jul 2010 19:10:36 +0000 (19:10 +0000)]
And one error suppression opertator less (per bug 24159)
Bryan Tong Minh [Fri, 2 Jul 2010 18:37:06 +0000 (18:37 +0000)]
* Added scriptExtension setting to $wgForeignFileRepos
* Added FileRepo::makeUrl() to remove code duplication
* Made ForeignApiRepo use scriptDirUrl if apiBase not set
* Factored out 'timestamp|user|comment|url|size|sha1|metadata|mime' to ForeignApiFile::getProps()
* Killed some @ error suppression
OverlordQ [Fri, 2 Jul 2010 17:22:37 +0000 (17:22 +0000)]
Followup to r66898, source correct patchfile
Aryeh Gregor [Fri, 2 Jul 2010 16:42:24 +0000 (16:42 +0000)]
Make escapenoentities work again, broken by r68801
Alexandre Emsenhuber [Fri, 2 Jul 2010 16:19:09 +0000 (16:19 +0000)]
Fixed E_STRICT for different function signature
Alexandre Emsenhuber [Fri, 2 Jul 2010 16:12:30 +0000 (16:12 +0000)]
Pass a title to DifferenceEngine's constructor so that it won't fall back to $wgTitle (Special:ComparePage) and produce invalid links
Alexandre Emsenhuber [Fri, 2 Jul 2010 15:57:58 +0000 (15:57 +0000)]
* Removed unused globals
* Fixed some whitespaces
* Use Html class instead of Xml when possible
* Make the page valid when using HTML5
Raimond Spekking [Fri, 2 Jul 2010 15:10:29 +0000 (15:10 +0000)]
Make the "Reason:" label consistent for all input forms, compare with translatewiki.net/wiki/Template:Identical/Reason for a list of all reason labels.
Max Semenik [Fri, 2 Jul 2010 14:04:39 +0000 (14:04 +0000)]
Special:ComparePages: output titles in a more human-readable form
Max Semenik [Fri, 2 Jul 2010 13:17:28 +0000 (13:17 +0000)]
Refactored Database*::getLag(): moved the default implementation to MySQL, replaced it with a proper dummy, deleted stub implementations from other classes. This adds fake lag support to all databases.
Derk-Jan Hartman [Fri, 2 Jul 2010 12:11:39 +0000 (12:11 +0000)]
(bug 24073) Recognize MS Office 2003 style files that have been saved by MS 2007.
These files have OPC trailers with 2007 specific information.
Max Semenik [Fri, 2 Jul 2010 10:01:09 +0000 (10:01 +0000)]
* Replaced the mess of every database class implementing filedExists() is its own way with one simple function in base class. Verified to work on MySQL, Postgres and SQLite.
* Fixed fieldInfo() on Postgres not using tableName() and thus failing for table user, for example.
* Made fieldInfo() on MySQL return false instead of throwing a query error if table does not exist. This is consistent with other databases' behaviour.
Sam Reed [Fri, 2 Jul 2010 06:52:20 +0000 (06:52 +0000)]
Remove some whitespace, and fixup if braces in postgres section of updaters.inc
Fix minor message typo also
Philip Tzou [Fri, 2 Jul 2010 04:16:46 +0000 (04:16 +0000)]
Update the Chinese conversion tables.
Alexandre Emsenhuber [Thu, 1 Jul 2010 20:45:21 +0000 (20:45 +0000)]
Fixed some doxygen warnings
Derk-Jan Hartman [Thu, 1 Jul 2010 19:57:26 +0000 (19:57 +0000)]
Make sure we use the right variable. Follow up r68848.
Derk-Jan Hartman [Thu, 1 Jul 2010 19:55:04 +0000 (19:55 +0000)]
(bug 24022) Don't check extensions of files in uploadpage script when $wgStrictFileExtensions == false
Raimond Spekking [Thu, 1 Jul 2010 19:37:00 +0000 (19:37 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-07-01 19:25:00 UTC)
Conrad Irwin [Thu, 1 Jul 2010 19:11:22 +0000 (19:11 +0000)]
texvc +\bcancel and \xcancel to make full use of the cancel package
Chad Horohoe [Thu, 1 Jul 2010 15:31:54 +0000 (15:31 +0000)]
Throw a wfDeprecated() on this since the last usage is gone in r68836
Chad Horohoe [Thu, 1 Jul 2010 13:43:05 +0000 (13:43 +0000)]
Followup r63389: remove useless CACHE_DB and confusing CACHE_ANYTHING from cache setup
Platonides [Thu, 1 Jul 2010 09:48:53 +0000 (09:48 +0000)]
(bug 16886) Sister projects box moves down the extract of the first result in IE 7.
Niklas Laxström [Thu, 1 Jul 2010 07:30:55 +0000 (07:30 +0000)]
Don't add confusing new lines to debug output, mark deprecated method
Sam Reed [Thu, 1 Jul 2010 06:28:30 +0000 (06:28 +0000)]
Add a couple of braces
Aryeh Gregor [Wed, 30 Jun 2010 23:08:49 +0000 (23:08 +0000)]
Use <!DOCTYPE html> unconditionally
See r67090 for context. Everywhere that I've found this breaking
well-formedness is fixed. Tested with the following Python:
import xml.sax
class Myhandler(xml.sax.ContentHandler):
pass
h = Myhandler()
for page in ('BrokenRedirects', 'Deadendpages', 'DoubleRedirects', 'Longpages', 'Ancientpages', 'Lonelypages', 'Fewestrevisions', 'Withoutinterwiki', 'Protectedpages', 'Protectedtitles', 'Shortpages', 'Uncategorizedcategories', 'Uncategorizedimages', 'Uncategorizedpages', 'Uncategorizedtemplates', 'Unusedcategories', 'Unusedimages', 'Unusedtemplates', 'Unwatchedpages', 'Wantedcategories', 'Wantedfiles', 'Wantedpages', 'Wantedtemplates', 'Allpages', 'Prefixindex', 'Categories', 'Disambiguations', 'Listredirects', 'Userlogin', 'CreateAccount', 'Blockip', 'Ipblocklist', 'Unblock', 'Resetpass', 'DeletedContributions', 'Preferences', 'Contributions', 'Listgrouprights', 'Listusers', 'Activeusers', 'Userrights', 'Newimages', 'Log', 'Watchlist', 'Newpages', 'Recentchanges', 'Recentchangeslinked', 'Tags', 'Listfiles', 'Filepath', 'MIMEsearch', 'FileDuplicateSearch', 'Upload', 'Statistics', 'Allmessages', 'Version', 'Lockdb', 'Unlockdb', 'LinkSearch', 'Randompage', 'Randomredirect', 'Mostlinkedcategories', 'Mostimages', 'Mostlinked', 'Mostlinkedtemplates', 'Mostcategories', 'Mostrevisions', 'ComparePages', 'Export', 'Import', 'Undelete', 'Whatlinkshere', 'MergeHistory', 'Booksources', 'Blankpage', 'Blockme', 'Emailuser', 'Listadmins', 'Listbots', 'Movepage', 'Mycontributions', 'Mypage', 'Mytalk', 'Revisiondelete', 'RevisionMove', 'Specialpages', 'Userlogout'):
xml.sax.parse("http://localhost/git-trunk/phase3/index.php?title=Special:" + page, h)
I had to manually skip some of these for unrelated reasons, but none of
them became malformed because of this commit. Also tested the main page
and Special:Random a bunch of separate times. There are probably other
well-formedness errors lurking, but they can be fixed as they're
reported.
Aryeh Gregor [Wed, 30 Jun 2010 23:08:41 +0000 (23:08 +0000)]
0="something" is not what we want here, we want id
Html should probably check for the case of missing keys in attributes.
Aryeh Gregor [Wed, 30 Jun 2010 23:08:31 +0000 (23:08 +0000)]
When using escapenoentities, decode entities
See r67090 for context. Maybe it would be better to alter
normalizeCharReferences() instead? I'm not sure where else it's called.
Adam Miller [Wed, 30 Jun 2010 22:20:18 +0000 (22:20 +0000)]
Vector - fix for bug 24190
Aryeh Gregor [Wed, 30 Jun 2010 22:14:36 +0000 (22:14 +0000)]
Disable form validation more thoroughly
Expands on r67283 by not using any HTML5 input types either, except
search. Otherwise you'd still have problems when changing integer
fields in Special:Preferences, say. Sad, since in Opera it had a cute
little widget for incrementing/decrementing, and types like email have
some neat effects on platforms like the iPhone (see
<http://diveintohtml5.org/forms.html#type-email>). But there's no other
way to disable the constraints these impose without using JS, and given
how broken WebKit is right now . . .
Aryeh Gregor [Wed, 30 Jun 2010 21:37:19 +0000 (21:37 +0000)]
Fix more grammar in r67360's comment
(see also r67401)
Raimond Spekking [Wed, 30 Jun 2010 18:02:40 +0000 (18:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-06-30 17:45:00 UTC)
Sam Reed [Wed, 30 Jun 2010 15:50:37 +0000 (15:50 +0000)]
Normalise # to // comments
Sam Reed [Wed, 30 Jun 2010 15:34:59 +0000 (15:34 +0000)]
Followup r65037, do the same for the other route of badtitle
Rotem Liss [Wed, 30 Jun 2010 14:42:44 +0000 (14:42 +0000)]
Localization update for he.
Roan Kattouw [Wed, 30 Jun 2010 10:44:51 +0000 (10:44 +0000)]
Fix r65069 per CR: put logo setting outside of block hidden when uploads are disabled
Niklas Laxström [Wed, 30 Jun 2010 07:42:43 +0000 (07:42 +0000)]
Mention the other supported accelerators