From: Aryeh Gregor Date: Tue, 24 Jul 2018 13:38:44 +0000 (+0300) Subject: Make OutputPage::mPagetitle private X-Git-Tag: 1.34.0-rc.0~4669^2 X-Git-Url: http://git.cyclocoop.org/%7B%24admin_url%7Dmes_infos.php?a=commitdiff_plain;h=dcb721dca4612594666025b56687c36ba18794fb;p=lhc%2Fweb%2Fwiklou.git Make OutputPage::mPagetitle private Code search revealed only one outside access, which I've submitted a patch for. Depends-On: I001deecad241b091070483d882088d2d6361ed5a Change-Id: I0f7e565f4eacc1074c619772b2d11a47a05e3584 --- diff --git a/includes/OutputPage.php b/includes/OutputPage.php index 5965cbe7c2..4e7c0bbe83 100644 --- a/includes/OutputPage.php +++ b/includes/OutputPage.php @@ -55,9 +55,8 @@ class OutputPage extends ContextSource { protected $mCanonicalUrl = false; /** - * @var string Should be private - has getter and setter. Contains - * the HTML title */ - public $mPagetitle = ''; + * @var string The contents of

*/ + private $mPageTitle = ''; /** * @var string Contains all of the "" content. Should be private we @@ -992,7 +991,7 @@ class OutputPage extends ContextSource { # change "" to "<script>foo&bar</script>" # but leave "foobar" alone $nameWithTags = Sanitizer::normalizeCharReferences( Sanitizer::removeHTMLtags( $name ) ); - $this->mPagetitle = $nameWithTags; + $this->mPageTitle = $nameWithTags; # change "foo&bar" to "foo&bar" $this->setHTMLTitle( @@ -1007,7 +1006,7 @@ class OutputPage extends ContextSource { * @return string */ public function getPageTitle() { - return $this->mPagetitle; + return $this->mPageTitle; } /**