From: Aaron Schulz <aschulz@wikimedia.org>
Date: Mon, 19 Mar 2018 23:20:15 +0000 (-0700)
Subject: rdbms: clean up DBO_TRX behavior for onTransactionPreCommitOrIdle()
X-Git-Tag: 1.31.0-rc.0~316^2
X-Git-Url: http://git.cyclocoop.org/%7B%24admin_url%7Dmes_infos.php?a=commitdiff_plain;h=b0ee0a8d9f1190740894b4e846bfd83fa6a90de1;hp=b0ee0a8d9f1190740894b4e846bfd83fa6a90de1;p=lhc%2Fweb%2Fwiklou.git

rdbms: clean up DBO_TRX behavior for onTransactionPreCommitOrIdle()

* Make sure cancelled onTransactionPreCommitOrIdle() callbacks do not
  run if a transaction round is rolled back and then a second round is
  committed. LoadBalancer::rollbackMasterChanges() now always calls
  rollback(), which in turn always cleans up such callbacks.
* Remove error logging for rollback() calls when trxLevel = 0; this is
  harmless and is sometimes hard to avoid in error handling anyway.
* Add more related unit tests.

Change-Id: I6bdefe8bf8b6630fc252b5bbafe4808758ba1684
---