Merge "ChangesListSpecialPage: Don't short-circuit the ChangesList, instead format...

diff --combined includes/specialpage/ChangesListSpecialPage.php
index 8c4cc11,eb431a4..b85d272
--- 1/includes/specialpage/ChangesListSpecialPage.php
--- 2/includes/specialpage/ChangesListSpecialPage.php
+++ b/includes/specialpage/ChangesListSpecialPage.php
@@@ -22,6 -22,7 +22,7 @@@
   */
  use MediaWiki\Logger\LoggerFactory;
  use Wikimedia\Rdbms\ResultWrapper;
+ use Wikimedia\Rdbms\FakeResultWrapper;
  use Wikimedia\Rdbms\IDatabase;
  
  /**
@@@ -518,13 -519,7 +519,7 @@@ abstract class ChangesListSpecialPage e
                $rows = $this->getRows();
                $opts = $this->getOptions();
                if ( $rows === false ) {
-                       if ( !$this->including() ) {
-                               $this->doHeader( $opts, 0 );
-                               $this->outputNoResults();
-                               $this->getOutput()->setStatusCode( 404 );
-                       }
- 
-                       return;
+                       $rows = new FakeResultWrapper( [] );
                }
  
                $batch = new LinkBatch;
@@@ -1287,14 -1282,9 +1282,14 @@@
                $legend .= Html::closeElement( 'dl' ) . "\n";
  
                # Collapsibility
 +              $legendHeading = $this->getUser()->getOption(
 +                      'rcenhancedfilters'
 +              ) ?
 +                      $context->msg( 'rcfilters-legend-heading' )->parse() :
 +                      $context->msg( 'recentchanges-legend-heading' )->parse();
                $legend =
                        '<div class="mw-changeslist-legend">' .
 -                              $context->msg( 'recentchanges-legend-heading' )->parse() .
 +                              $legendHeading .
                                '<div class="mw-collapsible-content">' . $legend . '</div>' .
                        '</div>';