From 6c2621fefc744f36c84275a46f55c3ed70bb9baf Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Fri, 22 Sep 2017 00:10:45 +0100 Subject: [PATCH] mw.loader: Simplify getVersion and getState This undefined check no longer makes sense since there are now defaults for these in register(). There is no supported scenario in which a module would have a key in the registry but not have these properties defined, or have them defined with the undefined value. Change-Id: I945871861ccf3659c2d7dd021aa87dfd747f22b9 --- resources/src/mediawiki/mediawiki.js | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js index b5224867d2..7e02df4f8d 100644 --- a/resources/src/mediawiki/mediawiki.js +++ b/resources/src/mediawiki/mediawiki.js @@ -2123,10 +2123,7 @@ * in the registry. */ getVersion: function ( module ) { - if ( !hasOwn.call( registry, module ) || registry[ module ].version === undefined ) { - return null; - } - return registry[ module ].version; + return hasOwn.call( registry, module ) ? registry[ module ].version : null; }, /** @@ -2137,10 +2134,7 @@ * in the registry. */ getState: function ( module ) { - if ( !hasOwn.call( registry, module ) || registry[ module ].state === undefined ) { - return null; - } - return registry[ module ].state; + return hasOwn.call( registry, module ) ? registry[ module ].state : null; }, /** -- 2.20.1