From fc19d2ab033ff197b355c34ef132ad2a9d29bffc Mon Sep 17 00:00:00 2001 From: Umherirrender Date: Fri, 1 Feb 2019 20:59:16 +0100 Subject: [PATCH] Add missing @covers to database related tests Change-Id: I370275bb6c5d456b73f6a5f782e231f16c2b0fbe --- tests/phpunit/includes/db/DatabaseSqliteTest.php | 3 +++ .../includes/libs/rdbms/database/DatabaseMysqlBaseTest.php | 2 +- .../phpunit/includes/libs/rdbms/database/DatabaseSQLTest.php | 5 +++++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/tests/phpunit/includes/db/DatabaseSqliteTest.php b/tests/phpunit/includes/db/DatabaseSqliteTest.php index eebb045948..e61bd05a67 100644 --- a/tests/phpunit/includes/db/DatabaseSqliteTest.php +++ b/tests/phpunit/includes/db/DatabaseSqliteTest.php @@ -474,6 +474,9 @@ class DatabaseSqliteTest extends MediaWikiTestCase { return $indexes; } + /** + * @coversNothing + */ public function testCaseInsensitiveLike() { // TODO: Test this for all databases $db = DatabaseSqlite::newStandaloneInstance( ':memory:' ); diff --git a/tests/phpunit/includes/libs/rdbms/database/DatabaseMysqlBaseTest.php b/tests/phpunit/includes/libs/rdbms/database/DatabaseMysqlBaseTest.php index b7dbe0bd6e..4c92545128 100644 --- a/tests/phpunit/includes/libs/rdbms/database/DatabaseMysqlBaseTest.php +++ b/tests/phpunit/includes/libs/rdbms/database/DatabaseMysqlBaseTest.php @@ -672,7 +672,7 @@ class DatabaseMysqlBaseTest extends PHPUnit\Framework\TestCase { $this->assertSame( 'CAST( fieldName AS SIGNED )', $output ); } - /* + /** * @covers Wikimedia\Rdbms\Database::setIndexAliases */ public function testIndexAliases() { diff --git a/tests/phpunit/includes/libs/rdbms/database/DatabaseSQLTest.php b/tests/phpunit/includes/libs/rdbms/database/DatabaseSQLTest.php index 4a9603c816..d1d1aa3338 100644 --- a/tests/phpunit/includes/libs/rdbms/database/DatabaseSQLTest.php +++ b/tests/phpunit/includes/libs/rdbms/database/DatabaseSQLTest.php @@ -740,6 +740,10 @@ class DatabaseSQLTest extends PHPUnit\Framework\TestCase { ]; } + /** + * @covers Wikimedia\Rdbms\Database::insertSelect + * @covers Wikimedia\Rdbms\Database::nativeInsertSelect + */ public function testInsertSelectBatching() { $dbWeb = new DatabaseTestHelper( __CLASS__, [ 'cliMode' => false ] ); $rows = []; @@ -1874,6 +1878,7 @@ class DatabaseSQLTest extends PHPUnit\Framework\TestCase { /** * @expectedException \Wikimedia\Rdbms\DBTransactionStateError + * @covers \Wikimedia\Rdbms\Database::assertTransactionStatus */ public function testTransactionErrorState1() { $wrapper = TestingAccessWrapper::newFromObject( $this->database ); -- 2.20.1