From ed1b8d3a0e685e5199ac564c417933890d71776b Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Fri, 10 Jul 2015 00:54:40 -0700 Subject: [PATCH] Upgraded User::saveSettings logged errors to exceptions * This gives more visibility and the error rate is not extreme (and mostly affects certain users due to usage patterns). Change-Id: I3eae28a584e4db8ae40ae80087a97c416b3bd3e8 --- includes/User.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/includes/User.php b/includes/User.php index 63c0d37e45..005fc7d41f 100644 --- a/includes/User.php +++ b/includes/User.php @@ -3679,12 +3679,10 @@ class User implements IDBAccessObject { $this->clearSharedCache(); // User was changed in the meantime or loaded with stale data $from = ( $this->queryFlagsUsed & self::READ_LATEST ) ? 'master' : 'slave'; - MWExceptionHandler::logException( new MWException( + throw new MWException( "CAS update failed on user_touched for user ID '{$this->mId}' (read from $from);" . "the version of the user to be saved is older than the current version." - ) ); - - return; + ); } $this->mTouched = $newTouched; -- 2.20.1