From cd8de7de779b20f0794f00954873dda0b47e6f87 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Thu, 4 Jul 2019 19:38:58 +0200 Subject: [PATCH] PreferencesFormOOUI: Avoid Phan warning with weird signature of TabPanelLayout TabPanelLayout is documented to take two parameters, $name and $config. The $name position parameter can also be passed as a named config option in the $config array, but doing so confuses Phan, since there's no good way to document it. Just don't do it. Bug: T227144 Change-Id: Ifbd776844d722d58bf9f13cacc490407320731c6 --- includes/specials/forms/PreferencesFormOOUI.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/includes/specials/forms/PreferencesFormOOUI.php b/includes/specials/forms/PreferencesFormOOUI.php index 9b86812dfa..5dae156993 100644 --- a/includes/specials/forms/PreferencesFormOOUI.php +++ b/includes/specials/forms/PreferencesFormOOUI.php @@ -146,9 +146,8 @@ class PreferencesFormOOUI extends OOUIHTMLForm { ) . $this->getFooterText( $key ); - $tabPanels[] = new OOUI\TabPanelLayout( [ + $tabPanels[] = new OOUI\TabPanelLayout( 'mw-prefsection-' . $key, [ 'classes' => [ 'mw-htmlform-autoinfuse-lazy' ], - 'name' => 'mw-prefsection-' . $key, 'label' => $label, 'content' => new OOUI\FieldsetLayout( [ 'classes' => [ 'mw-prefs-section-fieldset' ], -- 2.20.1