From 2de2e056a8badc40ee7b282b7929c019953b4f45 Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Sun, 2 Jun 2019 20:58:58 -0400 Subject: [PATCH] Use ExtensionRegistry::setAttributeForTest() instead of Reflection Change-Id: If29e8825f1734f8c0efa21aa77f6354fa3468248 --- .../ResourceLoaderOOUIImageModuleTest.php | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/tests/phpunit/includes/resourceloader/ResourceLoaderOOUIImageModuleTest.php b/tests/phpunit/includes/resourceloader/ResourceLoaderOOUIImageModuleTest.php index ff09660faa..5df52bc422 100644 --- a/tests/phpunit/includes/resourceloader/ResourceLoaderOOUIImageModuleTest.php +++ b/tests/phpunit/includes/resourceloader/ResourceLoaderOOUIImageModuleTest.php @@ -25,20 +25,9 @@ class ResourceLoaderOOUIImageModuleTest extends ResourceLoaderTestCase { ); $this->setService( 'SkinFactory', $skinFactory ); - $r = new ReflectionMethod( ExtensionRegistry::class, 'exportExtractedData' ); - $r->setAccessible( true ); - $r->invoke( ExtensionRegistry::getInstance(), [ - 'globals' => [], - 'defines' => [], - 'callbacks' => [], - 'credits' => [], - 'autoloaderPaths' => [], - 'attributes' => [ - 'SkinOOUIThemes' => [ - 'fakemonobook' => 'Apex', - ], - ], - ] ); + $reset = ExtensionRegistry::getInstance()->setAttributeForTest( + 'SkinOOUIThemes', [ 'fakemonobook' => 'Apex' ] + ); $styles = $module->getStyles( $this->getResourceLoaderContext( [ 'skin' => 'fakemonobook' ] ) ); $this->assertRegExp( -- 2.20.1