From 209a8778a0f43d7b7ff5b32c3525a4e225d1be4c Mon Sep 17 00:00:00 2001 From: Umherirrender Date: Fri, 1 Feb 2019 20:53:33 +0100 Subject: [PATCH] Add missing @covers to revision related tests Change-Id: Id95369208e988c16d626ca6f986898e3e84e8565 --- .../includes/Revision/RevisionStoreFactoryTest.php | 4 ++++ .../phpunit/includes/Revision/RevisionStoreTest.php | 12 ++++++++++++ 2 files changed, 16 insertions(+) diff --git a/tests/phpunit/includes/Revision/RevisionStoreFactoryTest.php b/tests/phpunit/includes/Revision/RevisionStoreFactoryTest.php index 2e61745d22..138d6bcba1 100644 --- a/tests/phpunit/includes/Revision/RevisionStoreFactoryTest.php +++ b/tests/phpunit/includes/Revision/RevisionStoreFactoryTest.php @@ -23,6 +23,9 @@ use Wikimedia\TestingAccessWrapper; class RevisionStoreFactoryTest extends MediaWikiTestCase { + /** + * @covers \MediaWiki\Revision\RevisionStoreFactory::__construct + */ public function testValidConstruction_doesntCauseErrors() { new RevisionStoreFactory( $this->getMockLoadBalancerFactory(), @@ -49,6 +52,7 @@ class RevisionStoreFactoryTest extends MediaWikiTestCase { /** * @dataProvider provideWikiIds + * @covers \MediaWiki\Revision\RevisionStoreFactory::getRevisionStore */ public function testGetRevisionStore( $wikiId, diff --git a/tests/phpunit/includes/Revision/RevisionStoreTest.php b/tests/phpunit/includes/Revision/RevisionStoreTest.php index efc2952856..c4b274dd6a 100644 --- a/tests/phpunit/includes/Revision/RevisionStoreTest.php +++ b/tests/phpunit/includes/Revision/RevisionStoreTest.php @@ -146,6 +146,9 @@ class RevisionStoreTest extends MediaWikiTestCase { $this->assertSame( $contentHandlerDb, $store->getContentHandlerUseDB() ); } + /** + * @covers \MediaWiki\Revision\RevisionStore::getTitle + */ public function testGetTitle_successFromPageId() { $mockLoadBalancer = $this->getMockLoadBalancer(); // Title calls wfGetDB() so we have to set the main service @@ -177,6 +180,9 @@ class RevisionStoreTest extends MediaWikiTestCase { $this->assertSame( 'Food', $title->getDBkey() ); } + /** + * @covers \MediaWiki\Revision\RevisionStore::getTitle + */ public function testGetTitle_successFromPageIdOnFallback() { $mockLoadBalancer = $this->getMockLoadBalancer(); // Title calls wfGetDB() so we have to set the main service @@ -233,6 +239,9 @@ class RevisionStoreTest extends MediaWikiTestCase { $this->assertSame( 'Foodey', $title->getDBkey() ); } + /** + * @covers \MediaWiki\Revision\RevisionStore::getTitle + */ public function testGetTitle_successFromRevId() { $mockLoadBalancer = $this->getMockLoadBalancer(); // Title calls wfGetDB() so we have to set the main service @@ -278,6 +287,9 @@ class RevisionStoreTest extends MediaWikiTestCase { $this->assertSame( 'Food2', $title->getDBkey() ); } + /** + * @covers \MediaWiki\Revision\RevisionStore::getTitle + */ public function testGetTitle_successFromRevIdOnFallback() { $mockLoadBalancer = $this->getMockLoadBalancer(); // Title calls wfGetDB() so we have to set the main service -- 2.20.1