Don't generate a diff link in the patrol log if the page doesn't exist, it'll be...

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 26a32fa..6eb63f4 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -123,6 +123,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
   warns of possible bad values
 * (bug 9978) Fixed session.save_path validation when using extended
   configuration format, e.g. "5;/tmp"
+* Don't generate a diff link in the patrol log if the page doesn't exist
 
 == MediaWiki API changes since 1.10 ==
 

diff --git a/includes/PatrolLog.php b/includes/PatrolLog.php
index 157dcbd..cb6de3e 100644 (file)
--- a/includes/PatrolLog.php
+++ b/includes/PatrolLog.php
@@ -49,11 +49,16 @@ class PatrolLog {
                        list( $cur, /* $prev */, $auto ) = $params;
                        # Standard link to the page in question
                        $link = $skin->makeLinkObj( $title );
-                       # Generate a diff link
-                       $bits[] = 'oldid=' . urlencode( $cur );
-                       $bits[] = 'diff=prev';
-                       $bits = implode( '&', $bits );
-                       $diff = $skin->makeLinkObj( $title, htmlspecialchars( wfMsg( 'patrol-log-diff', $cur ) ), $bits );
+                       if( $title->exists() ) {
+                               # Generate a diff link
+                               $bits[] = 'oldid=' . urlencode( $cur );
+                               $bits[] = 'diff=prev';
+                               $bits = implode( '&', $bits );
+                               $diff = $skin->makeKnownLinkObj( $title, htmlspecialchars( wfMsg( 'patrol-log-diff', $cur ) ), $bits );
+                       } else {
+                               # Don't bother with a diff link, it's useless
+                               $diff = htmlspecialchars( wfMsg( 'patrol-log-diff', $cur ) );
+                       }
                        # Indicate whether or not the patrolling was automatic
                        $auto = $auto ? wfMsgHtml( 'patrol-log-auto' ) : '';
                        # Put it all together