externalstore: Fix insert*() return docs and remove redundant checks
authorDaimona Eaytoy <daimona.wiki@gmail.com>
Mon, 7 Jan 2019 10:18:39 +0000 (11:18 +0100)
committerKrinkle <krinklemail@gmail.com>
Thu, 13 Jun 2019 18:23:23 +0000 (18:23 +0000)
commitf5eaf6470bfb32f9632bee9d0ac09b57b9fc9af0
treef32470c8a28058cca1c042f5f89669d069b07d3a
parent699920cc66790c3f5675ffa340c361950ee6225f
externalstore: Fix insert*() return docs and remove redundant checks

ExternalStorage::insertWithFallback is reported to return false on
failure, but it doesn't. It has a single exit point, and return value is
checked with strlen(), so actually it can only return the URL or throw.
Thus, update any related doc and remove a redundant check from code
calling insertToDefault.

Change-Id: Ic95c3aed19118b987aef105f8077d55558f39127
includes/Storage/SqlBlobStore.php
includes/externalstore/ExternalStore.php
includes/externalstore/ExternalStoreDB.php
includes/externalstore/ExternalStoreMwstore.php
maintenance/migrateArchiveText.php