From b853f0e14d7ba9c47e93bf8aaf9b6f56554104ab Mon Sep 17 00:00:00 2001 From: Geoffrey Mon Date: Sat, 1 Aug 2015 21:15:58 +0000 Subject: [PATCH] Use XmlSelect in SpecialListusers Bug: T93234 Change-Id: I25cdd8f7eb1bbfd893d201f6c68f5ccfabe70bf3 --- includes/specials/SpecialListusers.php | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/includes/specials/SpecialListusers.php b/includes/specials/SpecialListusers.php index 56c4eb506f..9e7dc00923 100644 --- a/includes/specials/SpecialListusers.php +++ b/includes/specials/SpecialListusers.php @@ -285,13 +285,14 @@ class UsersPager extends AlphabeticPager { ) . ' '; # Group drop-down list - $out .= Xml::label( $this->msg( 'group' )->text(), 'group' ) . ' ' . - Xml::openElement( 'select', array( 'name' => 'group', 'id' => 'group' ) ) . - Xml::option( $this->msg( 'group-all' )->text(), '' ); + $sel = new XmlSelect( 'group', 'group', $this->requestedGroup ); + $sel->addOption( $this->msg( 'group-all' )->text(), '' ); foreach ( $this->getAllGroups() as $group => $groupText ) { - $out .= Xml::option( $groupText, $group, $group == $this->requestedGroup ); + $sel->addOption( $groupText, $group ); } - $out .= Xml::closeElement( 'select' ) . '
'; + + $out .= Xml::label( $this->msg( 'group' )->text(), 'group' ) . ' '; + $out .= $sel->getHTML() . '
'; $out .= Xml::checkLabel( $this->msg( 'listusers-editsonly' )->text(), 'editsOnly', -- 2.20.1