Kunal Mehta [Thu, 28 Dec 2017 08:25:25 +0000 (00:25 -0800)]
Remove useless StatusTest::testCanConstruct()
Neither Status, nor StatusValue have constructors, so there's not much
point testing whether the object can be constructed.
Change-Id: I170940889b5da5198ef4576d04786f84c293dd01
Translation updater bot [Thu, 28 Dec 2017 08:04:14 +0000 (09:04 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Icc11f7ae67c7a70f4c59eec632c74926700a69c9
jenkins-bot [Wed, 27 Dec 2017 22:04:37 +0000 (22:04 +0000)]
Merge "phpunit: Remove outdated comment about calling of LinkCache::clear()"
jenkins-bot [Wed, 27 Dec 2017 21:39:36 +0000 (21:39 +0000)]
Merge "mw.rcfilters.ui.SaveFiltersPopupButtonWidget: Remove pointless option"
jenkins-bot [Wed, 27 Dec 2017 21:14:54 +0000 (21:14 +0000)]
Merge "Add grep comment for js vars wgRestriction*"
Timo Tijhof [Wed, 27 Dec 2017 20:52:44 +0000 (21:52 +0100)]
phpunit: Remove outdated comment about calling of LinkCache::clear()
This is actually being called now, from resetDB() between tests.
Change-Id: I5aa15ce3fd57b6fc90b424fde8691ff33c7ddf45
Kunal Mehta [Mon, 25 Dec 2017 01:35:00 +0000 (17:35 -0800)]
Add tests for TextboxBuilder
Change-Id: I305e0bce902fb027bf02cc8a28e8846808f6437c
Kunal Mehta [Mon, 25 Dec 2017 01:08:48 +0000 (17:08 -0800)]
Add @covers tags to ContentHandler tests
Change-Id: I4d0994e91f63a0921343f34ef81a82463b4ab969
Kunal Mehta [Mon, 25 Dec 2017 04:06:06 +0000 (20:06 -0800)]
Add @covers tags to jobqueue tests
Change-Id: I030634ac87139011e5b3d461064a8c10f10cea84
Kunal Mehta [Mon, 25 Dec 2017 04:05:52 +0000 (20:05 -0800)]
Add @covers tags to HTMLForm test
Change-Id: I41cc4867b071ee9a58a43760fc4a8b301cda558e
Kunal Mehta [Mon, 25 Dec 2017 04:05:41 +0000 (20:05 -0800)]
Add @covers tags to filerepo tests
Change-Id: I696e03f9ab3934b6cd04e88e1d611060846d32a4
Kunal Mehta [Mon, 25 Dec 2017 04:04:47 +0000 (20:04 -0800)]
Add @covers tags to LinksUpdate test
Change-Id: I65ebce434f00a42e06be5168acbaa8fbf637995f
Kunal Mehta [Mon, 25 Dec 2017 04:04:36 +0000 (20:04 -0800)]
Add @covers tags to includes/debug tests
Change-Id: Ida6562c87204f1680239d0bdbfde4d6fdc9bf748
Kunal Mehta [Mon, 25 Dec 2017 04:04:11 +0000 (20:04 -0800)]
Add @covers tags for RevisionStoreDbTest
Change-Id: Ie7ce23d5ad67816c1ae8c2c838f8263fca17b4f8
jenkins-bot [Wed, 27 Dec 2017 17:40:44 +0000 (17:40 +0000)]
Merge "Add @covers tags to miscellaneous tests"
jenkins-bot [Wed, 27 Dec 2017 17:36:14 +0000 (17:36 +0000)]
Merge "Add @covers tags to utils tests"
jenkins-bot [Wed, 27 Dec 2017 17:36:11 +0000 (17:36 +0000)]
Merge "Add @covers tags to user tests"
jenkins-bot [Wed, 27 Dec 2017 17:30:27 +0000 (17:30 +0000)]
Merge "Add @covers tags to specials tests"
jenkins-bot [Wed, 27 Dec 2017 17:27:02 +0000 (17:27 +0000)]
Merge "Add @covers tags to parser tests"
jenkins-bot [Wed, 27 Dec 2017 17:26:59 +0000 (17:26 +0000)]
Merge "Add @covers tags to page tests"
jenkins-bot [Wed, 27 Dec 2017 17:19:57 +0000 (17:19 +0000)]
Merge "Add @covers tags to objectcache tests"
jenkins-bot [Wed, 27 Dec 2017 17:19:28 +0000 (17:19 +0000)]
Merge "Add @covers tags to media tests"
jenkins-bot [Wed, 27 Dec 2017 17:19:25 +0000 (17:19 +0000)]
Merge "Add @covers tags to logging tests"
Thiemo Mättig [Wed, 27 Dec 2017 11:40:19 +0000 (12:40 +0100)]
Document "arrays of UserGroupMembership objects" as such
Change-Id: I3c60fb977a329e39933d50e275a738296bc17599
jenkins-bot [Wed, 27 Dec 2017 12:51:53 +0000 (12:51 +0000)]
Merge "Simplify ApiQueryRecentChangesIntegrationTest"
jenkins-bot [Wed, 27 Dec 2017 12:33:27 +0000 (12:33 +0000)]
Merge "Integration tests for ApiQueryRecentChanges"
Thiemo Mättig [Wed, 27 Dec 2017 12:23:17 +0000 (13:23 +0100)]
Simplify ApiQueryRecentChangesIntegrationTest
This patch does two major things to the newly introduced
ApiQueryRecentChangesIntegrationTest:
* It rips the confusingly complicated assertArraySubsetsEqual appart.
* It removes all wikitext content. Note that no assertion is done on this
content (not even in the test that is about adding a category). The tests
run just fine with automatically generated content. I had to introduce the
$i counter to make sure consecutive edits are done with different content.
Otherwise the later edit is not stored.
Change-Id: Iae585be86f3fd9bff7d2b4b7b218d5b0b4258603
James D. Forrester [Mon, 27 Nov 2017 23:44:40 +0000 (15:44 -0800)]
resources: Upgrade jquery.chosen from 0.9.14 to 1.8.2
Change-Id: If9c720ebca8ca663869d0f73b0cd3ea415262cff
Thiemo Mättig [Wed, 27 Dec 2017 11:33:38 +0000 (12:33 +0100)]
Fix inconsistent capitalization of different method calls
Change-Id: I9f5b9e59e8cdadf65e80077fe2d3a9822b4592fe
Umherirrender [Wed, 27 Dec 2017 02:04:45 +0000 (03:04 +0100)]
Add grep comment for js vars wgRestriction*
Change-Id: I974841acf97e9426ed2338f210821e91d7f94286
jenkins-bot [Wed, 27 Dec 2017 10:38:08 +0000 (10:38 +0000)]
Merge "Special:ProtectedPages: Use HTMLForm"
Prateek Saxena [Fri, 8 Sep 2017 12:57:07 +0000 (22:57 +1000)]
Special:ProtectedPages: Use HTMLForm
We could easily get rid of functions like getExpiryCheck
and getCascadeCheck if required.
Bug: T117722
Change-Id: Ia964192b50464ebec00e0812e14b804fe91132ca
Translation updater bot [Wed, 27 Dec 2017 09:01:20 +0000 (10:01 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I9f3aca4cca70f4e0d747eeec0020948298cc14fc
Translation updater bot [Tue, 26 Dec 2017 09:00:05 +0000 (10:00 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I495ab349530db87303fc33f06b2610681ba3efc5
Kunal Mehta [Mon, 25 Dec 2017 03:13:51 +0000 (19:13 -0800)]
tests: Use checkPHPExtension() instead of re-implementing it
Change-Id: I7f5e8684d556befc0aefa302187c573e7a3cff62
Kunal Mehta [Mon, 25 Dec 2017 03:10:14 +0000 (19:10 -0800)]
Add @covers tags for Collation tests
Change-Id: I8b0623a6b716acdc9d369349fd4e306dbdc91d18
Amir Sarabadani [Mon, 25 Dec 2017 02:41:49 +0000 (03:41 +0100)]
Integration tests for ApiQueryRecentChanges
It looks big but it's mostly copy from ApiQueryWatchlistIntegrationTest
Change-Id: I96ccd3e2813e77f47a4432ca434c1c6a212d90ea
Translation updater bot [Mon, 25 Dec 2017 08:31:53 +0000 (09:31 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I69b50503f8a9db7b3883f664f2703ab16f9132dc
Kunal Mehta [Mon, 25 Dec 2017 07:28:03 +0000 (23:28 -0800)]
Add @covers tags to miscellaneous tests
Change-Id: I7e65c1734aef01cd6395ee65204a0158d1635b0c
Kunal Mehta [Mon, 25 Dec 2017 07:27:22 +0000 (23:27 -0800)]
Add @covers tags to utils tests
Change-Id: Iee44762696120c63fec986de1da76f12849f5957
Kunal Mehta [Mon, 25 Dec 2017 07:27:12 +0000 (23:27 -0800)]
Add @covers tags to user tests
Change-Id: I9ec5644e6b780937492eb5e0ea9e27ebad15ad43
Kunal Mehta [Mon, 25 Dec 2017 07:27:02 +0000 (23:27 -0800)]
Add @covers tags to specials tests
Change-Id: I626155b890580af38c09795b2b31f625fe942358
Kunal Mehta [Mon, 25 Dec 2017 07:26:52 +0000 (23:26 -0800)]
Add @covers tags to parser tests
Change-Id: I7bce04bef5e981fd203ad819882482e72ca3f61b
Kunal Mehta [Mon, 25 Dec 2017 07:26:41 +0000 (23:26 -0800)]
Add @covers tags to page tests
Change-Id: Iadb7e8697e9992ca281b7dfe70cf832c82e194de
Kunal Mehta [Mon, 25 Dec 2017 07:26:26 +0000 (23:26 -0800)]
Add @covers tags to objectcache tests
Change-Id: I5db623a582a0424f50d939aaa14fe29da9358b4f
Kunal Mehta [Mon, 25 Dec 2017 07:26:10 +0000 (23:26 -0800)]
Add @covers tags to media tests
Change-Id: Ibd3439f677dec5177b53317f113ed2aa8ddc2633
Kunal Mehta [Mon, 25 Dec 2017 07:26:01 +0000 (23:26 -0800)]
Add @covers tags to logging tests
Change-Id: Ibb14291a75423ddbb7502a5a0ee24ff0c554a876
jenkins-bot [Mon, 25 Dec 2017 03:27:42 +0000 (03:27 +0000)]
Merge "Allow fallbacks for $wgReferrerPolicy"
Kunal Mehta [Mon, 25 Dec 2017 03:16:26 +0000 (19:16 -0800)]
Fix @covers in XmlTest
Follows up
389fa13ff875.
Change-Id: I32ddf37b24a6b5162b383260233d616cb49f7ddb
Amir Sarabadani [Mon, 25 Dec 2017 01:54:25 +0000 (02:54 +0100)]
Add tests for several methods of Xml
Added tests for methods: monthSelector, span, buildTable, buildTableRow
Change-Id: I5ca6bb231b5ed95f57f649a92d659245a4852c85
jenkins-bot [Sun, 24 Dec 2017 23:42:56 +0000 (23:42 +0000)]
Merge "[MCR] Don't require $title to be passed to Revision::newFromId"
jenkins-bot [Sun, 24 Dec 2017 23:39:58 +0000 (23:39 +0000)]
Merge "[MCR] Introduce BlobStoreFactory"
jenkins-bot [Sun, 24 Dec 2017 23:38:57 +0000 (23:38 +0000)]
Merge "Add `margin-bottom` for editButtons (EditPage)"
Kunal Mehta [Sun, 24 Dec 2017 23:23:49 +0000 (15:23 -0800)]
Add @covers tags to CategoriesRdfTest
Change-Id: I6e2eae3fc2ac722dc94bee1a7aa6632e08a4d097
addshore [Sat, 23 Dec 2017 17:14:28 +0000 (17:14 +0000)]
[MCR] Introduce BlobStoreFactory
This allows Revision::getRevisionText to get
a different BlobStore instance when $wiki is passed in
restoring the behaviour for $wiki before the MCR Revision
overhaul patch was merged.
Ia4c20a91e98df0b9b14b138eb4825c55e5200384
Bug: T183634
Bug: T183631
bug: T183583
Change-Id: Ib0949454e9a003c2965adc1aab38e31fcf121afe
Gergő Tisza [Sat, 23 Dec 2017 17:35:59 +0000 (09:35 -0800)]
Allow fallbacks for $wgReferrerPolicy
For browsers that support older versions of the Referrer Policy
specification (Edge and Safari), using a value from a newer version of
the specification will result in those browsers falling back to a
default of "default".
So allow $wgReferrerPolicy to have fallbacks if the browser does not
recognize the currently set value. It will emit <meta> tags for each
value in the array, but in reverse order, as browsers will use the last
one that they recognize.
Bug: T180921
Change-Id: Ie0f523fc6937c9ecffc8a6fc791c6b54d5a1cb06
jenkins-bot [Sun, 24 Dec 2017 22:56:00 +0000 (22:56 +0000)]
Merge "Improve documentation of $wgReferrerPolicy"
jenkins-bot [Sun, 24 Dec 2017 21:57:01 +0000 (21:57 +0000)]
Merge "JavaScriptMinifier: Improve docs around parsing of regexp literals"
jenkins-bot [Sun, 24 Dec 2017 21:54:45 +0000 (21:54 +0000)]
Merge "JavaScriptMinifier: Remove support for unused $statementsOnOwnLine flag"
Timo Tijhof [Fri, 22 Dec 2017 18:00:42 +0000 (19:00 +0100)]
JavaScriptMinifier: Improve docs around parsing of regexp literals
Bug: T75556
Change-Id: Ifcb6bc21418dfc2e1d3e44dbd2497a0f5f691bf3
Phantom42 [Wed, 20 Dec 2017 15:18:55 +0000 (17:18 +0200)]
Add `margin-bottom` for editButtons (EditPage)
Bug: T179040
Change-Id: I9e6c04556e4ff7f0cc567877041449f50abf4b4c
jenkins-bot [Sun, 24 Dec 2017 15:01:11 +0000 (15:01 +0000)]
Merge "Remove duplicate ServiceWiring definitions"
Translation updater bot [Sat, 23 Dec 2017 20:55:31 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I26ca1588d1f8063a673809759e5b05728e4dc550
addshore [Sat, 23 Dec 2017 17:16:09 +0000 (17:16 +0000)]
Remove duplicate ServiceWiring definitions
Change-Id: I70b377c417ce6937e5d52d1790cf0b6f2ed33c15
jenkins-bot [Sat, 23 Dec 2017 12:08:42 +0000 (12:08 +0000)]
Merge "Set wgCommentTableSchemaMigrationStage in RevisionStoreTest"
addshore [Fri, 22 Dec 2017 17:32:54 +0000 (17:32 +0000)]
[MCR] Don't require $title to be passed to Revision::newFromId
If the title is not passed in as a param (already known) then select
it in Revision::newFromId instead of waiting for it to be selected
further down the tree.
This means that we can use the same Title object to pass into the
RevisionRecord as well as our legacy Revision object.
The selection chooses either a slave or master depending on
recent writes.
This logic used to be in Revision::getTitle and also in
Revision::newFromConds which was called by newFromId
Bug: T183505
Change-Id: I9cf4ce2c3c86d6bf979a3c88eb423b942b9a1ba4
Gergő Tisza [Sun, 19 Nov 2017 22:19:44 +0000 (14:19 -0800)]
Improve documentation of $wgReferrerPolicy
Reference current version of the spec.
Change-Id: I1cca89b9e46a2b5ae8242715eddfdbd23ccb2d83
Umherirrender [Fri, 22 Dec 2017 22:40:57 +0000 (23:40 +0100)]
Update reference to DatabaseBase in hooks.txt
Change-Id: I65f84c0deadb611380e17a5b1b7593876894c099
Translation updater bot [Fri, 22 Dec 2017 20:59:32 +0000 (21:59 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I1edcc9b4af56fb6b66961a14e38d878ff97843e9
jenkins-bot [Fri, 22 Dec 2017 20:39:09 +0000 (20:39 +0000)]
Merge "RCLFilters: support longer page names"
jenkins-bot [Fri, 22 Dec 2017 18:46:27 +0000 (18:46 +0000)]
Merge "resourceloader: Improve JavaScriptMinifier code coverage"
Timo Tijhof [Fri, 22 Dec 2017 17:47:21 +0000 (18:47 +0100)]
JavaScriptMinifier: Remove support for unused $statementsOnOwnLine flag
The $wgResourceLoaderMinifierStatementsOnOwnLine config var was deprecated
in MediaWiki 1.27. The parameter of minify() was not used by other code, and
no new usage has been introduced since then, either.
Remove the feature from JavaScriptMinifier, and add a release note for that.
The same 1.31 release notes also contain a note already about the removal
of the configuration variable.
The feature was not covered by unit tests.
The following private variables have been removed, that are no longer used
due to this change: $newlineBefore, $newlineAfter, $newlineAdded.
Change-Id: I2cbf271156c1954abb982531d0125b4b9573b12c
Stephane Bisson [Fri, 22 Dec 2017 17:13:12 +0000 (12:13 -0500)]
RCLFilters: support longer page names
* Make target page selector at least 400px wide
* Set the page name as title (tooltip)
Bug: T183484
Change-Id: Ife806c0b5e5c2ab6e9be32194804e89daaf8b71c
Moriel Schottlender [Fri, 22 Dec 2017 17:53:40 +0000 (09:53 -0800)]
RCFilters: Move product-specific rules into RCFilters styles
Afterwards, the fix in Vector skin should be merged:
Ie36eeddc46c8ea3d154a006fed2fe578be1cd05c
Change-Id: I8357ef2ff0fe4f46b9ee665ef068624de0afd2e5
Timo Tijhof [Fri, 22 Dec 2017 17:36:09 +0000 (18:36 +0100)]
resourceloader: Improve JavaScriptMinifier code coverage
Change-Id: I234b996cfec8ef48ce3dc48aabbdf88bc9439c15
addshore [Fri, 22 Dec 2017 16:39:00 +0000 (16:39 +0000)]
[MCR] Revision::newFromArchiveRow convert overrides for rows
This method used to overwrite attributes, then passed to
Revision::__construct
RevisionStore::newRevisionFromArchiveRow instead overrides row field
names
This patch adds a conversion for the one field that we need to care
about which is 'page' -> 'page_id'.
After looking through the usages in core and extensions it looks
like this will also fix a bug in the following classes which also
passes in 'page'.
- RevDelArchivedRevisionItem
- RevDelArchiveItem
Bug: T183564
Change-Id: I6a472b93663a0599abb55453c6939463ff56275d
jenkins-bot [Fri, 22 Dec 2017 14:50:04 +0000 (14:50 +0000)]
Merge "[MCR] Add and use $title param to RevisionStore getPrevious/Next"
addshore [Fri, 22 Dec 2017 14:25:12 +0000 (14:25 +0000)]
[MCR] Add and use $title param to RevisionStore getPrevious/Next
When the title is already known use it.
This is similar to the issue fixed in
I714ee391caac9bc56ce4c037967e424b44d9c2fe.
As of this patch all methods within RevisionStore
that call getTitle internally also have an option
to pass in an already known Title object.
Bug: T183548
Change-Id: Ieabca1cf157fb667c75fc907b9da2917f71c61b3
jenkins-bot [Fri, 22 Dec 2017 13:43:44 +0000 (13:43 +0000)]
Merge "Remove ESLint inline comments in WebdriverIO configuration files"
addshore [Fri, 22 Dec 2017 11:05:31 +0000 (11:05 +0000)]
[MCR] Add optional $title param to Revision byId methods
Bug: T183505
Change-Id: I714ee391caac9bc56ce4c037967e424b44d9c2fe
jenkins-bot [Fri, 22 Dec 2017 12:28:16 +0000 (12:28 +0000)]
Merge "Improve coverage of PageArchive"
Amir Sarabadani [Fri, 22 Dec 2017 11:00:13 +0000 (12:00 +0100)]
Improve coverage of PageArchive
Some minor tests
Change-Id: I5c455d6665febc20304e278828ddf8fb3cb5e709
jenkins-bot [Fri, 22 Dec 2017 11:50:15 +0000 (11:50 +0000)]
Merge "RCFilters: Create one single source of truth for item display"
jenkins-bot [Fri, 22 Dec 2017 11:33:27 +0000 (11:33 +0000)]
Merge "[WikiImporter::notice] use wfDebug instead of echo in notice()"
Fomafix [Fri, 22 Dec 2017 11:11:26 +0000 (12:11 +0100)]
jquery.tablesorter.less: Simplify by using less syntax
Change-Id: I4f7ee23c02c6ef0d39cb0135e6669f23b6977c59
Kunal Mehta [Fri, 22 Dec 2017 07:29:08 +0000 (23:29 -0800)]
RevisionTest: Fix @covers tags
Namespaced classes need to be absolutely named.
Change-Id: I48a4b356835e9edf3151a0c8d3bed08ea8cfb452
Kunal Mehta [Tue, 19 Dec 2017 06:01:02 +0000 (22:01 -0800)]
RevisionTest: Make @covers tags absolute (re-apply)
PHPUnit requires @covers tags to be absolute, they cannot depend
upon `use ...` statements.
Change-Id: I06efa94be3a814acbcb116162db162dcbf36432e
Yifei He [Fri, 22 Dec 2017 03:12:28 +0000 (11:12 +0800)]
[WikiImporter::notice] use wfDebug instead of echo in notice()
Make the default notice implementation of notice() function to
send the notice to wfDebug() instead of simply echo to prevent XSS
Bug: T177997
Change-Id: I9ffb597e0642afc1603cdd15e2d09c6f2584b448
jenkins-bot [Fri, 22 Dec 2017 03:07:33 +0000 (03:07 +0000)]
Merge "objectcache: fix getMultiWithUnionSetCallback() doc"
jenkins-bot [Fri, 22 Dec 2017 01:44:22 +0000 (01:44 +0000)]
Merge "shell: Add NO_LOCALSETTINGS restriction"
jenkins-bot [Fri, 22 Dec 2017 01:33:27 +0000 (01:33 +0000)]
Merge "shell: Add debug logging to find binaries that aren't being restricted"
jenkins-bot [Fri, 22 Dec 2017 01:33:23 +0000 (01:33 +0000)]
Merge "shell: Run firejail inside limit.sh, make NO_EXECVE work"
Moriel Schottlender [Tue, 19 Dec 2017 02:25:34 +0000 (18:25 -0800)]
RCFilters: Create one single source of truth for item display
Synchronize the search input, filter view and all view selection into
a single source of truth through the model.
- Stop using OO.ui.MenuSelectWidget's internal filtering logic, and
use our own filtering logic in the model instead.
- Add a concept of 'search' to the model, that is synchronized with
the current search term of the systme. The search dictates the view
and the visible items in the filters.
-- Whenever the search changes for whatever reason,
the model automatically updates the visibility of all items and
groups in the filter list.
-- This means that after changing view or search, the widgets can
always trust that they have the most updated visible item list
to scroll to or select.
- Make the view model's findMatches
as the ultimate source of truth as to what should be visible.
The items are now **always** all included in the menu, but they
change their visibility according to the logic in the findMatches.
If there is a search term, the function will account for that and
the selected view, so we can be sure that search results also
change between changing views.
This allows us to simplify the operation of selecting a tag, where
we know that the order of operation is bound to switching the views,
that will also show us the relevant results. We can bind to the display
event and properly select -- and scroll to -- the item.
Bug: T182720
Bug: T178540
Change-Id: If575f348705d863b9d68d19761ded55a4d453550
addshore [Thu, 14 Dec 2017 23:14:14 +0000 (23:14 +0000)]
[MCR] Use RevisionStore::getArchiveQueryInfo in PageArchive
This is needed to allow RevisionStore to be switched to an
alternative database schema for MCR.
Bug: T174026
Bug: T183509
Change-Id: I51318cb102f6fb8962e608196bee96bde023bcff
addshore [Thu, 21 Dec 2017 14:33:28 +0000 (14:33 +0000)]
[MCR] Add @covers tag for PageArchive::undeleteRevisions
Change-Id: I8dd19244e29f05e22aa5014ec6d6182b5917cc3c
jenkins-bot [Thu, 21 Dec 2017 22:10:35 +0000 (22:10 +0000)]
Merge "[MCR] Add test for PageArchive::listRevisions"
addshore [Thu, 21 Dec 2017 21:18:07 +0000 (21:18 +0000)]
[MCR] Fix RevisionInsertComplete Revision pass by reference
This was broken in:
6af796f3e0cf3e66cd7d7e59af8445f5712d68fe
Ia4c20a91e98df0b9b14b138eb4825c55e5200384
https://gerrit.wikimedia.org/r/#/c/399174/7
Bug: T183503
Change-Id: I674493507ca4aa6677a3bab7a01d6dc3c2cdbc5b
Translation updater bot [Thu, 21 Dec 2017 20:57:18 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Iaad62f37560b8d965c81d72158dbcf5335babdd8
jenkins-bot [Thu, 21 Dec 2017 19:01:05 +0000 (19:01 +0000)]
Merge "ApiBlock: Improve username validation"
jenkins-bot [Thu, 21 Dec 2017 18:40:21 +0000 (18:40 +0000)]
Merge "MCR: Deprecate and gut Revision class"