From bdd721886c90c0556d0507b14ff7da9b9d278767 Mon Sep 17 00:00:00 2001 From: Siebrand Mazeland Date: Sun, 24 Nov 2013 20:20:29 +0100 Subject: [PATCH] Update type hints in TraditionalImageGallery Change-Id: I09c7d15c8717277c0a84c63f1ebdbffb066d8910 --- includes/gallery/TraditionalImageGallery.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/includes/gallery/TraditionalImageGallery.php b/includes/gallery/TraditionalImageGallery.php index 79a7015dd5..cfedac7bae 100644 --- a/includes/gallery/TraditionalImageGallery.php +++ b/includes/gallery/TraditionalImageGallery.php @@ -60,6 +60,7 @@ class TraditionalImageGallery extends ImageGalleryBase { $lang = $this->getRenderLang(); # Output each image... foreach ( $this->mImages as $pair ) { + /** @var Title $nt */ $nt = $pair[0]; $text = $pair[1]; # "text" means "caption" here $alt = $pair[2]; @@ -114,6 +115,7 @@ class TraditionalImageGallery extends ImageGalleryBase { . ( $this->getThumbPadding() + $this->mHeights ) . 'px;">' . htmlspecialchars( $img->getLastError() ) . ''; } else { + /** @var MediaTransformOutput $thumb */ $vpad = $this->getVPad( $this->mHeights, $thumb->getHeight() ); $imageParameters = array( @@ -143,8 +145,10 @@ class TraditionalImageGallery extends ImageGalleryBase { . $thumb->toHtml( $imageParameters ) . ''; // Call parser transform hook - if ( $this->mParser && $img->getHandler() ) { - $img->getHandler()->parserTransformHook( $this->mParser, $img ); + /** @var MediaHandler $handler */ + $handler = $img->getHandler(); + if ( $this->mParser && $handler ) { + $handler->parserTransformHook( $this->mParser, $img ); } } -- 2.20.1