From 27ec1d63779cd336c909e57c86ef8c3cf1e430c7 Mon Sep 17 00:00:00 2001 From: Sam Reed Date: Wed, 21 Sep 2011 16:34:23 +0000 Subject: [PATCH] Comment out unreachable code Remove unreachable return false; --- includes/Export.php | 10 +++++----- includes/WebRequest.php | 2 -- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/includes/Export.php b/includes/Export.php index 2b1a000519..1eab3d6580 100644 --- a/includes/Export.php +++ b/includes/Export.php @@ -480,10 +480,10 @@ class XmlDumpWriter { */ function closePage() { return " \n"; - if ( !$this->firstPageWritten ) { - $this->firstPageWritten = $this->pageInProgress; - } - $this->lastPageWritten = $this->pageInProgress; + //if ( !$this->firstPageWritten ) { + // $this->firstPageWritten = $this->pageInProgress; + //} + //$this->lastPageWritten = $this->pageInProgress; } /** @@ -711,7 +711,7 @@ class DumpOutput { /** * Close the old file, and move it to a specified name. - * Use this for the last piece of a file written out + * Use this for the last piece of a file written out * at specified checkpoints (e.g. every n hours). * @param $newname mixed File name. May be a string or an array with one element * @param $open bool If true, a new file with the old filename will be opened again for writing (default: false) diff --git a/includes/WebRequest.php b/includes/WebRequest.php index 0c3a996020..2abc3d2b05 100644 --- a/includes/WebRequest.php +++ b/includes/WebRequest.php @@ -876,8 +876,6 @@ class WebRequest { } throw new HttpError( 403, 'Invalid file extension found in the path info or query string.' ); - - return false; } return true; } -- 2.20.1