From 0c0f20af2ab87bac170804b83f5edb0f5afd9a1e Mon Sep 17 00:00:00 2001 From: Alexandre Emsenhuber Date: Sat, 19 Jul 2008 20:52:53 +0000 Subject: [PATCH] Removed some PHP4-ism --- includes/ExternalStore.php | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/includes/ExternalStore.php b/includes/ExternalStore.php index 457f00aa9b..e2b7856673 100644 --- a/includes/ExternalStore.php +++ b/includes/ExternalStore.php @@ -17,38 +17,38 @@ class ExternalStore { static function fetchFromURL($url) { global $wgExternalStores; - if (!$wgExternalStores) + if( !$wgExternalStores ) return false; - @list($proto,$path)=explode('://',$url,2); + @list( $proto, $path ) = explode( '://', $url, 2 ); /* Bad URL */ - if ($path=="") + if( $path == '' ) return false; - $store =& ExternalStore::getStoreObject( $proto ); + $store = self::getStoreObject( $proto ); if ( $store === false ) return false; - return $store->fetchFromURL($url); + return $store->fetchFromURL( $url ); } /** * Get an external store object of the given type */ - static function &getStoreObject( $proto ) { + static function getStoreObject( $proto ) { global $wgExternalStores; - if (!$wgExternalStores) + if( !$wgExternalStores ) return false; /* Protocol not enabled */ - if (!in_array( $proto, $wgExternalStores )) + if( !in_array( $proto, $wgExternalStores ) ) return false; - $class='ExternalStore'.ucfirst($proto); + $class = 'ExternalStore' . ucfirst( $proto ); /* Any custom modules should be added to $wgAutoLoadClasses for on-demand loading */ - if (!class_exists($class)) { + if( !class_exists( $class ) ){ return false; } - $store=new $class(); - return $store; + + return new $class(); } /** @@ -59,7 +59,7 @@ class ExternalStore { */ static function insert( $url, $data ) { list( $proto, $params ) = explode( '://', $url, 2 ); - $store =& ExternalStore::getStoreObject( $proto ); + $store = self::getStoreObject( $proto ); if ( $store === false ) { return false; } else { -- 2.20.1