From: Chad Horohoe <demon@users.mediawiki.org>
Date: Wed, 9 Jul 2008 18:14:01 +0000 (+0000)
Subject: (bug 14763) Strict standards issue in DatabasePostgres (also happened with DatabaseOr... 
X-Git-Tag: 1.31.0-rc.0~46599
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/password.php?a=commitdiff_plain;h=fcc6f32017ec533c82630dfd2642c65225b2f6ae;p=lhc%2Fweb%2Fwiklou.git

(bug 14763) Strict standards issue in DatabasePostgres (also happened with DatabaseOracle, no one reported it though).
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index acea80d9eb..0f6dc377ac 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -429,6 +429,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
   application/xhtml+xml. The calls to this have been removed.
 * (bug 14764) Fix regression in from Article::lastModified(), failed to work
   on non-mySQL schemas.
+* (bug 14763) Child classes of Database (DatabasePostgres and DatabaseOracle)
+  had stict standards issues with setFakeSlaveLag() and setFakeMaster().
 
 === API changes in 1.13 ===
 
diff --git a/includes/db/DatabaseOracle.php b/includes/db/DatabaseOracle.php
index d03298ea74..f4dbac71b3 100644
--- a/includes/db/DatabaseOracle.php
+++ b/includes/db/DatabaseOracle.php
@@ -696,8 +696,8 @@ echo "error!\n";
 		return 0;
 	}
 
-	function setFakeSlaveLag() {}
-	function setFakeMaster() {}
+	function setFakeSlaveLag( $lag ) {}
+	function setFakeMaster( $enabled = true ) {}
 
 	function getDBname() {
 		return $this->mDBname;
diff --git a/includes/db/DatabasePostgres.php b/includes/db/DatabasePostgres.php
index 839ca93ce3..4d14b0012b 100644
--- a/includes/db/DatabasePostgres.php
+++ b/includes/db/DatabasePostgres.php
@@ -1357,8 +1357,8 @@ END;
 		return false;
 	}
 
-	function setFakeSlaveLag() {}
-	function setFakeMaster() {}
+	function setFakeSlaveLag( $lag ) {}
+	function setFakeMaster( $enabled = true ) {}
 
 	function getDBname() {
 		return $this->mDBname;