From: Bryan Davis Date: Thu, 4 Feb 2016 16:19:25 +0000 (-0700) Subject: mw.loader: Guard localStorage access with try/catch in mw.store.clear() X-Git-Tag: 1.31.0-rc.0~8076^2 X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/password.php?a=commitdiff_plain;h=f57044ee1c924a5215fbad0a2cd92f40affb7f23;p=lhc%2Fweb%2Fwiklou.git mw.loader: Guard localStorage access with try/catch in mw.store.clear() We use try/catch appropriately in other places but it was missing in mw.store.clear(). If the user agent has localStorage disabled an exception will be thrown for any operation that touches the object. Change-Id: Idcd0e4c8ba9b0843b2ddcad0ae1781e4915e04fe --- diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js index b8349d0f91..90b93dceee 100644 --- a/resources/src/mediawiki/mediawiki.js +++ b/resources/src/mediawiki/mediawiki.js @@ -2251,7 +2251,9 @@ */ clear: function () { mw.loader.store.items = {}; - localStorage.removeItem( mw.loader.store.getStoreKey() ); + try { + localStorage.removeItem( mw.loader.store.getStoreKey() ); + } catch ( ignored ) {} }, /**