From: Brian Wolff Date: Sun, 21 Aug 2011 18:46:01 +0000 (+0000) Subject: Follow-up r86534 - Do not add tracking categories if we're looking at a special page. X-Git-Tag: 1.31.0-rc.0~28137 X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/password.php?a=commitdiff_plain;h=e15cb2b9dbc3effbf6bf9f4f3aeef5e1bcbc3816;p=lhc%2Fweb%2Fwiklou.git Follow-up r86534 - Do not add tracking categories if we're looking at a special page. Thank you Nikerabbit for suggesting how to fix. --- diff --git a/RELEASE-NOTES-1.18 b/RELEASE-NOTES-1.18 index abda92c569..04fa698a54 100644 --- a/RELEASE-NOTES-1.18 +++ b/RELEASE-NOTES-1.18 @@ -438,6 +438,7 @@ production. Windows servers. * (bug 30074) Moving user JS subpages resulted in JS errors because #REDIRECT [[Foo]] is invalid JS +* Tracking categories are no longer shown in footer for special pages === API changes in 1.18 === * BREAKING CHANGE: action=watch now requires POST and token. diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php index 1c96fc4007..3233fbf6b7 100644 --- a/includes/parser/Parser.php +++ b/includes/parser/Parser.php @@ -3956,6 +3956,10 @@ class Parser { * @return Boolean: whether the addition was successful */ protected function addTrackingCategory( $msg ) { + if ( $this->mTitle->getNamespace() === NS_SPECIAL ) { + wfDebug( __METHOD__.": Not adding tracking category $msg to special page!\n" ); + return false; + } $cat = wfMsgForContent( $msg ); # Allow tracking categories to be disabled by setting them to "-"