From: Timo Tijhof <krinklemail@gmail.com>
Date: Sat, 18 Mar 2017 00:04:12 +0000 (-0700)
Subject: mediawiki.widgets: Remove autoEllipsis() from TitleOptionWidget
X-Git-Tag: 1.31.0-rc.0~3748^2
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/password.php?a=commitdiff_plain;h=ac817da014643ac06453f1417d41366892da892c;p=lhc%2Fweb%2Fwiklou.git

mediawiki.widgets: Remove autoEllipsis() from TitleOptionWidget

Redundant with CSS 'text-overflow: ellipsis', which is already applied.

Aside from ellipsis overflow, autoEllipsis() was also serving as indirect
caller of `highlightText( option.matchText )` and `attr('title')`,
which we want to keep, so leave that in its place.

Bug: T160804
Change-Id: I550183750d66d769cc9c960150a2349d1b9181aa
---

diff --git a/resources/Resources.php b/resources/Resources.php
index 392cdb3ff8..4ce326df9a 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -2253,7 +2253,7 @@ return [
 			'mediawiki.api',
 			'jquery.byteLimit',
 			// TitleOptionWidget
-			'jquery.autoEllipsis',
+			'jquery.highlightText',
 		],
 		'messages' => [
 			// NamespaceInputWidget
diff --git a/resources/src/mediawiki.widgets/mw.widgets.TitleOptionWidget.js b/resources/src/mediawiki.widgets/mw.widgets.TitleOptionWidget.js
index 37e6e1afa2..3583e5ec90 100644
--- a/resources/src/mediawiki.widgets/mw.widgets.TitleOptionWidget.js
+++ b/resources/src/mediawiki.widgets/mw.widgets.TitleOptionWidget.js
@@ -65,7 +65,9 @@
 		} );
 
 		// Highlight matching parts of link suggestion
-		this.$label.autoEllipsis( { hasSpan: false, tooltip: true, matchText: config.query } );
+		this.$label
+			.highlightText( config.query )
+			.attr( 'title', config.data );
 
 		if ( config.missing ) {
 			this.$label.addClass( 'new' );