From: Chad Horohoe <chadh@wikimedia.org>
Date: Wed, 18 May 2016 17:38:08 +0000 (-0700)
Subject: RecompressTracked: Remove useless member variable
X-Git-Tag: 1.31.0-rc.0~6921
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/password.php?a=commitdiff_plain;h=78c4afeaffd4eb16cbae2e937959fb696350428a;p=lhc%2Fweb%2Fwiklou.git

RecompressTracked: Remove useless member variable

It's only checked once and has no external users

Change-Id: I6951b799759f1d8b0063a3059bec5c1c64a35815
---

diff --git a/maintenance/storage/recompressTracked.php b/maintenance/storage/recompressTracked.php
index 2f414dfaed..292a25dc95 100644
--- a/maintenance/storage/recompressTracked.php
+++ b/maintenance/storage/recompressTracked.php
@@ -59,7 +59,7 @@ class RecompressTracked {
 	public $reportingInterval = 10;
 	public $numProcs = 1;
 	public $numBatches = 0;
-	public $useDiff, $pageBlobClass, $orphanBlobClass;
+	public $pageBlobClass, $orphanBlobClass;
 	public $slavePipes, $slaveProcs, $prevSlaveId;
 	public $copyOnly = false;
 	public $isChild = false;
@@ -112,8 +112,8 @@ class RecompressTracked {
 		} elseif ( $this->slaveId !== false ) {
 			$GLOBALS['wgDebugLogPrefix'] = "RCT {$this->slaveId}: ";
 		}
-		$this->useDiff = function_exists( 'xdiff_string_bdiff' );
-		$this->pageBlobClass = $this->useDiff ? 'DiffHistoryBlob' : 'ConcatenatedGzipHistoryBlob';
+		$this->pageBlobClass = function_exists( 'xdiff_string_bdiff' ) ?
+			'DiffHistoryBlob' : 'ConcatenatedGzipHistoryBlob';
 		$this->orphanBlobClass = 'ConcatenatedGzipHistoryBlob';
 	}