From: Brion Vibber Date: Mon, 5 Dec 2005 02:20:09 +0000 (+0000) Subject: Don't disappear a parameter in a derived class just because you don't use it; that... X-Git-Tag: 1.6.0~1017 X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/password.php?a=commitdiff_plain;h=72b8bb845f56d07f13e68598a3730de7d68a09d9;p=lhc%2Fweb%2Fwiklou.git Don't disappear a parameter in a derived class just because you don't use it; that's unclean and poor practice --- diff --git a/includes/WebRequest.php b/includes/WebRequest.php index 1b7d3f18d9..cd21edcd2c 100644 --- a/includes/WebRequest.php +++ b/includes/WebRequest.php @@ -458,7 +458,7 @@ class FauxRequest extends WebRequest { wfDebugDieBacktrace( 'FauxRequest::getRequestURL() not implemented' ); } - function appendQuery( ) { + function appendQuery( $query ) { wfDebugDieBacktrace( 'FauxRequest::appendQuery() not implemented' ); }