From: Ævar Arnfjörð Bjarmason <avar@users.mediawiki.org>
Date: Sun, 27 Mar 2005 05:15:10 +0000 (+0000)
Subject: * (bug 1765) Tidy causes corruption inside <gallery>
X-Git-Tag: 1.5.0alpha1~491
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/password.php?a=commitdiff_plain;h=685139a981cc69ca39bd0eeaf608baff47549771;p=lhc%2Fweb%2Fwiklou.git

* (bug 1765) Tidy causes corruption inside <gallery>
---

diff --git a/includes/ImageGallery.php b/includes/ImageGallery.php
index d7819b5eb9..8ee152a282 100644
--- a/includes/ImageGallery.php
+++ b/includes/ImageGallery.php
@@ -132,9 +132,12 @@ class ImageGallery
 			$s .= ($i%4==0) ? '<tr>' : '';
 			$thumb = $img->getThumbnail( 120, 120 );
 			$vpad = floor( ( 150 - $thumb->height ) /2 ) - 2;
-			$s .= '<td><div class="gallerybox">' .
-				'<div class="thumb" style="padding: ' . $vpad . 'px 0;">'.
-				$sk->makeKnownLinkObj( $nt, $thumb->toHtml() ) . '</div><div class="gallerytext">' .
+			$s .= '<td><div class="gallerybox">' . '<div class="thumb" style="padding: ' . $vpad . 'px 0;">';
+			
+			# ATTENTION: The newline after <div class="gallerytext"> is needed to accommodate htmltidy which
+			# in version 4.8.6 generated crackpot html in its absence, see:
+			# http://bugzilla.wikimedia.org/show_bug.cgi?id=1765
+			$s .= $sk->makeKnownLinkObj( $nt, $thumb->toHtml() ) . '</div><div class="gallerytext">' . "\n" .
 				$textlink . $text . $nb .
 				'</div>';
 			$s .= "</div></td>\n";