From: Aaron Schulz <aaron@users.mediawiki.org>
Date: Fri, 12 Aug 2011 16:50:03 +0000 (+0000)
Subject: Fix for r94289: we want to skip rows with non-empty sha1, not non-NULL (which is... 
X-Git-Tag: 1.31.0-rc.0~28313
X-Git-Url: http://git.cyclocoop.org/%7B%24www_url%7Dadmin/password.php?a=commitdiff_plain;h=537a6eb680b3f7ea9c8eb0c740ae3a02bd64678f;p=lhc%2Fweb%2Fwiklou.git

Fix for r94289: we want to skip rows with non-empty sha1, not non-NULL (which is impossible)
---

diff --git a/maintenance/populateRevisionSha1.php b/maintenance/populateRevisionSha1.php
index 3e490d10da..266b65acc4 100644
--- a/maintenance/populateRevisionSha1.php
+++ b/maintenance/populateRevisionSha1.php
@@ -68,7 +68,7 @@ class PopulateRevisionSha1 extends Maintenance {
 		while ( $blockEnd <= $end ) {
 			$this->output( "...doing $idCol from $blockStart to $blockEnd\n" );
 			$cond = "$idCol BETWEEN $blockStart AND $blockEnd
-				AND $idCol IS NOT NULL AND {$prefix}_sha1 IS NOT NULL";
+				AND $idCol IS NOT NULL AND {$prefix}_sha1 != ''";
 			$res = $db->select( $table, '*', $cond, __METHOD__ );
 
 			$db->begin();