Merge "don't overwrite $item['single-id'] in makeListItem in SkinTemplate"
authorIAlex <ialex.wiki@gmail.com>
Sun, 21 Oct 2012 12:54:28 +0000 (12:54 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Sun, 21 Oct 2012 12:54:28 +0000 (12:54 +0000)
1  2 
includes/SkinTemplate.php

@@@ -503,7 -503,6 +503,7 @@@ class SkinTemplate extends Skin 
         * By default it is capitalized.
         *
         * @param $name string Language name, e.g. "English" or "espaƱol"
 +       * @return string
         * @private
         */
        function formatLanguageName( $name ) {
@@@ -1444,7 -1443,6 +1444,7 @@@ abstract class BaseTemplate extends Qui
                }
                if ( isset( $this->data['nav_urls']['info'] ) && $this->data['nav_urls']['info'] ) {
                        $toolbox['info'] = $this->data['nav_urls']['info'];
 +                      $toolbox['info']['id'] = 't-info';
                }
  
                wfRunHooks( 'BaseTemplateToolbox', array( &$this, &$toolbox ) );
                        foreach ( array( 'id', 'class', 'active', 'tag' ) as $k ) {
                                unset( $link[$k] );
                        }
-                       if ( isset( $item['id'] ) ) {
+                       if ( isset( $item['id'] ) && !isset( $item['single-id'] ) ) {
                                // The id goes on the <li> not on the <a> for single links
                                // but makeSidebarLink still needs to know what id to use when
                                // generating tooltips and accesskeys.