Removed optional '?>' from end of generated config file
authorGregory Szorc <gszorc@users.mediawiki.org>
Sat, 3 Feb 2007 06:52:37 +0000 (06:52 +0000)
committerGregory Szorc <gszorc@users.mediawiki.org>
Sat, 3 Feb 2007 06:52:37 +0000 (06:52 +0000)
This will prevent people with poor editors (Windows) from accidentally introducing blank lines after the '?>', which we all know breaks XML output

config/index.php

index 47ad78c..b2165c4 100644 (file)
@@ -912,7 +912,7 @@ if( $conf->posted && ( 0 == count( $errs ) ) ) {
                /* Write out the config file now that all is well */
                print "<li style=\"list-style: none\">\n";
                print "<p>Creating LocalSettings.php...</p>\n\n";
-               $localSettings = "<" . "?php$endl$local$endl?" . ">\r\n";
+               $localSettings = "<" . "?php$endl$local$endl\r\n";
                // Fix up a common line-ending problem (due to CVS on Windows)
                $localSettings = str_replace( "\r\n", "\n", $localSettings );
                $f = fopen( "LocalSettings.php", 'xt' );