(bug 2971) Standardize format of links to hist/diff in Special:Contributions.
authorAryeh Gregor <simetrical@users.mediawiki.org>
Sun, 20 Jul 2008 17:42:14 +0000 (17:42 +0000)
committerAryeh Gregor <simetrical@users.mediawiki.org>
Sun, 20 Jul 2008 17:42:14 +0000 (17:42 +0000)
RELEASE-NOTES
includes/specials/SpecialContributions.php

index ac1d4ef..740d874 100644 (file)
@@ -188,6 +188,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
   the database is potentially queried
 * (bug 9736) Redirects on Special:Fewestrevisions are now marked as such.
 * New date/time formats in Cs localization according to ČSN and PČP.
+* (bug 2971) Standardize format of links to hist/diff in Special:Contributions.
  
 === Bug fixes in 1.13 ===
 
index 4a131f1..bba3f53 100644 (file)
@@ -162,7 +162,7 @@ class ContribsPager extends ReverseChronologicalPager {
                if( $row->rev_id == $row->page_latest ) {
                        $topmarktext .= '<strong>' . $this->messages['uctop'] . '</strong>';
                        if( !$row->page_is_new ) {
-                               $difftext .= '(' . $sk->makeKnownLinkObj( $page, $this->messages['diff'], 'diff=0' ) . ')';
+                               $difftext .= $sk->makeKnownLinkObj( $page, $this->messages['diff'], 'diff=0' );
                        } else {
                                $difftext .= $this->messages['newarticle'];
                        }
@@ -175,11 +175,11 @@ class ContribsPager extends ReverseChronologicalPager {
                }
                # Is there a visible previous revision?
                if( $rev->userCan(Revision::DELETED_TEXT) ) {
-                       $difftext = '(' . $sk->makeKnownLinkObj( $page, $this->messages['diff'], 'diff=prev&oldid='.$row->rev_id ) . ')';
+                       $difftext = $sk->makeKnownLinkObj( $page, $this->messages['diff'], 'diff=prev&oldid='.$row->rev_id );
                } else {
-                       $difftext = '(' . $this->messages['diff'] . ')';
+                       $difftext = $this->messages['diff'];
                }
-               $histlink='('.$sk->makeKnownLinkObj( $page, $this->messages['hist'], 'action=history' ) . ')';
+               $histtext = $sk->makeKnownLinkObj( $page, $this->messages['hist'], 'action=history' );
 
                $comment = $wgContLang->getDirMark() . $sk->revComment( $rev, false, true );
                $d = $wgLang->timeanddate( wfTimestamp( TS_MW, $row->rev_timestamp ), true );
@@ -207,7 +207,7 @@ class ContribsPager extends ReverseChronologicalPager {
                        $mflag = '';
                }
 
-               $ret = "{$d} {$histlink} {$difftext} {$nflag}{$mflag} {$link}{$userlink}{$comment} {$topmarktext}";
+               $ret = "$d ($difftext; $histtext) {$nflag}{$mflag} {$link}{$userlink}{$comment} $topmarktext";
                if( $rev->isDeleted( Revision::DELETED_TEXT ) ) {
                        $ret .= ' ' . wfMsgHtml( 'deletedrev' );
                }