Fully deprecate $wgProxyKey. Has been marked as deprecated since 1.4, but never seems...

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 9886635..19b60ce 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -46,6 +46,9 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * $wgAllowExternalImagesFrom may now be an array of multiple strings.
 * Introduced $wgEnableImageWhitelist to toggle the on-wiki external image
   whitelist on or off.
+* $wgProxyKey has been fully deprecated (marked as such since 1.4, never
+  seems to have been completed). $wgSecretKey is the official documented
+  setting now.
   
 === New features in 1.14 ===
 

diff --git a/config/index.php b/config/index.php
index a0d7f4f..785ec21 100644 (file)
--- a/config/index.php
+++ b/config/index.php
@@ -1706,7 +1706,7 @@ if ( \$wgCommandLineMode ) {
 
 \$wgLanguageCode = \"{$slconf['LanguageCode']}\";
 
-\$wgProxyKey = \"$secretKey\";
+\$wgSecretKey = \"$secretKey\";
 
 ## Default skin: you can change the default skin. Use the internal symbolic
 ## names, ie 'standard', 'nostalgia', 'cologneblue', 'monobook':

diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index ef02aae..64a0cab 100644 (file)
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -1357,8 +1357,6 @@ $wgProxyMemcExpiry = 86400;
 $wgSecretKey = false;
 /** big list of banned IP addresses, in the keys not the values */
 $wgProxyList = array();
-/** deprecated */
-$wgProxyKey = false;
 
 /** Number of accounts each IP address may create, 0 to disable.
  * Requires memcached */

diff --git a/includes/ProxyTools.php b/includes/ProxyTools.php
index 759857d..a89283c 100644 (file)
--- a/includes/ProxyTools.php
+++ b/includes/ProxyTools.php
@@ -138,7 +138,7 @@ function wfIsTrustedProxy( $ip ) {
 function wfProxyCheck() {
        global $wgBlockOpenProxies, $wgProxyPorts, $wgProxyScriptPath;
        global $wgMemc, $wgProxyMemcExpiry;
-       global $wgProxyKey;
+       global $wgSecretKey;
 
        if ( !$wgBlockOpenProxies ) {
                return;
@@ -154,7 +154,7 @@ function wfProxyCheck() {
        # Fork the processes
        if ( !$skip ) {
                $title = SpecialPage::getTitleFor( 'Blockme' );
-               $iphash = md5( $ip . $wgProxyKey );
+               $iphash = md5( $ip . $wgSecretKey );
                $url = $title->getFullURL( 'ip='.$iphash );
 
                foreach ( $wgProxyPorts as $port ) {

diff --git a/includes/Setup.php b/includes/Setup.php
index ecc6def..148af48 100644 (file)
--- a/includes/Setup.php
+++ b/includes/Setup.php
@@ -150,6 +150,10 @@ require_once( "$IP/includes/StubObject.php" );
 wfProfileOut( $fname.'-includes' );
 wfProfileIn( $fname.'-misc1' );
 
+# Override SecretKey with ProxyKey if a site is using the old setting
+if ( isset( $wgProxyKey ) ) {
+       $wgSecretKey = $wgProxyKey;
+}
 
 $wgIP = false; # Load on demand
 # Can't stub this one, it sets up $_GET and $_REQUEST in its constructor

diff --git a/includes/User.php b/includes/User.php
index 5fa2ff5..25791e4 100644 (file)
--- a/includes/User.php
+++ b/includes/User.php
@@ -1650,13 +1650,11 @@ class User {
         * @private
         */
        function setToken( $token = false ) {
-               global $wgSecretKey, $wgProxyKey;
+               global $wgSecretKey;
                $this->load();
                if ( !$token ) {
                        if ( $wgSecretKey ) {
                                $key = $wgSecretKey;
-                       } elseif ( $wgProxyKey ) {
-                               $key = $wgProxyKey;
                        } else {
                                $key = microtime();
                        }

diff --git a/includes/specials/SpecialBlockme.php b/includes/specials/SpecialBlockme.php
index f222e3c..81d3684 100644 (file)
--- a/includes/specials/SpecialBlockme.php
+++ b/includes/specials/SpecialBlockme.php
@@ -8,11 +8,11 @@
  *
  */
 function wfSpecialBlockme() {
-       global $wgRequest, $wgBlockOpenProxies, $wgOut, $wgProxyKey;
+       global $wgRequest, $wgBlockOpenProxies, $wgOut, $wgSecretKey;
 
        $ip = wfGetIP();
 
-       if( !$wgBlockOpenProxies || $wgRequest->getText( 'ip' ) != md5( $ip . $wgProxyKey ) ) {
+       if( !$wgBlockOpenProxies || $wgRequest->getText( 'ip' ) != md5( $ip . $wgSecretKey ) ) {
                $wgOut->addWikiMsg( 'proxyblocker-disabled' );
                return;
        }