From e1f5364f562d729a5f33eb9bbc85c6ad0f049361 Mon Sep 17 00:00:00 2001 From: Derick Alangi Date: Thu, 11 Apr 2019 23:03:57 +0100 Subject: [PATCH] dao: Correct return type doc for getLoadBalancer() This method creates a load balancer object using services and calls getMainLB() which returns an instance of ILoadBalancer and not an instance of LoadBalancer, hence, getLoadBalancer() should return an instance of ILoadBalancer instead. Change-Id: I8859f293985d256d02ddc6f90e2aea813ebfc955 --- includes/dao/DBAccessBase.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/dao/DBAccessBase.php b/includes/dao/DBAccessBase.php index 8900962225..e099b38f09 100644 --- a/includes/dao/DBAccessBase.php +++ b/includes/dao/DBAccessBase.php @@ -2,7 +2,7 @@ use MediaWiki\MediaWikiServices; use Wikimedia\Rdbms\IDatabase; -use Wikimedia\Rdbms\LoadBalancer; +use Wikimedia\Rdbms\ILoadBalancer; /** * Base class for objects that allow access to other wiki's databases using @@ -88,7 +88,7 @@ abstract class DBAccessBase implements IDBAccessObject { * * @since 1.21 * - * @return LoadBalancer The database load balancer object + * @return ILoadBalancer The database load balancer object */ public function getLoadBalancer() { $lbFactory = MediaWikiServices::getInstance()->getDBLoadBalancerFactory(); -- 2.20.1