From b18add24a99d78b7274a7d896f40fac7b7a2a523 Mon Sep 17 00:00:00 2001 From: "James D. Forrester" Date: Wed, 16 Mar 2016 10:53:33 +0000 Subject: [PATCH] Set $wgIncludeLegacyJavaScript false by default This setting was deprecated in 0ac4f998 but was left as true by default, which means sysadmins weren't prompted to find and fix faulty code. Setting this to false by default gives them a release in which to fix the code (setting this back to true until such fixes are made) before we remove it entirely in the next MediaWiki release. Extensions, skins, gadgets and scripts that need the mediawiki.legacy.wikibits module should express a dependency on it in their ResourceLoader manifest. Bug: T35836 Change-Id: If787d0975b6019827e81f4ea0d90898e361d9acd --- RELEASE-NOTES-1.27 | 3 +++ includes/DefaultSettings.php | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/RELEASE-NOTES-1.27 b/RELEASE-NOTES-1.27 index 2f8f53a1b3..ac19d39952 100644 --- a/RELEASE-NOTES-1.27 +++ b/RELEASE-NOTES-1.27 @@ -104,6 +104,9 @@ HHVM 3.1. * $wgPreloadJavaScriptMwUtil was removed (deprecated in 1.26). Extensions, skins, gadgets and scripts that use the mediawiki.util module must express a dependency on it. +* $wgIncludeLegacyJavaScript, deprecated in MediaWiki 1.26, now defaults false. + Extensions, skins, gadgets and scripts that need the mediawiki.legacy.wikibits + module should express a dependency on it. === New features in 1.27 === * $wgDataCenterUpdateStickTTL was also added. This decides how long a user diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php index 63d04c95ba..33b16542b4 100644 --- a/includes/DefaultSettings.php +++ b/includes/DefaultSettings.php @@ -3562,7 +3562,7 @@ $wgResourceLoaderMinifierMaxLineLength = 1000; * * @deprecated since 1.26: Always declare dependencies. */ -$wgIncludeLegacyJavaScript = true; +$wgIncludeLegacyJavaScript = false; /** * Whether or not to assign configuration variables to the global window object. -- 2.20.1