From a7ccb0fbb312d52bcf4ab2345e6dd55e1d6d24d3 Mon Sep 17 00:00:00 2001 From: Daniel Friesen Date: Fri, 14 Jan 2011 22:46:08 +0000 Subject: [PATCH] Fix boolean for $editnotice_base message existance check that was messed up in r80248. Also switch to using === for '' and '-' comparison like Nikerabbit wanted. --- includes/EditPage.php | 2 +- includes/Message.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/includes/EditPage.php b/includes/EditPage.php index 71d73579f6..2dda909b7b 100644 --- a/includes/EditPage.php +++ b/includes/EditPage.php @@ -400,7 +400,7 @@ class EditPage { while ( count( $parts ) > 0 ) { $editnotice_base .= '-'.array_shift( $parts ); $editnotice_base_msg = wfMessage( $editnotice_base )->inContentLanguage(); - if ( !$editnotice_base_msg->exists() ) { + if ( $editnotice_base_msg->exists() ) { $wgOut->addWikiText( $editnotice_base_msg->plain() ); } } diff --git a/includes/Message.php b/includes/Message.php index 4e2e153db6..c0a33c9d1a 100644 --- a/includes/Message.php +++ b/includes/Message.php @@ -314,7 +314,7 @@ class Message { */ public function isBlank() { $message = $this->fetchMessage(); - return $message === false || $message == ''; + return $message === false || $message === ''; } /** @@ -323,7 +323,7 @@ class Message { */ public function isDisabled() { $message = $this->fetchMessage(); - return $message === false || $message == '' || $message == '-'; + return $message === false || $message === '' || $message === '-'; } public static function rawParam( $value ) { -- 2.20.1