From 7ff53f8e07b03189a00d951bef8c277bb467b7eb Mon Sep 17 00:00:00 2001 From: =?utf8?q?Thiemo=20M=C3=A4ttig?= Date: Thu, 26 Mar 2015 10:43:01 +0100 Subject: [PATCH] Fix misleading $class = false default in Html::infoBox I found this because my PHPStorm complains about the type mismatch. I could have changed the @param tag to "string|bool", but when looking at the code, the $class variable is casted to a string anyway and never used as a bool. Change-Id: I3450fa8a898923bbae26830ed3be0017685020d3 --- includes/Html.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/Html.php b/includes/Html.php index c172ae0488..6bd661fae7 100644 --- a/includes/Html.php +++ b/includes/Html.php @@ -997,7 +997,7 @@ class Html { * * @return string */ - static function infoBox( $text, $icon, $alt, $class = false ) { + static function infoBox( $text, $icon, $alt, $class = '' ) { $s = Html::openElement( 'div', array( 'class' => "mw-infobox $class" ) ); $s .= Html::openElement( 'div', array( 'class' => 'mw-infobox-left' ) ) . -- 2.20.1